Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 06 Oct 2023 10:50:58 +0200
Message-ID: <87ttr4w2vh.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Thomas Perl <m@thp.io>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "trivial@kernel.org" <trivial@kernel.org>
Subject: Re: [PATCH] sound: fix name of SIS7013 sound chip in comment
In-Reply-To: <5E4B5CA1-1109-4C82-A581-838ACF19A15D@thp.io>
References: <5E4B5CA1-1109-4C82-A581-838ACF19A15D@thp.io>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 27 Sep 2023 09:17:32 +0200,
Thomas Perl wrote:
> 
> While grep'ing for SIS7012, I noticed that there is
> only one reference to it in sound/pci/intel8x0m.c,
> while most of its code lives in sound/pci/intel8x0.c.
> 
> This probably was a simple copy'n'paste mistake, as
> the sound/pci/intel8x0m.c driver implements support
> for SIS7013 (see DEVICE_SIS), and the two devices
> seem to share the same behavior / registers.
> 
> Signed-off-by: Thomas Perl <m@thp.io>

Thanks for the patch.

Unfortunately the patch isn't applicable cleanly, likely due to your
mailer malformed the spaces.  As it's a really trivial change, I fixed
manually now.  But, at the next time, please try to fix your mailer
setup and at best test the patch application by yourself beforehand.


Takashi


> ---
>  sound/pci/intel8x0m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/intel8x0m.c b/sound/pci/intel8x0m.c
> index 2845cc006d0c..653ecca78238 100644
> --- a/sound/pci/intel8x0m.c
> +++ b/sound/pci/intel8x0m.c
> @@ -918,7 +918,7 @@ static int snd_intel8x0m_ich_chip_init(struct intel8x0m *chip, int probing)
>   }
>     if (chip->device_type == DEVICE_SIS) {
> - /* unmute the output on SIS7012 */
> + /* unmute the output on SIS7013 */
>   iputword(chip, 0x4c, igetword(chip, 0x4c) | 1);
>   }
>   --  2.39.2
>