Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Fri, 06 Oct 2023 10:52:21 +0200
Message-ID: <87sf6ow2t6.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ivan Orlov <ivan.orlov0322@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: aloop: Add support for the non-interleaved access mode
In-Reply-To: <20230927113555.14877-1-ivan.orlov0322@gmail.com>
References: <20230927113555.14877-1-ivan.orlov0322@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 27 Sep 2023 13:35:54 +0200,
Ivan Orlov wrote:
> 
> The current version of the loopback driver supports interleaved access
> mode only. This patch introduces support for the non-interleaved
> access mode.
> 
> When in the interleaved mode, the 'copy_play_buf' function copies data
> from the playback to the capture buffer using one memcpy call. This call
> copies samples for multiple, interleaved channels.
> 
> In the non-interleaved mode we have multiple channel buffers, so we have
> to perform multiple memcpy calls to copy samples channel after channel.
> 
> Add new function called 'copy_play_buf_part_n', which copies a part of
> each channel buffer from playback to capture. Modify the 'copy_play_buf'
> to use the corresponding memory copy function(just memcpy /
> copy_play_buf_part_n) depending on the access mode.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>

Sorry for the late reaction, as I've been (still) off since the last
week.

Now applied both patches.  Thanks.


Takashi