Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp246709rdb;
        Fri, 6 Oct 2023 02:07:13 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IEs+4cVjstGf2SFINVzxRB95KytGiHJnRb5w5CluAAqZzsrTN4AMO5UqSGGtg1unvjqdjcS
X-Received: by 2002:a05:6808:19a9:b0:3a7:37ae:4a47 with SMTP id bj41-20020a05680819a900b003a737ae4a47mr9548226oib.12.1696583233145;
        Fri, 06 Oct 2023 02:07:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696583233; cv=none;
        d=google.com; s=arc-20160816;
        b=LQHPVqLKcNwujv5Qf64GyPkRyHr1fbQ6ffCtVOW7EHwefBLDQGuKFQuLIqlRJSl6ya
         Wxvg9sIc9pw+V0jLwKbRSvesX4P8mIxHUkA9JP2NEEqttLGil2XMWK6pF7yChsee6Q43
         YJwvJhuvV9Xy/wjsFecis+ZQ73lqv+R+ljVkjtKKNohpWiBhhOx5+Pe0atGs7sx1AwNm
         GIP8P2Ew8F5z3GbJha4AjHBib5tk3dREIkT5RXFNJJhLgLgiLKHCZ/WVs6+SiP+sBhWG
         iltLrfMU8we5Ovlb/xZesq6vTn6okYHYbONfL5hNQHGC8HQW0DmTNPAeNiQyfoC6UOwC
         27vQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature;
        bh=WpnHH57W2rqGvjWQNsMwZCbEstkqESxFibpY09kHSig=;
        fh=pbtt8BrSA2Bb66sO7K30N0Np+DubOtu55QarbkK+2X0=;
        b=0QhX9qFNIlxAojeavcyhkIzTgHC2E/zbHAZuqZB3A1vPysrY7o7VD7+02Zy5W2jlsH
         gD8fz3k70aRNwTNBiQw034uv73el5D1DNahFE7WAxgzgYdGtGghKVrWHixdsD2+YdWjQ
         yALU5tugHzKynW8iwVP0Kpo5XdSpWc4PHeUCiIxIVUjhLlACY3Y6ZU2hd3MxiH3TRueb
         tVzLgcqDmBSuTmwjZhRg/+sZxB1oWjdKbRFc5POPxcuakP7BUKer46UJxjS4vHfSnz9k
         Wr/8HyS655Dq9C91oZkZv07DGN0WmW91ZC22DQVCkgbeKh6dGnY171ifkyA6gX4S9dTx
         HHqA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=fHAUunXW;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from howler.vger.email (howler.vger.email. [23.128.96.34])
        by mx.google.com with ESMTPS id m1-20020a656a01000000b00578da0d5b6bsi3648792pgu.724.2023.10.06.02.07.11
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 06 Oct 2023 02:07:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=fHAUunXW;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
	by howler.vger.email (Postfix) with ESMTP id 0C29D802D0F4;
	Fri,  6 Oct 2023 02:06:36 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231375AbjJFJGX (ORCPT <rfc822;smith.dustin2017@gmail.com>
        + 99 others); Fri, 6 Oct 2023 05:06:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231215AbjJFJGV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Oct 2023 05:06:21 -0400
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A094FAC
        for <linux-kernel@vger.kernel.org>; Fri,  6 Oct 2023 02:06:19 -0700 (PDT)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by smtp-out1.suse.de (Postfix) with ESMTPS id 5F42D2184F;
        Fri,  6 Oct 2023 09:06:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1696583178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=WpnHH57W2rqGvjWQNsMwZCbEstkqESxFibpY09kHSig=;
        b=fHAUunXWyVaIeY20CuyxusDqAlgcOQUS5pngiLHz2p6Kvffm5JrVRiss+XIYDm0keZ4eSz
        5wGdCMQxOhCU2bhNQu/XOcy60dqDxOYA1hTnegKTcYfPgykNa6cH++HMbJ24l9d+NLfISh
        DNSiPJL/pDA9HQlwd1rfKZlqGDe63SY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1696583178;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=WpnHH57W2rqGvjWQNsMwZCbEstkqESxFibpY09kHSig=;
        b=En1gdIt9xO52znWYshL/J8MO59g1hrsnGrdGYBpmh5uUg8o1N4GLfUEcK+Mb0BbzcazTYh
        5yU+2i3ix38DCMDA==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F76513A2E;
        Fri,  6 Oct 2023 09:06:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
        by imap2.suse-dmz.suse.de with ESMTPSA
        id +j68BgrOH2WkKwAAMHmgww
        (envelope-from <tiwai@suse.de>); Fri, 06 Oct 2023 09:06:18 +0000
Date:   Fri, 06 Oct 2023 11:06:17 +0200
Message-ID: <87mswww25y.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>, kernel test robot <lkp@intel.com>,
        "Dan Carpenter" <dan.carpenter@linaro.org>
Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Cleanup and fix double free in firmware request
In-Reply-To: <20231003142138.180108-1-sbinding@opensource.cirrus.com>
References: <20231003142138.180108-1-sbinding@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 02:06:36 -0700 (PDT)

On Tue, 03 Oct 2023 16:21:38 +0200,
Stefan Binding wrote:
> 
> There is an unlikely but possible double free when loading firmware,
> and a missing free calls if a firmware is successfully requested but
> the coefficient file request fails, leading to the fallback firmware
> request occurring without clearing the previously loaded firmware.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202309291331.0JUUQnPT-lkp@intel.com/
> 
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>

Applied now (with additional Fixes tag).
At the next time, please try to put the Fixes tag for a fix like
this.


thanks,

Takashi