Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20231005181747.3017588-1-florian.fainelli@broadcom.com>
In-Reply-To: <20231005181747.3017588-1-florian.fainelli@broadcom.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 6 Oct 2023 11:23:24 +0200
Message-ID: <CANn89iKF65tsKRXoAx6tPmgf-y6zBdT7OgNShNrVjdPjGNOEsA@mail.gmail.com>
Subject: Re: [PATCH net-next] net: bcmgenet: Remove custom ndo_poll_controller()
To:     Florian Fainelli <florian.fainelli@broadcom.com>
Cc:     netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 8:19=E2=80=AFPM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> The driver gained a .ndo_poll_controller() at a time where the TX
> cleaning process was always done from NAPI which makes this unnecessary.
> See commit ac3d9dd034e5 ("netpoll: make ndo_poll_controller() optional")
> for more background.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Eric Dumazet <edumazet@google.com>

Yes, many drivers should do the same...