Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   John Ogness <john.ogness@linutronix.de>
To:     Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Todd Brandt <todd.e.brandt@intel.com>,
        linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2 2/2] printk: Reduce pr_flush() pooling time
In-Reply-To: <20231006082151.6969-3-pmladek@suse.com>
References: <20231006082151.6969-1-pmladek@suse.com>
 <20231006082151.6969-3-pmladek@suse.com>
Date:   Fri, 06 Oct 2023 12:18:06 +0206
Message-ID: <87wmw0vz49.fsf@jogness.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 2023-10-06, Petr Mladek <pmladek@suse.com> wrote:
> pr_flush() does not guarantee that all messages would really get flushed
> to the console. The best it could do is to wait with a given timeout.[*]
>
> The current interval 100ms for checking the progress might seem too
> long in some situations. For example, such delays are not appreciated
> during suspend and resume especially when the consoles have been flushed
> "long" time before the check.
>
> One the other hand, the sleeping wait might be useful in other situations.

  "One" should be "On"

Otherwise the patch looks OK to me. Thanks!

Reviewed-by: John Ogness <john.ogness@linutronix.de>