Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp280751rdb; Fri, 6 Oct 2023 03:25:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9WV3BJztfwnCza5Y1hqfVU0E3JgnCfeQ3dgIEYLBYMcGcXFYzTtm52L+KFKvdOP67ej1x X-Received: by 2002:a05:6a20:6a27:b0:15a:6733:24e2 with SMTP id p39-20020a056a206a2700b0015a673324e2mr6164674pzk.25.1696587954459; Fri, 06 Oct 2023 03:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696587954; cv=none; d=google.com; s=arc-20160816; b=tyXfhTNcn2N9QQw0MIGid8ZTutUKol2jajyTHTveE0KWIBWaAX1+yFIwH/0ii7SiMj Te7Nu38cp2uKZsmWkCRijk01rHGwF6Txi2xbKziMMVgEcSEZBovy3c2sFI0Gu03sR0rM QAo5U3Zqsv3BYZtB7F0EW8NAPy9FBma2UOxV1Ql9ky2E+QbEtRjM8rRW/6YyQ8e7ZMqk tlbO0HPHvBA4ZIH8TU5TWgIM32pLdzdYwG65G/Z6dMylIlBxlXgBawLJIXe2LPBolD4S 6HhDM5XgfOOBc5ShjXp+ufZs6QieQU6yWVRwdsT7+vzNlfsqbSzkJFtdiWNX2ftb1KwV 3/Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=C9fUuQgN+anlMMoJHDkj24MjGD80W1ske574ToiOc/8=; fh=vpy21g+J0gdi07r6ORLEdtAph1WvtREpjU5Tu1A//7s=; b=TlphDNE2+HDbic//xJ6d7uxvBGwOPuKwVOSENJpn/r4110/DL05bXfboIpxa+Ef7C9 IGLe7ALxUhorVSEcCJ2eZOSw5u4nNfPEypapEl4Sox6jJFnx1tMTmrCB08B8DrDVnOoW pa6JiXa2SRlfW3NKmRbyfYHHg8eYWb6GMK1q1oteuZps+JRd++iT/K9A7ydSlQ8FHy0P aeEPWAx0alGvqheMc6iL0d9RKqIMJf+1G4h+Mzy1ugV9LacE7AIeChKvQplb2Jh0qrPh sCtdhnQGjqQtd51a5lwxnXCDtnKHcAR6cuqh3McqnRGZIYOmoZleffvCwXUJHCYy20Xz EC9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZkZ1CATW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bs188-20020a6328c5000000b0056952b496efsi1137135pgb.366.2023.10.06.03.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 03:25:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZkZ1CATW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 78E3F84049FA; Fri, 6 Oct 2023 03:25:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231738AbjJFKZg (ORCPT + 99 others); Fri, 6 Oct 2023 06:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231695AbjJFKZa (ORCPT ); Fri, 6 Oct 2023 06:25:30 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42380BE for ; Fri, 6 Oct 2023 03:25:29 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9b6559cbd74so363692966b.1 for ; Fri, 06 Oct 2023 03:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696587927; x=1697192727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=C9fUuQgN+anlMMoJHDkj24MjGD80W1ske574ToiOc/8=; b=ZkZ1CATWo9pbiokQ7Gl/VQVPFbRNF5emwTWssOMI2SXJIqQT1Yhtm57MNjpEVMKdp7 IC4nbL3upeOSJgRH764ZTuGtb61n5vVQZZuA1zd5Yx7BCnfwKG8YnGnLsf5aVcdi3kuJ YnHl87UM1S2/uol2p+geoRoTJKbTp+iK4715xYmrsv+UZc7wdcT9D2alOcHPB6RiDcoZ G24Lnj9Kn6taqYy9m+q/TlcHj2SuXWEjWXde5HVnu+0HbfsO5kMWoxDQRovDEU/U4q3Y kwmzMn7vtvpCoT/0rTYAgZN9f1Cjo/BKZ+iK2ejT7jQFP8j4j8AtHjvrJI1cs4i+nZsh FUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696587927; x=1697192727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=C9fUuQgN+anlMMoJHDkj24MjGD80W1ske574ToiOc/8=; b=t0fUXwAr8Q5gPs1O3iU5uU1K05XEyCiEu/96KjLYjaY+7i8R0q7LtysM+EL2iO0Bl1 Eg3agO7iQDKOhB3dnteL+BxIHbZkSbRZGkO+yW2TMVr4kbtlOUaPGwu1FbQ9B51wglnK 3ybzU8rX7Qe1LbKqIOQBLfRniTDwY4yQubZo/phMwDxsBSi3Cbi4PA0JJDq/iIbm/w9/ CZzv3jRZauludIbHe/CX35NCpi4ROtssPHw0liC2lb5gFrPa6Wdk7pkD9bg3qOitJp8q Qejzx9TC6fYCwt2jHoUmy8bffFbIyfWoVlhhrB7n4NZGyp0Jj3pCgjVqwAnReJEDzLPq 2esg== X-Gm-Message-State: AOJu0YyKAWelbwMGDekL83u/J+B/inF1GvrVLAqMCc9xCavft0L6Ug+C XTDRxzoMGbxN7Utt3hai8z1dxhuo3vg= X-Received: by 2002:a17:906:1bb2:b0:9b9:a1dd:5105 with SMTP id r18-20020a1709061bb200b009b9a1dd5105mr4735704ejg.50.1696587926979; Fri, 06 Oct 2023 03:25:26 -0700 (PDT) Received: from kepler.redhat.com (1F2EF530.nat.pool.telekom.hu. [31.46.245.48]) by smtp.gmail.com with ESMTPSA id n17-20020a170906379100b009b957d5237asm2613502ejc.80.2023.10.06.03.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 03:25:26 -0700 (PDT) Sender: Ingo Molnar From: Ingo Molnar To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Frederic Weisbecker , Joel Fernandes , Thomas Gleixner Subject: [PATCH 2/3] sched/nohz: Use consistent variable names in find_new_ilb() and kick_ilb() Date: Fri, 6 Oct 2023 12:25:17 +0200 Message-Id: <20231006102518.2452758-3-mingo@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231006102518.2452758-1-mingo@kernel.org> References: <20231006102518.2452758-1-mingo@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 06 Oct 2023 03:25:51 -0700 (PDT) X-Spam-Level: ** Use 'ilb_cpu' consistently in both functions. Signed-off-by: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/sched/fair.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8435179779e3..d4e90d15bd77 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11558,18 +11558,18 @@ static inline int on_null_domain(struct rq *rq) */ static inline int find_new_ilb(void) { - int ilb; const struct cpumask *hk_mask; + int ilb_cpu; hk_mask = housekeeping_cpumask(HK_TYPE_MISC); - for_each_cpu_and(ilb, nohz.idle_cpus_mask, hk_mask) { + for_each_cpu_and(ilb_cpu, nohz.idle_cpus_mask, hk_mask) { - if (ilb == smp_processor_id()) + if (ilb_cpu == smp_processor_id()) continue; - if (idle_cpu(ilb)) - return ilb; + if (idle_cpu(ilb_cpu)) + return ilb_cpu; } return nr_cpu_ids; -- 2.39.2