Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20230928151631.149333-1-jcmvbkbc@gmail.com> <20230928151631.149333-6-jcmvbkbc@gmail.com>
 <2023100326-crushing-septic-4856@gregkh> <CAMo8BfJgpP-=tNEChcyR3z6i_QeJ9Ywq7EOjjC5i7Uq4OrgXNA@mail.gmail.com>
 <2023100544-rendering-identify-e0ad@gregkh> <CAMo8Bf+wS+qiX2mMZm0i8dt7xkDO8RvroP8RF=78zxgFj-zwaA@mail.gmail.com>
 <2023100625-water-molehill-4a8f@gregkh>
In-Reply-To: <2023100625-water-molehill-4a8f@gregkh>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Fri, 6 Oct 2023 03:27:37 -0700
Message-ID: <CAMo8BfLfBEQVTyBXw=K2wsgGF+ZUfJhffX4ax8kX+k_DPSOKYg@mail.gmail.com>
Subject: Re: [PATCH v4 5/5] drivers/tty/serial: add ESP32S3 ACM device driver
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 6, 2023 at 2:34=E2=80=AFAM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> If you only want your code being used in Linux, then stick with
> "GPL-2.0".  If you want your code to be able to be copied into other
> GPLv3 licensed code bodies (like Hurd and others), then license it as
> "GPL-2.0-or-later".  Your call.

Thanks. From that point of view I prefer GPL-2.0-or-later.

> > > Yes, but not all do.  If you don't need to do anything special, it ca=
n
> > > just claim to be a normal device, we've had threads about this on the
> > > list before.  If you don't need to determine in userspace from the tt=
y
> > > connection what device it is, just use the default one instead.
> >
> > Ok, it looks like having
> >
> > #define PORT_ESP32ACM (-1)
> >
> > in the driver source should be ok? I've tested that it works.
>
> Hah, I like that hack.  But why not just use PORT_UNKNOWN?

A lot of functionality doesn't work with PORT_UNKNOWN, e.g.
console or modem control.
I've got the idea of using -1 from this email:
https://lore.kernel.org/linux-serial/502240f7-2cac-4fe6-9e27-f9861db3666d@a=
pp.fastmail.com/

--=20
Thanks.
-- Max