Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp284154rdb; Fri, 6 Oct 2023 03:33:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjzOD9U8shfatalZxieSMwLwkCCXDR8h4XqUex2wk/smpa/sstaJtZsDAzQW8/4P+bCkms X-Received: by 2002:a17:90a:8c5:b0:269:7eea:d7f6 with SMTP id 5-20020a17090a08c500b002697eead7f6mr6475681pjn.49.1696588389680; Fri, 06 Oct 2023 03:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696588389; cv=none; d=google.com; s=arc-20160816; b=uTgixRrD+8NCYT2abEOO94S8yKhe7dN24G+99nLo/KNa/YGJIHIEABnW+sUdD4l4vp ilkRb0gnd3jPwH0VLoXYVLQfF2zSU1TgtwZvYBGRCQKuctWKn21G8Zwp0mRXWvnbkI6n kycomcDv0aZpg6tudB+J7El+iYgd12ujgKvZo4f5By7fu2jrdghmtrbUPzrjDhDzjfYM 0djSP4PMDUaRtJqY0YS+PQiwoGfY+WcUeyfjLuwSccbEpG6D/FFXSwbDE6W/0X96Eszf WOLQRTGA8dnHv/m+IpK0DsjUa+0Xd/hP7RSvAkDVOu8Sya7U0GB5jItrfrCWYwAe2fNf iKVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=edyRve4jSBzkjx9+i2b28CZmnaf4HYzTUCHZlzZrDCE=; fh=+4UO449wtpxwNnbfNVpLMpmKZoAQMOcWKjRmcnHNo+s=; b=gLCdocpg6ydoffVBBZDe8P6+Y2adIWH5nQurqnf1C7Z6QAXOPz9B4qJof7Vku3Dbhh Fd4j/CVwJEacpVPJu+DnUDjN52MKs86X3L6dmFfvVWkXL3GJYESnr2Am9YBPGuXqc5qp ivBCvwoq03vw0CPmgf0ozZOi6ImiwPgCW8KPVeeunrlMPFKOlzNjV7nJXHGwiNTiL5sG IAnx1YzXK1toA579XcI1e1J2lMIHGpdKu+K5Uadh8sYZv5EmQfyvWZ2Kr9+UhzWqU/oH xxI2PZSTzoZW1cGwJ23TSyeO6f9hwdFpPEoF//G0GrYscUzs9Rsj1/sxfhcOuaW8BtYM GKvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XoyMdcCI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id nm5-20020a17090b19c500b0027652755c21si3455334pjb.142.2023.10.06.03.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 03:33:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XoyMdcCI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 3BCED83D8D42; Fri, 6 Oct 2023 03:33:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231784AbjJFKcx (ORCPT + 99 others); Fri, 6 Oct 2023 06:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231759AbjJFKcu (ORCPT ); Fri, 6 Oct 2023 06:32:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B58AD; Fri, 6 Oct 2023 03:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696588368; x=1728124368; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9fUH6EXJbYRX6bscbdM7bdFvMC19mlqyuBFWSrlZ5AY=; b=XoyMdcCIuy2axET8LAdhHdGubDlZRdru+yzog9lHfArVwGW9D5sAAAn7 zNJO6z3eMr4oMjWQMEhb80jwogKwjSEnzHXE53CH6HWvqtIAuKb3jz11s Bnh03gUU+3b/jTMhPK9bvtaR1MKmT04fJwKf/0XXgtGb6AcwjWVrwe/7p CR+3r1KmQwOucPGWAm/KmLnR385D6d7y5DSaK8oVA09WjtGYY0XL3KqbD yPR3SVWSm3Vi0y4QH5/FfnQ0o9xBKnZ0xb1GVgPQzKX8YJPooT33/fV3Y eR9svauC6EpPaYaFAecGR9GWC5Dku+CiRBeepE4qidXZCD2ltFy9eyxdH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="387603541" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="387603541" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 03:32:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="875899566" X-IronPort-AV: E=Sophos;i="6.03,203,1694761200"; d="scan'208";a="875899566" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 03:32:46 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qoi8R-00000003Gd9-3LLj; Fri, 06 Oct 2023 13:32:43 +0300 Date: Fri, 6 Oct 2023 13:32:43 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Raag Jadav Subject: Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers Message-ID: References: <20231006094033.3082468-1-andriy.shevchenko@linux.intel.com> <20231006094033.3082468-2-andriy.shevchenko@linux.intel.com> <20231006102641.GZ3208943@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006102641.GZ3208943@black.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 06 Oct 2023 03:33:07 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 01:26:41PM +0300, Mika Westerberg wrote: > On Fri, Oct 06, 2023 at 12:40:33PM +0300, Andy Shevchenko wrote: ... > > if (cfg == CHV_PADCTRL0_GPIOCFG_GPO) > > return !!(ctrl0 & CHV_PADCTRL0_GPIOTXSTATE); > > + > > Unrelated whitespace change. Will drop it. > Otherwise looks good, > Acked-by: Mika Westerberg Thank you! -- With Best Regards, Andy Shevchenko