Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <79fd231f-c43a-bcbb-9660-c58e5bfbd953@axentia.se>
Date:   Fri, 6 Oct 2023 12:32:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v4 2/2] i2c: muxes: pca954x: Enable features on MAX7357
Content-Language: sv-SE
From:   Peter Rosin <peda@axentia.se>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231005134541.947727-1-naresh.solanki@9elements.com>
 <20231005134541.947727-2-naresh.solanki@9elements.com>
 <29485a37-1f45-9f7f-9cc5-5d6a9fcc5e08@axentia.se>
In-Reply-To: <29485a37-1f45-9f7f-9cc5-5d6a9fcc5e08@axentia.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTdXa3dDUUt4M09DalZqZ3BEZ2N1VlF5d20veUdlNXlMaU9GQlJLcmhqQ2lh?=
 =?utf-8?B?UXVSamFqeWgremtkVlVQazhYekMyN3lhOGZ5QnQ0L21JWjA2MXMrcVNxNUtT?=
 =?utf-8?B?VGZhMDJ1VlNDN3hCVXk2M0lRVE41SXFVMTZBcTJwMWlXaFpPOHFhZ1JXQk5i?=
 =?utf-8?B?aUNPdFR1dmhnMWU4NnhTTzhKRm9TbkJocFVpRlc4ak1WZnJ4QjNQRlFTQUEv?=
 =?utf-8?B?MW11ekZJdGEzaXphMlBaMXlHc2FiL2t1S21yd0pOSUREa0U3bWNzMWhMK3Bs?=
 =?utf-8?B?YXkyVjdQMDd6NnI5UmV4dU9lazdKcnovSW9jK1ZpaUJpL0xQTis0Z2liNkZt?=
 =?utf-8?B?b01wbzhIQWJXRW4yYW51d3k4RkF2WEJOZHhsYis1U3RabklFWFYwSzFHNFlu?=
 =?utf-8?B?dXFVS3FxaldtUWFoZURxUEpXdU5GV3hpd250bVBTcXZYWmgrOGpOLzNXNy9D?=
 =?utf-8?B?VDdxWUpCSjBzMGxTZloyaFIzRks0QVh4ZTlXcXAwV2dGU1pVN2FBLzJlSmpo?=
 =?utf-8?B?Q3B2ZFZHZTlTSDI0cUoyUXBmVnZYcElLc3Npd0Q0K2Nxc25xSUt4ZDBUdjRK?=
 =?utf-8?B?QWh2QnUwejVhdUZZUzk2YTBGNkJNMHJJL3JrVyt4bHJKQjhGU2FLcGVRZnFM?=
 =?utf-8?B?WFcvRGVDWFQ2SUJKOUx0cXZMckhudmpYNjZxeXEyUmtLZVZOaTFBTlJkeHdM?=
 =?utf-8?B?U3U1MUs2N0V2MnlMR3BlSG02UzZPdVFvTEl4OFFmQ01meW1mcGNnSWNFc2RD?=
 =?utf-8?B?WG5XNzZ2S3M0aklxc0VrNkpzTExMd3BGQnEyTGl5UzlDSEZGVHY0eDNKbVov?=
 =?utf-8?B?b2huR2RHMmRSNFBQbVNaZFJOc2JSd0JjVStzK2o0ckQwam5ITC9xNVFEa2xK?=
 =?utf-8?B?bXVTWnZtWUo0N1FFOGtYTVlnSEx6SU13V3JkdXJDK2FNS0psN21VZGNobE5z?=
 =?utf-8?B?dXpSWDhUWFhvcDRaQkdRczZpaVBGK2hINDhzdVpIT3hrRithL2ZDcnd0cVFB?=
 =?utf-8?B?WVc3VUxlcHBBY0ZRYjdRLzlTejIyT2xoeUs2WGloSlBoSDRiOFUyaHlDVitP?=
 =?utf-8?B?MFd4cGdKWE9EWTNTQ3lmaXNGMmIvZWdzY3JjMVFYODJ1MkM1ZmFLLzZhN1lu?=
 =?utf-8?B?K1RBOWMxdzhTQlBMckJ5ZkFSQTRTQ2ZBcmV0MU5kUmVoTGtaQWszbkoyOWk0?=
 =?utf-8?B?a29GcTVrS05uSzVTcHczaFZxZ1dzNFpMaEdFbG1HSDl3SHlOTjUrQlVlczdH?=
 =?utf-8?B?S2xwMjIreGlrTSs1QkdwUUZpN0NUSzRqOW51WnlNNkVjeDUzWGs4V2xDbVp3?=
 =?utf-8?B?N0pNQXhXUHpna0tBSGM0aVVWUUpncmdzdEM2NmtkM3NCUlVDdks2dGVVZGVk?=
 =?utf-8?B?VEFUNVNpbkRPRS80bm1vOGRkMldzWndZSnd5Rm1PdWtVRGRUZXNxQ1JuUUZP?=
 =?utf-8?B?aktVb1pyRVNqeVpkTDg1a1NCR1U0V2ZnNnMxRm85QnBEYW1MRUpxblNYS0lK?=
 =?utf-8?B?TG9na2dwZm1sU3ZNYWhqMkltYkNmNDlEbFZWODJRRmZBOWVwQVk3aUNsYmJW?=
 =?utf-8?B?eTh4cE9XdEhBT3BEY0s1WFM0RjZDTW9IcU5LL0dtbUhnR2YyTzRaajRQQkRh?=
 =?utf-8?B?dkxRaXlDZ1pHVHVpRWFFM1hFUjF2L0NSelhPNElpUlQvWXJiV29laGNxTWov?=
 =?utf-8?B?bkdWYzNtbG9JQUV6dEQvWmFpQ2NGd3E4bmxuc0x2U0h5SVZ4c0RseHRDWUJs?=
 =?utf-8?B?N1RWS0YveWIxMHdsL21xTmpRb2p0aDRuOTA4TEk0VmZDelVPNDlIdTlFSi9D?=
 =?utf-8?B?NXZ2bVBTdlZWdlNTT2cxcHM1SlZBUEtyeFNyU1liR3UrcWx0WUUvdFB2TWZG?=
 =?utf-8?B?aHBTNEZZcXFBbXh5RFJOVnlKR0ltQU9MS0FxR2RucUlaRGhmelViRHdDVFgx?=
 =?utf-8?B?UFhheTF0STN5NmlGc3RWTDZJWVkyL1BEaEFYR2poS3RDUzVZcXp0aGNYSUxC?=
 =?utf-8?B?bTJvdmRrZElzS2cyblR5emN2SkY5Rk1PVjFmT25NTVp3MUc1eWlleUxla3o1?=
 =?utf-8?B?OUpDRWVuV2xvQmVWQ01ER3I5a0VyRzZMMEVOcnNKd0VvZTltYVpway9LQm90?=
 =?utf-8?Q?O3/WiMwSnonxvpyyJkUCamRgp?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: e5424b23-9b13-4710-cec6-08dbc6578997
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 10:32:27.7241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A9kW/c2fh8e+fTKv6lEBNlkCjLue6jlUWB2wx0frGTw0l6VdSBUjRnuvvd+CcA6I
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR02MB6756
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 06 Oct 2023 03:33:09 -0700 (PDT)

Hi again!

[sorry for replying to self]

2023-10-06 at 09:46, Peter Rosin wrote:
> 2023-10-05 at 15:45, Naresh Solanki wrote:
>> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>>

...

>> +			dev_warn(&client->dev,
>> +				 "Write byte not supported. Cannot enable enhanced mode features");
> 
> Missing \n at the end of the string.
> 

Also, I2C_FUNC_SMBUS_WRITE_BYTE is separate from
I2C_FUNC_SMBUS_WRITE_BYTE_DATA, which makes that "Write byte"
misleading.

Cheers,
Peter