Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <9fec75ba-a319-027c-6cf2-b65e703d3ce7@oracle.com>
Date:   Fri, 6 Oct 2023 16:07:14 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH 5.15 000/183] 5.15.134-rc1 review
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc:     stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
        patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
        jonathanh@nvidia.com, sudipm.mukherjee@gmail.com,
        srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>
References: <20231004175203.943277832@linuxfoundation.org>
 <ec06c2fb-6737-489f-8439-307e0d84687b@gmail.com>
 <2023100601-ending-prevalent-c8d4@gregkh>
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <2023100601-ending-prevalent-c8d4@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzcxVU5ZSHAyaFlqUVF2WUowaVhWdERKVFJ5cFcvNVpZekI5a1hsV01xQmxB?=
 =?utf-8?B?L3ZEZFhPbEdpazRUeGk4Skl2dWdHeE1uVWRTNTNpaU9ISXU5VzRsYkFxcDlG?=
 =?utf-8?B?TERZTG9NWkU5RDV6WWNtVjYwWWppQm9XbSthZTA1Y3RaWDV4RG80dkt6aHFS?=
 =?utf-8?B?OG1YOEZUek94NTBjRUFsVkYxUCtkRnFoVDRtajFxSldtVll4UlFxMGp3bFZl?=
 =?utf-8?B?MkVxYWxFYXYzUWsvNmlEdnRWVDlxK0NYUTVFalpNZUxFKzZmeW56RFFqTVpp?=
 =?utf-8?B?a2FZZGF0aUxla2czaER4YW9wUUdUSGx3alJlaGdwSDhHZlEvTTJMdncvNjhN?=
 =?utf-8?B?MmFUTVI2SkhyM1hUZDBoVDJiR2xCdEJJeE5OQUNUR2FQeENoMHB2bFNrNE55?=
 =?utf-8?B?b0FFVUtwUEcxdmk2THNlRzdEemM2YSs2MmY1bVhCekZJWWZRaHpvY05zYnNv?=
 =?utf-8?B?YnRldWI5WFhJL0t1K3NaL2daaTZmNS96VWJOdzFtRHhFNEZENGVVWmNhRGZz?=
 =?utf-8?B?WHU1RVNnVXZla3hJdkExOWRUSGcrMEFQdXRIaHBpRUVtai9PbG0xMDNsNith?=
 =?utf-8?B?enVmRHhaOXRJcHIzSTAxYUtPSmFsU2p1OEcwcng5eTVES0tYK0Vid01NWDJx?=
 =?utf-8?B?TkRVMHNJWmJYbzJEK1NSR2YwWDhBVlhwN1ZtQldLNUgwOHQycGp5b1RVWjdL?=
 =?utf-8?B?UnU5a3J4YmsyY0k3cU1hMWc0SVVlSEdhcEVzMzFZR1ljL0x4NExPNXhMbDVu?=
 =?utf-8?B?T0VhTFdmUGs2bGJoSUZuWllRellFcDA5anpMUXRuS2VLei9SUnFvc2RYblFz?=
 =?utf-8?B?SUtGYi9Dd2Y4cG9lcDdDL0dnU2VyZEJOdERZbTlKcTM3alF1bllNUXI5SVFT?=
 =?utf-8?B?YWZoRFJwdUVkUnNkK0dXZ0lRbjY3SlNxclBmK3c3L3dGeVdlV0FZaGxrU1No?=
 =?utf-8?B?L25QWEpkTzczZVFrcTN1bG5QRzRhbHZHeTkyZERyNE8yNmNQZ1JDRGlTSGN3?=
 =?utf-8?B?UTlUNGJVVnhDd2FuaDRWay9ETDYrZ3NvYzJleTB0U0d2OURoRzBMRzFBbGYx?=
 =?utf-8?B?blNKSzR0eXRibUVUWUE2enFvTUhzekswS0M5UjFUNncxMngrUlorVnhCMy9Q?=
 =?utf-8?B?ZkNmeGtQUWJlUzhHQ2trcEVrTEMwMVBKYno1TTk5UUJreFoxbUd6Uk9ETXVp?=
 =?utf-8?B?dVYrOHlJS2h0Y210QTE5M2hHeldCSEVOUG9NbGVCRXZ0TEVJOFpvd0o0ZmZB?=
 =?utf-8?B?amVKNFZONFJod0Ewd3pqclhVa1J6Y2duS0hXQk1KRlpkZDltamd4VlR6MjVD?=
 =?utf-8?B?Yjhra3VtTU5pMjVtbE9KUUUwU2hibkI3UnpZNmVzRE9xajFwQU9MRld1cmlD?=
 =?utf-8?B?a3FlajRxc3BMdy8wTXRmdVA1SXM3dSs5bTNOVGlQaHR6TDNpVllZMVpEaU82?=
 =?utf-8?B?WmR2LzFsVlcwaVlxMVAxUlJVc2hBL25rQXEzMU5tT055OFJLaTZHZVdVeXBU?=
 =?utf-8?B?dnJnaU1sajE0Umlhckd4SnM2VFVuN3MveXlCR2tsTERTa3E3YisrVDFHRk53?=
 =?utf-8?B?NmJFUk1vai8zMmg5MFRYN0kwK2l5enoyTEpKb3k1OEFpbWRmT3NwOTVjekE0?=
 =?utf-8?B?WU5VbWd0YmRibVcvN3pmWnlVc0YwUWdHcEdrUWRCWGhBOWJLSXEvdFZWdksz?=
 =?utf-8?B?V09ySlNSV3BPT0RqVUEyRWl5SW5DdkJ1MWZrQjJRS2JQVFdMVStQVEZBRi91?=
 =?utf-8?B?SmQvazFYTmVNZEwveGh1WkFNUWxMa2FMK1EzYkVhZjhoaCtlaGg2Ym5EdnRz?=
 =?utf-8?B?NFFlMy96bUVURytITlpkVFh6YzQrWEJuRjlNeEk5VzU2andqSDZ3WUw3alZ0?=
 =?utf-8?B?UWZ0bE1kR1RFMHhUeHp1TnV3QXVJQXBEa3dkR3Zvbmgxc2UxQW1tNFZEQldq?=
 =?utf-8?B?K3dLS0hES28vL0p6WG05SW5VWUtNUGFjWG51Nno5b0U2enN4c01UWktDYm9I?=
 =?utf-8?B?aHNpVHkrQ2kyMjM4a0hQRVE4Q1Z0dnVzdTBVVU9iR3VSTmhlZ25Fb2dEYzhy?=
 =?utf-8?B?dEt0NzV5a0E1R09mUWo5TFdLR0lWZENMVTZFeEFzSXRvVTgyN3NYbWpxdEZM?=
 =?utf-8?B?NVRzc2RsOTFkZVp3QVQyRCtYdjRDK0dIUEZ3WWdRMHVsTFRBWEJhdVBIVlVm?=
 =?utf-8?Q?u0v1+gIBtfXXTavHnAu3R2w=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bHhlLzFTbXFmZVNQTEk0V2haMnVteE5GN3JrbTJsQzBZOUZSR0lxZ2VlY3BU?=
 =?utf-8?B?UmEwZzM2TVBISmExekJYV1JBRWlGMUlLYXFaSHIrdy9ZRklSR1F5VTNWc0Qr?=
 =?utf-8?B?UWpUM0ZESEJmTEY3WHZDVDdUWkViQVN5Wk4yOFFUOGE3ZE1uZ0dWL1RySnBj?=
 =?utf-8?B?VE9HYWhGT0tnbmpzVjBueWRicmxObTgzOUZSSkF3djB3a0V1c1d1a0d2THNv?=
 =?utf-8?B?Y2xSR0JncDRhS3V2ZG10K2JHelZ4TG0rcktVYjY5aTlBZHl5ZnRMbk5iZS9y?=
 =?utf-8?B?bkliY1VNekJuR3E0UWJacVFOZTNoMFk5NXVLNzRBWDVzWUt4TmFXM3BWcGJQ?=
 =?utf-8?B?TENOYzNrQThHcGdXbUZWNzl0SzFkVzFrMTd6MVh4M3BiUFBSeHVzam80R1JE?=
 =?utf-8?B?bng3Vkd0V3BlMUhQOUdHQlVkNW50VW1LankzekdGTDR4N3lEY25RZVdwZDhE?=
 =?utf-8?B?VmJNRXNNQ0tjZC9ENjQzZEFuWGhTbFduTlpsK01nOXJJeXV1RmxtSXZiejhv?=
 =?utf-8?B?NTh3eXdmZ1ducENKM1p3aG94WVU1bWpSN2hNbDVDenUvQmtQUFZCK2VvVjBU?=
 =?utf-8?B?eTg1OTArZ09BVEJNZU5sNW1ucnc2VGhnZXF5eVBPNTJoRSt5dmpxSEk2QjBM?=
 =?utf-8?B?ejRYUTZtdFZsQk1UcTZod25Tb3dxNnBqRnQ0Ti9vQUNNbXVtU1pOTGhZQkJz?=
 =?utf-8?B?WW9iNGNJN21YYW1NcXhqaFFwYm80RFZWOHRXM0t3RWhkZW8rMmJDSTNnWHdj?=
 =?utf-8?B?d0NGSm4wa21hQVN1QndwMEpZZGoweHJqdlVzT3ltV2NJdzM1TXp0UlFLcXlm?=
 =?utf-8?B?SGVLVEcrb0VxV1lqTHIyVHMwZXJoaUxaeS9PN2lCT3V4cDZRZHVyRkE5dmpt?=
 =?utf-8?B?ZnBXeTEvQVpQRC8xZHg5STZOVTFaOU9SZWNpNWYwdk9xVm93cWFNdlczd2Jo?=
 =?utf-8?B?NUpnRzR4UnN2Q1RjZjMyL2ZmRGRXbzJocm1tWHZRTVIyTlBGZ1hoSTE3Zkx5?=
 =?utf-8?B?YlNUK0dlVmo3RGhaQjJ3dGpvRUJVN3Bzd1RzM0NJZ2dzWXlZbnlaQ2QxQ2lQ?=
 =?utf-8?B?OWJ0ejZyenVubWNqL0M3YUYwN2J0YjRSNTFzaFU1SVM3eFRjUG9vOUVNYlRZ?=
 =?utf-8?B?eFI5T3JleERQV0lsNk5MVVNCZFplNlFxN2xsZTZUL216bm81OTI2RnZBdC9i?=
 =?utf-8?B?UlNJdnpSdkI1VkRvNUxLbHBWMkoxUXBnL29PNWhQZFVPZ1dBRXRRV0s0RHJB?=
 =?utf-8?B?VDhlM05QUzZ1ekpMU1Q4Vk9TVEhuWDFHTVo1WjNTeDEreTMyT1FMbFFhZVBQ?=
 =?utf-8?B?a3ZHVWJuQk0xQWkyZW9mb2xTWHVNUDEwamRRT1VVeStJSmVPRGpCd3ZGSFZm?=
 =?utf-8?B?bUR0bzNhL1VxYWlyVEhpNzh2MFR4OUtQMCtYWGQ4OWpyUG4wZUJCK1BodzAx?=
 =?utf-8?B?MlpTZGVYUEpVN1FSRUk0TzBDbnZEM0pTaXRONU1SdG9TVVZ0ZFdTaXN3eE9O?=
 =?utf-8?B?SmI2anhTT2M3OUVlRk5FWmVONDRTUGtaamdZQnZNdERSOFkrSkgrelUvZjEz?=
 =?utf-8?Q?hFgs1FLZMwhHU+87QsbNAOh08QoM5tqkE/pTkmkViJxy00?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a56cec36-c540-44d0-5387-08dbc6583b3d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 10:37:25.8915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2vtX74OuZWVfcRHMiy6r9Ze6ezA3dnLiv5ep9gZk1WoVJlkCcK2ah/HumZCVUabPbY2ONYmlAiYUp6T6AEhgCeqhMRB1L0nTU6IgquDJm9RSsmp/2jVO93cQJ+nkWZ4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4492
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-06_07,2023-10-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310060077
X-Proofpoint-ORIG-GUID: V19JDTLovtwqq9KQc2PEFjAC4-tAGOEE
X-Proofpoint-GUID: V19JDTLovtwqq9KQc2PEFjAC4-tAGOEE
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 03:38:25 -0700 (PDT)


On 06/10/23 3:55 pm, Greg Kroah-Hartman wrote:
> On Wed, Oct 04, 2023 at 11:43:46AM -0700, Florian Fainelli wrote:
>> On 10/4/23 10:53, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.134 release.
>>> There are 183 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Fri, 06 Oct 2023 17:51:12 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.134-rc1.gz
>>> or in the git tree and branch at:
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> perf fails to build with:
>>
>>    CC /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/util/metricgroup.o
>> util/metricgroup.c: In function 'metricgroup__parse_groups':
>> util/metricgroup.c:1261:7: error: 'table' undeclared (first use in this
>> function)
>>    if (!table)
>>         ^~~~~
>> util/metricgroup.c:1261:7: note: each undeclared identifier is reported only
>> once for each function it appears in
>> make[6]: *** [/local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/build/Makefile.build:97: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/util/metricgroup.o]
>> Error 1
>>
>> caused by c1ef510a0f2a879bf29ddebae766ec9f0790eb8f ("perf metric: Return
>> early if no CPU PMU table exists"). Dropping this commit allows the build to
>> continue.
>>
>> I had reported in the previous cycle that 00facc760903be66 ("perf jevents:
>> Switch build to use jevents.py") was causing build failures:
>>
>> https://lore.kernel.org/all/6a577578-8adb-aa70-1bf8-b1a4573152cf@gmail.com/
>>
>> do we still want these commits to be included?
> 
> No, I'll go drop them now, thanks for the report.

Thought:
It's not the first time we see build failures in tools/perf -- would it 
make sense to add this to your own build tests to reduce the round trip 
time for these errors ?

Note: After reverting three patches in perf/ the build succeeds:

Patch 151: c1ef510a0f2a perf metric: Return early if no CPU PMU table exists
Patch 81: 40ddac4ffc75 perf build: Update build rule for generated files
Patch 80: 8df938ed8c8a perf jevents: Switch build to use jevents.py


Thanks,
Harshit

> 
> greg k-h