Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: [PATCH v7] hv/hv_kvp_daemon:Support for keyfile based connection
 profile
From:   Ani Sinha <anisinha@redhat.com>
In-Reply-To: <1695622987-17527-1-git-send-email-shradhagupta@linux.microsoft.com>
Date:   Fri, 6 Oct 2023 16:36:51 +0530
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Olaf Hering <olaf@aepfle.de>,
        Shradha Gupta <shradhagupta@microsoft.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0103C8C4-062C-45EA-8FA0-AB6C7CF4EADC@redhat.com>
References: <1695622987-17527-1-git-send-email-shradhagupta@linux.microsoft.com>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Precedence: bulk


> On 25-Sep-2023, at 11:53 AM, Shradha Gupta =
<shradhagupta@linux.microsoft.com> wrote:
>=20
> Ifcfg config file support in NetworkManger is deprecated. This patch
> provides support for the new keyfile config format for connection
> profiles in NetworkManager. The patch modifies the hv_kvp_daemon code
> to generate the new network configuration in keyfile
> format(.ini-style format) along with a ifcfg format configuration.
> The ifcfg format configuration is also retained to support easy
> backward compatibility for distro vendors. These configurations are
> stored in temp files which are further translated using the
> hv_set_ifconfig.sh script. This script is implemented by individual
> distros based on the network management commands supported.
> For example, RHEL's implementation could be found here:
> =
https://gitlab.com/redhat/centos-stream/src/hyperv-daemons/-/blob/c9s/hv_s=
et_ifconfig.sh
> Debian's implementation could be found here:
> =
https://github.com/endlessm/linux/blob/master/debian/cloud-tools/hv_set_if=
config
>=20
> The next part of this support is to let the Distro vendors consume
> these modified implementations to the new configuration format.
>=20
> Tested-on: Rhel9(Hyper-V, Azure)(nm and ifcfg files verified)
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> ---
> Changes v6->v7
> * fix freeing mac_addr variable in error cases
> ---
> tools/hv/hv_kvp_daemon.c    | 225 +++++++++++++++++++++++++++++++-----
> tools/hv/hv_set_ifconfig.sh |  39 ++++++-
> 2 files changed, 229 insertions(+), 35 deletions(-)
>=20
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 27f5e7dfc2f7..c41b3c26111d 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1171,13 +1171,80 @@ static int process_ip_string(FILE *f, char =
*ip_string, int type)
> 	return 0;
> }
>=20
> +/*
> + * Only IPv4 subnet strings needs to be converted to plen
> + * For IPv6 the subnet is already privided in plen format
> + */
> +static int kvp_subnet_to_plen(char *subnet_addr_str)
> +{
> +	int plen =3D 0;
> +	struct in_addr subnet_addr4;
> +
> +	/*
> +	 * Convert subnet address to binary representation
> +	 */
> +	if (inet_pton(AF_INET, subnet_addr_str, &subnet_addr4) =3D=3D 1) =
{
> +		uint32_t subnet_mask =3D ntohl(subnet_addr4.s_addr);
> +
> +		while (subnet_mask & 0x80000000) {
> +			plen++;
> +			subnet_mask <<=3D 1;
> +		}
> +	} else {
> +		return -1;
> +	}
> +
> +	return plen;
> +}
> +
> +static int process_ip_string_nm(FILE *f, char *ip_string, char =
*subnet,
> +				int is_ipv6)
> +{
> +	char addr[INET6_ADDRSTRLEN];
> +	char subnet_addr[INET6_ADDRSTRLEN];
> +	int error, i =3D 0;
> +	int ip_offset =3D 0, subnet_offset =3D 0;
> +	int plen;
> +
> +	memset(addr, 0, sizeof(addr));
> +	memset(subnet_addr, 0, sizeof(subnet_addr));
> +
> +	while (parse_ip_val_buffer(ip_string, &ip_offset, addr,
> +				   (MAX_IP_ADDR_SIZE * 2)) &&
> +				   parse_ip_val_buffer(subnet,
> +						       &subnet_offset,
> +						       subnet_addr,
> +						       (MAX_IP_ADDR_SIZE =
*
> +							2))) {
> +		if (!is_ipv6)
> +			plen =3D kvp_subnet_to_plen((char =
*)subnet_addr);
> +		else
> +			plen =3D atoi(subnet_addr);
> +
> +		if (plen < 0)
> +			return plen;
> +
> +		error =3D fprintf(f, "address%d=3D%s/%d\n", ++i, (char =
*)addr,
> +				plen);
> +		if (error < 0)
> +			return error;
> +
> +		memset(addr, 0, sizeof(addr));
> +		memset(subnet_addr, 0, sizeof(subnet_addr));
> +	}
> +
> +	return 0;
> +}
> +
> static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value =
*new_val)
> {
> 	int error =3D 0;
> 	char if_file[PATH_MAX];
> -	FILE *file;
> +	char nm_file[PATH_MAX];

While we are at it, we should rename these to nm_filename and =
if_filename.

> +	FILE *ifcfg_file, *nmfile;
> 	char cmd[PATH_MAX];
> 	char *mac_addr;
> +	int is_ipv6;

Set this to 0?

> 	int str_len;
>=20
> 	/*
> @@ -1197,7 +1264,7 @@ static int kvp_set_ip_info(char *if_name, struct =
hv_kvp_ipaddr_value *new_val)
> 	 * in a given distro to configure the interface and so are free
> 	 * ignore information that may not be relevant.
> 	 *
> -	 * Here is the format of the ip configuration file:
> +	 * Here is the ifcfg format of the ip configuration file:
> 	 *
> 	 * HWADDR=3Dmacaddr
> 	 * DEVICE=3Dinterface name
> @@ -1220,6 +1287,32 @@ static int kvp_set_ip_info(char *if_name, =
struct hv_kvp_ipaddr_value *new_val)
> 	 * tagged as IPV6_DEFAULTGW and IPV6 NETMASK will be tagged as
> 	 * IPV6NETMASK.
> 	 *
> +	 * Here is the keyfile format of the ip configuration file:
> +	 *
> +	 * [ethernet]
> +	 * mac-address=3Dmacaddr
> +	 * [connection]
> +	 * interface-name=3Dinterface name
> +	 *
> +	 * [ipv4]
> +	 * method=3D<protocol> (where <protocol> is "auto" if DHCP is =
configured
> +	 *                       or "manual" if no boot-time protocol =
should be used)
> +	 *
> +	 * address1=3Dipaddr1/plen
> +	 * address2=3Dipaddr2/plen
> +	 *
> +	 * gateway=3Dgateway1;gateway2
> +	 *
> +	 * dns=3Ddns1;dns2
> +	 *
> +	 * [ipv6]
> +	 * address1=3Dipaddr1/plen
> +	 * address2=3Dipaddr2/plen
> +	 *
> +	 * gateway=3Dgateway1;gateway2
> +	 *
> +	 * dns=3Ddns1;dns2
> +	 *
> 	 * The host can specify multiple ipv4 and ipv6 addresses to be
> 	 * configured for the interface. Furthermore, the configuration
> 	 * needs to be persistent. A subsequent GET call on the =
interface
> @@ -1227,14 +1320,29 @@ static int kvp_set_ip_info(char *if_name, =
struct hv_kvp_ipaddr_value *new_val)
> 	 * call.
> 	 */
>=20
> +	/*
> +	 * We are populating both ifcfg and nmconnection files
> +	 */
> 	snprintf(if_file, sizeof(if_file), "%s%s%s", KVP_CONFIG_LOC,
> -		"/ifcfg-", if_name);
> +		 "/ifcfg-", if_name);

Whitespace?

>=20
> -	file =3D fopen(if_file, "w");
> +	ifcfg_file =3D fopen(if_file, "w");
>=20
> -	if (file =3D=3D NULL) {
> +	if (!ifcfg_file) {
> 		syslog(LOG_ERR, "Failed to open config file; error: %d =
%s",
> -				errno, strerror(errno));
> +		       errno, strerror(errno));
> +		return HV_E_FAIL;
> +	}
> +
> +	snprintf(nm_file, sizeof(nm_file), "%s%s%s%s", KVP_CONFIG_LOC,
> +		 "/", if_name, ".nmconnection");
> +
> +	nmfile =3D fopen(nm_file, "w");
> +
> +	if (!nmfile) {
> +		syslog(LOG_ERR, "Failed to open config file; error: %d =
%s",
> +		       errno, strerror(errno));
> +		fclose(ifcfg_file);
> 		return HV_E_FAIL;
> 	}
>=20
> @@ -1248,14 +1356,31 @@ static int kvp_set_ip_info(char *if_name, =
struct hv_kvp_ipaddr_value *new_val)
> 		goto setval_error;
> 	}
>=20
> -	error =3D kvp_write_file(file, "HWADDR", "", mac_addr);
> -	free(mac_addr);
> +	error =3D kvp_write_file(ifcfg_file, "HWADDR", "", mac_addr);
> +	if (error < 0)
> +		goto setmac_error;
> +
> +	error =3D kvp_write_file(ifcfg_file, "DEVICE", "", if_name);
> +	if (error < 0)
> +		goto setmac_error;
> +
> +	error =3D fprintf(nmfile, "\n[connection]\n");
> +	if (error < 0)
> +		goto setmac_error;
> +
> +	error =3D kvp_write_file(nmfile, "interface-name", "", if_name);
> 	if (error)
> -		goto setval_error;
> +		goto setmac_error;
> +
> +	error =3D fprintf(nmfile, "\n[ethernet]\n");
> +	if (error < 0)
> +		goto setmac_error;
>=20
> -	error =3D kvp_write_file(file, "DEVICE", "", if_name);
> +	error =3D kvp_write_file(nmfile, "mac-address", "", mac_addr);
> 	if (error)
> -		goto setval_error;
> +		goto setmac_error;
> +
> +	free(mac_addr);
>=20
> 	/*
> 	 * The dhcp_enabled flag is only for IPv4. In the case the host =
only
> @@ -1263,47 +1388,87 @@ static int kvp_set_ip_info(char *if_name, =
struct hv_kvp_ipaddr_value *new_val)
> 	 * proceed to parse and pass the IPv6 information to the
> 	 * disto-specific script hv_set_ifconfig.
> 	 */
> +
> +	/*
> +	 * First populate the ifcfg file format
> +	 */
> 	if (new_val->dhcp_enabled) {
> -		error =3D kvp_write_file(file, "BOOTPROTO", "", "dhcp");
> +		error =3D kvp_write_file(ifcfg_file, "BOOTPROTO", "", =
"dhcp");
> 		if (error)
> 			goto setval_error;
> -
> 	} else {
> -		error =3D kvp_write_file(file, "BOOTPROTO", "", "none");
> +		error =3D kvp_write_file(ifcfg_file, "BOOTPROTO", "", =
"none");
> 		if (error)
> 			goto setval_error;
> 	}
>=20
> -	/*
> -	 * Write the configuration for ipaddress, netmask, gateway and
> -	 * name servers.
> -	 */
> -
> -	error =3D process_ip_string(file, (char *)new_val->ip_addr, =
IPADDR);
> +	error =3D process_ip_string(ifcfg_file, (char =
*)new_val->ip_addr,
> +				  IPADDR);
> 	if (error)
> 		goto setval_error;
>=20
> -	error =3D process_ip_string(file, (char *)new_val->sub_net, =
NETMASK);
> +	error =3D process_ip_string(ifcfg_file, (char =
*)new_val->sub_net,
> +				  NETMASK);
> 	if (error)
> 		goto setval_error;
>=20
> -	error =3D process_ip_string(file, (char *)new_val->gate_way, =
GATEWAY);
> +	error =3D process_ip_string(ifcfg_file, (char =
*)new_val->gate_way,
> +				  GATEWAY);
> 	if (error)
> 		goto setval_error;
>=20
> -	error =3D process_ip_string(file, (char *)new_val->dns_addr, =
DNS);
> +	error =3D process_ip_string(ifcfg_file, (char =
*)new_val->dns_addr, DNS);
> 	if (error)
> 		goto setval_error;
>=20
> -	fclose(file);
> +	if (new_val->addr_family =3D=3D ADDR_FAMILY_IPV6) {
> +		error =3D fprintf(nmfile, "\n[ipv6]\n");
> +		is_ipv6 =3D 1;

Nit: can you set this after the error check below?

> +		if (error < 0)
> +			goto setval_error;
> +	} else {
> +		error =3D fprintf(nmfile, "\n[ipv4]\n");
> +		if (error < 0)
> +			goto setval_error;
> +	}

Here a comment is warranted

/* Now populate nm keyfile */

> +
> +	if (new_val->dhcp_enabled) {
> +		error =3D kvp_write_file(nmfile, "method", "", "auto");
> +		if (error < 0)
> +			goto setval_error;
> +	} else {
> +		error =3D kvp_write_file(nmfile, "method", "", =
"manual");
> +		if (error < 0)
> +			goto setval_error;
> +	}
> +
> +	/*
> +	 * Write the configuration for ipaddress, netmask, gateway and
> +	 * name services
> +	 */
> +	error =3D process_ip_string_nm(nmfile, (char *)new_val->ip_addr,
> +				     (char *)new_val->sub_net, is_ipv6);
> +	if (error < 0)
> +		goto setval_error;
> +
> +	error =3D fprintf(nmfile, "gateway=3D%s\n", (char =
*)new_val->gate_way);
> +	if (error < 0)
> +		goto setval_error;
> +
> +	error =3D fprintf(nmfile, "dns=3D%s\n", (char =
*)new_val->dns_addr);
> +	if (error < 0)
> +		goto setval_error;
> +
> +	fclose(nmfile);
> +	fclose(ifcfg_file);
>=20
> 	/*
> 	 * Now that we have populated the configuration file,
> 	 * invoke the external script to do its magic.
> 	 */
>=20
> -	str_len =3D snprintf(cmd, sizeof(cmd), KVP_SCRIPTS_PATH "%s %s",
> -			   "hv_set_ifconfig", if_file);
> +	str_len =3D snprintf(cmd, sizeof(cmd), KVP_SCRIPTS_PATH "%s %s =
%s",
> +			   "hv_set_ifconfig", if_file, nm_file);
> 	/*
> 	 * This is a little overcautious, but it's necessary to suppress =
some
> 	 * false warnings from gcc 8.0.1.
> @@ -1316,14 +1481,16 @@ static int kvp_set_ip_info(char *if_name, =
struct hv_kvp_ipaddr_value *new_val)
>=20
> 	if (system(cmd)) {
> 		syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d =
%s",
> -				cmd, errno, strerror(errno));
> +		       cmd, errno, strerror(errno));

Whitespace?

> 		return HV_E_FAIL;
> 	}
> 	return 0;
> -
> +setmac_error:
> +	free(mac_addr);
> setval_error:
> 	syslog(LOG_ERR, "Failed to write config file");
> -	fclose(file);
> +	fclose(ifcfg_file);
> +	fclose(nmfile);
> 	return error;
> }
>=20
> diff --git a/tools/hv/hv_set_ifconfig.sh b/tools/hv/hv_set_ifconfig.sh
> index d10fe35b7f25..ae5a7a8249a2 100755
> --- a/tools/hv/hv_set_ifconfig.sh
> +++ b/tools/hv/hv_set_ifconfig.sh
> @@ -18,12 +18,12 @@
> #
> # This example script is based on a RHEL environment.
> #
> -# Here is the format of the ip configuration file:
> +# Here is the ifcfg format of the ip configuration file:
> #
> # HWADDR=3Dmacaddr
> # DEVICE=3Dinterface name
> # BOOTPROTO=3D<protocol> (where <protocol> is "dhcp" if DHCP is =
configured
> -#                       or "none" if no boot-time protocol should be =
used)
> +# 			or "none" if no boot-time protocol should be =
used)
> #
> # IPADDR0=3Dipaddr1
> # IPADDR1=3Dipaddr2
> @@ -41,6 +41,32 @@
> # tagged as IPV6_DEFAULTGW and IPV6 NETMASK will be tagged as
> # IPV6NETMASK.
> #
> +# Here is the keyfile format of the ip configuration file:
> +#
> +# [ethernet]
> +# mac-address=3Dmacaddr
> +# [connection]
> +# interface-name=3Dinterface name
> +#
> +# [ipv4]
> +# method=3D<protocol> (where <protocol> is "auto" if DHCP is =
configured
> +#                       or "manual" if no boot-time protocol should =
be used)
> +#
> +# address1=3Dipaddr1/plen
> +# address=3Dipaddr2/plen
> +#
> +# gateway=3Dgateway1;gateway2
> +#
> +# dns=3Ddns1;
> +#
> +# [ipv6]
> +# address1=3Dipaddr1/plen
> +# address2=3Dipaddr1/plen
> +#
> +# gateway=3Dgateway1;gateway2
> +#
> +# dns=3Ddns1;dns2
> +#
> # The host can specify multiple ipv4 and ipv6 addresses to be
> # configured for the interface. Furthermore, the configuration
> # needs to be persistent. A subsequent GET call on the interface
> @@ -48,18 +74,19 @@
> # call.
> #
>=20
> -
> -
> echo "IPV6INIT=3Dyes" >> $1
> echo "NM_CONTROLLED=3Dno" >> $1
> echo "PEERDNS=3Dyes" >> $1
> echo "ONBOOT=3Dyes" >> $1
>=20
> -
> cp $1 /etc/sysconfig/network-scripts/
>=20
> +chmod 600 $2
> +interface=3D$(echo $2 | awk -F - '{ print $2 }')
> +filename=3D"${2##*/}"
> +
> +sed '/\[connection\]/a autoconnect=3Dtrue' $2 > =
/etc/NetworkManager/system-connections/${filename}
>=20
> -interface=3D$(echo $1 | awk -F - '{ print $2 }')
>=20
> /sbin/ifdown $interface 2>/dev/null
> /sbin/ifup $interface 2>/dev/null
> --=20
> 2.34.1
>=20