Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp338709rdb; Fri, 6 Oct 2023 05:17:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/nWrfgI60OAeWQnhVnXybRBkIx9xp5SsmKE+NLAitYFd1bCtqEZrlVaaDoTCaGov9CB8+ X-Received: by 2002:a05:6a00:24c3:b0:691:21:d9b7 with SMTP id d3-20020a056a0024c300b006910021d9b7mr9202014pfv.27.1696594626482; Fri, 06 Oct 2023 05:17:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696594626; cv=none; d=google.com; s=arc-20160816; b=tdhuEbulGQ6XVDGbjhfcVGizp30dZGz4m6Nus9VaT9deKIVp9LP43Isqi2cGE5jyq5 H8MW+KMl68A2DzsbkyIh6wmuEIL+ZZfG/TYsMStPF6NSm7F84BuHzxUN5lOIn8DWDCRi teJEoWtv7n+a/VdL/2Np0fu5wbgZG5HCvGcsnEtLn/yvEtqXwN3haMh7I0FoJEVDnsiT Fe6pjsfughNYag1uT/9DmbE/sqN7k5RmHM7Jr1g95fBWCW63S8H3rqhPyVhGpFyjdQg/ 0ZP8UUrXKxg5J8ol3SBXwVRT5xfFNqZtIKvyZ+tSnYgHhDQByEuR7s7Goe8bjZ410lVP I4Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hNVK67EoEfC4ks5hIAmDG5CWFmou5FKHiT7V2Fk4tdM=; fh=4MFT2NKgTowNo2W03U7ZGY7QFhxujOFAlW3Jj9EUULM=; b=SZI9mMkBOD48XuEM7bYIMze1Nd2orxBR5akWLu8g3k6xl0lLHPdBRpySzHGRvP7CR4 fTonBhlZPjl45QCDgPARHZPHf86HSbp9GaJXvz/aFtCEOni++6ZSbH5CFs3c4wpkz2Mo PJe85cK9XtP3/w/iOb25jmv/bSd3uwXS/78x1TOaS0qnDPFqywB4YMHsFYTZRbhI6AWz uWdcjbFxPFS5e3zvaAPZpYkJoG7Ut8ajavVhnoTjLCTzm8R5ovyn/cPmTyRHNV8/DpQi qZaMF/MhKLqOSJSpIR0WN4Ts/4QBsO8YC0QNsKjeiu8QbbcgI7Czs73UVEpow4hIjXai HgEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=d1BCfI5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id s21-20020a056a00195500b0068e3b121545si1434342pfk.58.2023.10.06.05.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 05:17:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=d1BCfI5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 73BF08060074; Fri, 6 Oct 2023 05:17:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232179AbjJFMQy (ORCPT + 99 others); Fri, 6 Oct 2023 08:16:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231991AbjJFMQy (ORCPT ); Fri, 6 Oct 2023 08:16:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30F6C2 for ; Fri, 6 Oct 2023 05:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hNVK67EoEfC4ks5hIAmDG5CWFmou5FKHiT7V2Fk4tdM=; b=d1BCfI5Y1aDqG8YFJIpPF8rqpg iX0dqf3J5uWGdolaIETXawNMHPUMFTjjpVZgO+7Ovginh9ff7pRDkB1myntd9n4LyHrItWhkK55gR yKTKZtf3kF/jPbIFSbRmDQp4dO7ohyBJVa2RocafQf5TrNSXflCbUZ5dKsaBAP+NZ5802HQuEHeHQ WosGZ9/Z+Tu/W63PJijMdnT+S950bB+lFBospOiArsxwj320Fy8z7e3hUMlh7HdwNdObkfyNFJ0fo pTS9oXr7tM/OStaBt1wt++t2skwpbA+ybA2RX7PINzg8gq2OoiyUrLB1IvgqRGXNqdp6S1nh5Wc5T 1pXtrEog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qojlB-00FEWW-5W; Fri, 06 Oct 2023 12:16:49 +0000 Date: Fri, 6 Oct 2023 13:16:49 +0100 From: Matthew Wilcox To: Muzammil Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning Message-ID: References: <20231006113948.51673-1-muzammil@dreambigsemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006113948.51673-1-muzammil@dreambigsemi.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 06 Oct 2023 05:17:04 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote: > /** > * folio_move_anon_rmap - move a folio to our anon_vma > - * @page: The folio to move to our anon_vma > + * @folio: struct folio - Represents a contiguous set of bytes. > * @vma: The vma the folio belongs to Why did you change more than just 'page' to 'folio'? I think the other changes you have made to this line are not an improvement.