Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3cbd358e-501a-217f-6482-e20b55e7c728@redhat.com>
Date:   Fri, 6 Oct 2023 14:18:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Muzammil <m.muzzammilashraf@gmail.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20231006113948.51673-1-muzammil@dreambigsemi.com>
 <ZR/6sZmNMpMkfxKf@casper.infradead.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <ZR/6sZmNMpMkfxKf@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06.10.23 14:16, Matthew Wilcox wrote:
> On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote:
>>   /**
>>    * folio_move_anon_rmap - move a folio to our anon_vma
>> - * @page:	The folio to move to our anon_vma
>> + * @folio:  struct folio - Represents a contiguous set of bytes.
>>    * @vma:	The vma the folio belongs to
> 
> Why did you change more than just 'page' to 'folio'?  I think the
> other changes you have made to this line are not an improvement.

Oh, I missed that. indeed, just s/page/folio/ is sufficient.

-- 
Cheers,

David / dhildenb