Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp340139rdb; Fri, 6 Oct 2023 05:19:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlhGzfKuzLbqe6C2cE9dIAG4NSPUJsI3kmblt6KV+fdcNkPeEusljbpaWYHnH9idWAUrZd X-Received: by 2002:a17:903:48f:b0:1c5:ad14:908f with SMTP id jj15-20020a170903048f00b001c5ad14908fmr7061521plb.39.1696594785658; Fri, 06 Oct 2023 05:19:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696594785; cv=none; d=google.com; s=arc-20160816; b=hr72i6fPvvp4RzF0lS88ZHf1zQxtNbGXfDinKiZ71mwV+jgun4jkx/7TMWfPhpLUmX VCvF/3kLhKnCSpAVsK9THAC5shX1SQupuAx3w3m7bl9cPGtVv3zCwFPJ5ZFfJfyJYroo JHEgb6joZfwNIeBWnN2DwXwLgDAm2Mv3wGuXMH+pBKfbthHEBF8q8oxjt2ACuEOq3JT0 QZV1xZdQcJ5vmc9ClIl9VVh7G+buKBhbuLB4Cl+DjaD5iWmo4MUSjqUZqH/1Er7Lx4ET IM+xH/osQ5g5DTxH3s6Gw5sPU0nGF0uwCTJek26JPG3iyqh0XeWdBjsJVupCSK+ob3zM LWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lLisEMrwSw55L7II0CHG9iP51qUAlleMPZ/FDr/qaAQ=; fh=KXFa4gsuO6tF+M1pUTWxNDMncg0EcJAguTRNNYAw1UQ=; b=KmsG9lf9V/PkKef5OLQiv+SOj8Lxt0ExlnupekMd5wZwemjIBtE6NvN0ybarAPA+xj Fs+qCF2ewKJdnUvtZwOvECqVmh55QBB+l/gDW3eDvXcv7DmjwrWJ/QySUdHn4idH5xGA /N8TZGJxiDdGzcqOqiTHV85P+jespYgJTbyKFuQKZDj8wB2D9+9vB12yMj9NBO+JJ8k+ iuBHg1q3ZY7+bZUbxovDmlk7pql3KTsuGcoC9SQht7SsPUafJh4Hxh9oaPa0Og6OiPt/ kdVLqVdZnZfbEgG2cuExATIpkX2cqs3REOgkO2b3FYGk1UJd/AJCRxu5wury0myvzQ5T H0lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id z19-20020a170903409300b001bbaa5e95fdsi3438027plc.102.2023.10.06.05.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 05:19:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2A44B81603B0; Fri, 6 Oct 2023 05:19:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbjJFMTe (ORCPT + 99 others); Fri, 6 Oct 2023 08:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232161AbjJFMTd (ORCPT ); Fri, 6 Oct 2023 08:19:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF22AC6 for ; Fri, 6 Oct 2023 05:19:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5F4C433C9; Fri, 6 Oct 2023 12:19:27 +0000 (UTC) Date: Fri, 6 Oct 2023 13:19:25 +0100 From: Catalin Marinas To: Doug Anderson Cc: Mark Rutland , Will Deacon , Marc Zyngier , Stephen Boyd , Valentin Schneider , Chen-Yu Tsai , AngeloGioacchino Del Regno , D Scott Phillips , Josh Poimboeuf , Matthias Brugger , Misono Tomohiro , Peter Zijlstra , Sumit Garg , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] arm64: smp: Fix pseudo NMI issues w/ broken Mediatek FW Message-ID: References: <86jzs2ofqs.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 05:19:43 -0700 (PDT) X-Spam-Level: ** On Thu, Oct 05, 2023 at 08:34:56AM -0700, Doug Anderson wrote: > On Thu, Oct 5, 2023 at 3:27 AM Mark Rutland wrote: > > On Wed, Oct 04, 2023 at 07:04:12AM -0700, Doug Anderson wrote: > > > On Wed, Oct 4, 2023 at 3:15 AM Marc Zyngier wrote: > > > > On Wed, 04 Oct 2023 10:59:50 +0100, > > > > Mark Rutland wrote: > > > > > Given you haven't seen any issues, I suspect those are getting reset to fixed > > > > > values that happens to work out for us, but it is a bit worrisome more > > > > > generally (e.g. the LPI case above). > > > > > > > > It is likely that these SoCs don't even have an ITS. > > > > > > Right. That was what we decided [1] when Marc pointed this out earlier. > > > > > > Overall: we know that this firmware behavior is not good but we're > > > stuck with it. :( At the very least, any new devices coming out will > > > have this fixed. Presumably if old devices are working OK enough today > > > (as long as you don't enable pseudo-NMI) then they can be made to keep > > > working? > > > > > > So circling back: what patch should we actually land? > > > > For now I'd prefer we took the patch I sent in: > > > > https://lore.kernel.org/linux-arm-kernel/ZRr8r7XMoyDKaitd@FVFF77S0Q05N.cambridge.arm.com/ > > > > ... as that leaves us no worse than before this series, and it's pretty simple. > > Sounds good to me! > > Catalin / Will: Please yell if there's anything you need me to do. > Otherwise I'll assume you'll pick up Mark's patch instead of my patch > #1 and then you'll pick up my patch #2. I applied both to the arm64 for-next/backtrace-ipi branch. Thanks. -- Catalin