Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231005140831.89117-1-roger.pau@citrix.com>
In-Reply-To: <20231005140831.89117-1-roger.pau@citrix.com>
From:   Ross Lagerwall <ross.lagerwall@citrix.com>
Date:   Fri, 6 Oct 2023 14:15:38 +0100
Message-ID: <CAG7k0Er8cVKHF2NwogmXtuN57iYb0rGoQH4aZgg7boy2Hv4-fw@mail.gmail.com>
Subject: Re: [PATCH] xen-netback: use default TX queue size for vifs
To:     Roger Pau Monne <roger.pau@citrix.com>
Cc:     linux-kernel@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
        Paul Durrant <paul@xen.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Ian Campbell <Ian.Campbell@citrix.com>,
        Ben Hutchings <bhutchings@solarflare.com>,
        xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 3:08=E2=80=AFPM Roger Pau Monne <roger.pau@citrix.co=
m> wrote:
>
> Do not set netback interfaces (vifs) default TX queue size to the ring si=
ze.
> The TX queue size is not related to the ring size, and using the ring siz=
e (32)
> as the queue size can lead to packet drops.  Note the TX side of the vif
> interface in the netback domain is the one receiving packets to be inject=
ed
> to the guest.
>
> Do not explicitly set the TX queue length to any value when creating the
> interface, and instead use the system default.  Note that the queue lengt=
h can
> also be adjusted at runtime.
>
> Fixes: f942dc2552b8 ('xen network backend driver')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> ---

Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>