Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 6 Oct 2023 18:20:18 +0800
From:   Yi Sun <yi.sun@intel.com>
To:     Nikolay Borisov <nik.borisov@suse.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <peterz@infradead.org>,
        <x86@kernel.org>, <kirill.shutemov@linux.intel.com>,
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        <kai.huang@intel.com>, <linux-kernel@vger.kernel.org>,
        <heng.su@intel.com>, <yi.sun@linux.intel.com>,
        Dongcheng Yan <dongcheng.yan@intel.com>
Subject: Re: [PATCH v4] x86/tdx: Dump TDX version During the TD Bootup
Message-ID: <ZR/fN5SDW5pFX1yR@ysun46-mobl.ccr.corp.intel.com>
References: <20231006062855.875631-1-yi.sun@intel.com>
 <2b222a2a-f749-46e8-8489-b590dc2061cb@suse.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2b222a2a-f749-46e8-8489-b590dc2061cb@suse.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGJnM0tIWkJTZ1ZGL0duSW9SckV6T2R0MmVLYnZjMlYzOElkK0ZobzYrdVZM?=
 =?utf-8?B?Ymlaak1kTkxpY1BFd05kNndndHlTNHE1WXRzV0thM1BZNVNjT2l2RkNQdWdo?=
 =?utf-8?B?Wnptd2dpU0pobURtSUJ6Sm5VNklRbG8vc3pNVUY0MEtZZXJJUlNqQkdETVd1?=
 =?utf-8?B?Wk9BbmlhNUpycGpzNWFEbDRqcitIaHFrL2YydFB4V1Z5TURsVHFMWnJhdHlw?=
 =?utf-8?B?SmtwMEIrUzFlOTZEeEZRa2tqRm9xNGJDTXZidlBhb3R1NUV0VnYvQmNLZm40?=
 =?utf-8?B?TjA0cW5tNWQ4eUtZQmdRVXcwK0x0R1BONDhKNFIxNk1YY3pDSTBhWTQrWWdy?=
 =?utf-8?B?ZUhQdkpDRzFnWDBsYlhrUW1xVHd1Q2dSQ0hCRDRKM0RENXRaTHVxblMyMHFX?=
 =?utf-8?B?WXR5Y2RqSG43R3BNZnJ5a01SOCtudHQxOGhlMVlYQTI4UW5kYlVHdTNUa2xG?=
 =?utf-8?B?enhXSllKMUp6ZVJ0bDlTY292RXQ2NytQV25mcXVvZ1JiL1ZUT2tQdUg1Slc0?=
 =?utf-8?B?TVQ4NG1FaTZyUkJwV21UaldENkxQTSt6OVdnVXR6OWowaHZuSEZKRzRPYnJ0?=
 =?utf-8?B?WGdDTmE5RGkyekF2S0xrVHpaWGFzeUdnYjFwUVBrYmUxK1VQOXhnc2w1d1Jx?=
 =?utf-8?B?NTlUMEt6RUIweDNVZVNWRmYzYmc5ZUJnMGluZGp3SHVWNTU3bkNwWWVYVUhP?=
 =?utf-8?B?YWg3STBkSTIxK3pUVkRuMm4xbmtNS3hobnlnWk8vWWNTY1lKVE5UODFoaS9P?=
 =?utf-8?B?SjNvcDFZODBUTEc3Z0JMKzJjOHdxVmc3RzRqVUhYUW9RM3FHVFVXTmYzOFhl?=
 =?utf-8?B?QkpGbzFmM2IvQTZIYzYyYmV6QmphUy9PT2o3K1MrSXdaTVYvSnZJbndUZVdI?=
 =?utf-8?B?MTB0N0h2UkZNQlVMd0sxcm1xeHBLaXR0YnZuTlYxN2x0YkZRRlRHd0p2UGZR?=
 =?utf-8?B?TE1CRDJZQ3F6OGdLV1c0ZjJQMG9SQU5jZXY4cEhPNUZGQ2JPZXdsSjlOamxm?=
 =?utf-8?B?SW9PRXM2dVhBUzNOdG40QjFQRUc0cTFNanI4S1gxenZLR2pQY2M1MDl5TkYv?=
 =?utf-8?B?cHFsekQ1S25zcnVhbWtiR2EvRjNFdENNQWZqbkJoZy9NQ21TdzZpYVRrR29s?=
 =?utf-8?B?c2dsMytIUGFMM2xZK2pKZXRiOGRHKzVqNk5rejV5dFdkc0hxZ3BaRlc3L3FJ?=
 =?utf-8?B?SGIxODhqMVdYTTNZdkdjQ1ZXYWs2Tk4wS3cxWXVYNFAzREtrR1pSS0tic3Z6?=
 =?utf-8?B?ZDdHaENXeGh6MzNGTWllQU1YZE1QZlJUR1pScHMvNFZNVDhkdVZQcmxxd1pK?=
 =?utf-8?B?QzJNVU1FWXU1OGRjcnRDWlRJQ3dYSThOS0UrVU4wSm5tWk1pajZGcjB0bjFv?=
 =?utf-8?B?clcvRTZCQytHRkZZZlg1OG1sOUtVRGdSaGY4RnNscmhkQ1IxUGxLcW1Ra0tS?=
 =?utf-8?B?NTRzQTlQOUxiR1BkWnIzb1lMSXYxRjhBVHNDaXBYSkJMNFVjYmg1dGV1QUpI?=
 =?utf-8?B?YTQ5NndrL1RaVmY1WmF6eDBjZHEySm9ncE5PRVJaUGFzbWxwUG5iN0E2ekx4?=
 =?utf-8?B?VUVwb1hxRllJMjlLWGtOTURzNFl3NnhJTjBvTTdmNEJVZktBaDNtZEJGZllI?=
 =?utf-8?B?OWQ0UytXd0s3cjRqKzVaOG4xT0Jyb0hFQlJDNlZicXBUMFoxZUdvVnpVK09U?=
 =?utf-8?B?eCtYa2FROGNmV2xRQkVFSndLSnZsNjRqV1FKRlZkS2NpR1FKLzQ3N1ZEWmc4?=
 =?utf-8?B?Um1wTEdsMjBvWEhYNUtBT25JOXp6QWh3SXpoYVFCeGl0MDhHRTl2RTd1YUVi?=
 =?utf-8?B?RlMvMXZNSk9neHVJY1pOdzB1Ky82Q091ajFDTmJGNnJ2QTFPaDZ3QVhxMFB5?=
 =?utf-8?B?dWpmcW5PQklHSkpaRHpDRXY3dWJIUExGaDl2WldXdzltSGFRNDNIRFJQUk5q?=
 =?utf-8?B?NThYekxXS1JHNWZuRW9FZmM2Z2k0U0pXNHN6L0V2UFVZOTlYQ0R3L1hxWFNV?=
 =?utf-8?B?MGxOR1NxLzQ5THhyMW9TakxDbGZxR0U1SFRLS1JFOWFDMy9pVVNkT1JyRElF?=
 =?utf-8?B?Y21nUVUvVzJma29VWWtWUUFWQkRMR2RaaXRjZ1JmR2JrYnE1RFhWdTBSRGJ0?=
 =?utf-8?Q?sz7Tn+CE/MzF8b9Xow73sz4xZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e7ed9e8-ba9e-4e90-fb4a-08dbc672a333
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3094.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 13:46:27.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: deNK722hkl3IOt9VSaEltDmtfREYkwV2bGvp+HgBpfIllT5Umx+eGAvVA9OEeOL/mMeGes8GfZt5ttoA/8vPkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8338
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=3.8 required=5.0 tests=DATE_IN_PAST_03_06,
	DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 06:47:44 -0700 (PDT)
X-Spam-Level: ***

On 06.10.2023 11:11, Nikolay Borisov wrote:
>
>
>On 6.10.23 г. 9:28 ч., Yi Sun wrote:
>>+static void tdg_get_sysinfo(struct tdg_sys_info *td_sys)
>>+{
>>+	u64 ret;
>>+	struct tdx_module_args args = {
>>+		.rdx = TDX_SYS_VENDOR_ID_FID,
>>+	};
>>+
>>+	if (!td_sys)
>>+		return;
>>+
>>+	memset(td_sys, 0, sizeof(struct tdg_sys_info));
>
>So in case of an error this function would effectively zero out 
>tdg_sys_info and not explicitly mention that something went wrong. 
>Dunno how sensible or likely it is to get an error while requesting 
>the ID_FID ? Also why don't you check for errors on subsequent calls 
>to TDG.SYS.RD ?
>
I'll add some error info before each error return to know what going
on when some error occurs.

Actually, I removed the error check for subsequent calls to TDG.SYS.RD
in this version, since it's probably not necessary when the first call
is successful. I can add them back with warning dumping when errors occurs.

Thanks
    --Sun, Yi