Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp410407rdb; Fri, 6 Oct 2023 07:12:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGH+N1aBOcXLEEGmbChBv3TIu+aUCsxoT6ZqdysABSEz3aepMtc9OmboZ+mf5Nb6GY+dEj X-Received: by 2002:a05:6358:591c:b0:143:7d73:6e66 with SMTP id g28-20020a056358591c00b001437d736e66mr9403162rwf.1.1696601540815; Fri, 06 Oct 2023 07:12:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696601540; cv=none; d=google.com; s=arc-20160816; b=K8Bnhkxfok3+r+4l+pNpk4qKeciCOineMfDvjm39FghBnqzS28JX+Phabt4Zan0K70 iFZ7ObpYA6XIm5pZN/l/rIOJQLYPuG6LaUizsOGZCgdCElR/swO1xy/kMytDD4D3Zx3x voW0EqCweskE/NTmvSlOZI9ikP8Ce9Jy4PR6wPre3fGMEVZ3TdsCVQbSpZXQlBZpdb0N B8tSPbKN68b+lRkaBsO65XLbKSmGBON+2hkZRH2Njprl91aMjypfSAm0IrmNj5GRuJn3 S/5xX+XazMEdxRnoaeWAfmjDX2HfwsF6iSEa4ZgT0xUfH0jX3Dwbn5Ad3PqYZnLYQHsT 4+tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=sViNvo0Y5U1oSFiw+7bgUKfU5gmNtEqj3CF6Xj/3op8=; fh=xLiRFlQ4ANK4yCuW41Zprdjug9ABbcvBos7BIzMlOig=; b=pqh8Qtb6mBtq86x1gxYdZ+ahuj6no1aumXCJRXSyTOy5jhVgkDhklosFkgmT1KRwey 52zylSUh66O7KMl0BChzA6dBUqQQo1bAV+fqpJ6qCcyO2061+ILBdD6x4piwXkTLCZeQ fcMQfCkKJV57RIhM/aMOqbdmXkHY5u7vlYmSPRuVB3uHpwL1Li+53Vt7FSXo/4m8S6NH TDf1CU6VCkGpoodD4Ts301tgXKJ4u27jbob+nJccBdiuEeAUswCFMd9vQfbuFHspxPrb zTZZ1NJDvaIvHESlBHEY8bYx5Qb9gRmnokukrAfrahqKSDYY9yK4KFQCRHy+JqXpx7th v+Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KgviZjvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id 22-20020a630f56000000b00578af609d05si3620512pgp.244.2023.10.06.07.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 07:12:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KgviZjvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9B67380209E3; Fri, 6 Oct 2023 07:12:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232502AbjJFOML (ORCPT + 99 others); Fri, 6 Oct 2023 10:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232248AbjJFOMI (ORCPT ); Fri, 6 Oct 2023 10:12:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C157CCF; Fri, 6 Oct 2023 07:12:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A6AC433C7; Fri, 6 Oct 2023 14:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696601527; bh=W8T8/kn6nOnCi47BvSU3UPd5pajVYNfSAYkFoseDTvM=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=KgviZjvUz8fDz4vKM9icf1PH4NUbznGzDmj443TXG6EmWUR/Oqfy0eyidyq7vuihT X6IIOueAvo64dLdlARg/vPmNT5slnguyN4Su3yLP2ROO4Z78E8VULuUnKxbdfZFTcI HZiMJ0cKuEmG9GyHHbu3w3X0Z48HC2KL3oG3SQ9UnUCU08wewLhXweTSklAZ8vedFS Wtz6h3TE/xFUmnpOyRWKYA6s03YAmqUe29vk8BXuTf8mMHm0qPvXlnhk2A3LlkKGgm xH6S4s2q3nnUF6NI3GSYfMnjjnY+ygfIpuN1kbrkOvVEp5PHcvVFG4sjWyBKaTmvMJ TVMOXqTHGGzQQ== From: Benjamin Tissoires To: Jiri Kosina , Benjamin Tissoires , Johan Hovold Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Maxime Ripard In-Reply-To: <20231002155857.24584-1-johan+linaro@kernel.org> References: <20231002155857.24584-1-johan+linaro@kernel.org> Subject: Re: [PATCH v2] HID: i2c-hid: fix handling of unpopulated devices Message-Id: <169660152573.2015335.12847604884755165394.b4-ty@kernel.org> Date: Fri, 06 Oct 2023 16:12:05 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.1 X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 07:12:18 -0700 (PDT) X-Spam-Level: ** On Mon, 02 Oct 2023 17:58:57 +0200, Johan Hovold wrote: > A recent commit reordered probe so that the interrupt line is now > requested before making sure that the device exists. > > This breaks machines like the Lenovo ThinkPad X13s which rely on the > HID driver to probe second-source devices and only register the variant > that is actually populated. Specifically, the interrupt line may now > already be (temporarily) claimed when doing asynchronous probing of the > touchpad: > > [...] Applied to hid/hid.git (for-6.6/upstream-fixes), thanks! [1/1] HID: i2c-hid: fix handling of unpopulated devices https://git.kernel.org/hid/hid/c/9af867c05b5d Cheers, -- Benjamin Tissoires