Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <603c42c5-8059-a400-a920-3e6c14689dca@amd.com>
Date:   Fri, 6 Oct 2023 09:30:37 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 3/4] x86/resctrl: Add sparse_masks file in info
Content-Language: en-US
To:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>
Cc:     Peter Newman <peternewman@google.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        linux-kernel@vger.kernel.org
References: <cover.1696493034.git.maciej.wieczor-retman@intel.com>
 <684da427338d68b216c1f5636a4930bba06f7b60.1696493034.git.maciej.wieczor-retman@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <684da427338d68b216c1f5636a4930bba06f7b60.1696493034.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTByUEFZa3dWN2FEemRiWjhmZVdNMy9PZGtsemNLV1NEdEZaL3Y1UENHakYv?=
 =?utf-8?B?MXdSbk1XejR5dHkweUpBdmVSUzZiOGp1NEQvcDBsTjlGK1gwSFZrS2tzaEtG?=
 =?utf-8?B?QWtVN1FOQ2VjVk02dGkrOXhpM3dEcGtTUXZSaGVrRlV0TnpEM2JCZE5aTnpS?=
 =?utf-8?B?UjZIVG5KOFRGUnRGejNhVkhIakdmUjBQSzQ4NDgvZHpNV01xSGhZd2VZSU80?=
 =?utf-8?B?cHBIZVVDY0RLUEtsdXFrNS9namZHbHlQaEl6VGVEM3BoZ2FSWXgxTVhyVWY4?=
 =?utf-8?B?Y0JLUmNkTlBTMlViSm14OG1RSEhYbWhGMjBKTEVoTFdYM3hQWHFScUJrL3JZ?=
 =?utf-8?B?UXh1eUlMRXlua0xsbm9rV2hjK1d1NkowU1VIQ216STZlR3p2bnU3UWFPenFQ?=
 =?utf-8?B?MjV0L2VtMWJQR2xFNlg0ei9wR2NFcnlPOHJNRUdPUCtkTWVXaHJIbDlMa2NO?=
 =?utf-8?B?eHQwSFZPQnlxeWhDVGNYYVNIUzhxQXg4MHpkb21LK1pXWTNPQkxDTnV5VTRE?=
 =?utf-8?B?NWR3MEtlaFcybDZaMjVCeXBQaGg5ZjBteWxucjlaVE5vdS9zYkhDZGRFdU1C?=
 =?utf-8?B?WVhoRFRkNDFtYTl5dWlaNWtka3ZscnhTSFNzeGo2ZFNFOWd6OVJHdVlqUlA3?=
 =?utf-8?B?NW1YREZsYTJibW5pVzEyaGdneEQ2Q2Q0YlFRN3NoWkJrWTlyakxTQ2FJQWZs?=
 =?utf-8?B?TzIyRzRWcXd0RFBjWnNxaDdxRWc3TVNoVXRvSHpENXpSZHJlVFk2elh4UDhP?=
 =?utf-8?B?MUlJZlhQaVJ6bVNyY3MzOTBMQTRnMTZBUXdQcUpVYVdkZ2ZpNXN4Rk0zdlA0?=
 =?utf-8?B?VlY5ZFhjQW83RnZvOEF4Mmx1TFVCY01mMWJGWHA0c1BOYzJDRFZjTkNIcWRl?=
 =?utf-8?B?K2tPWnRlb2I3U0hoZGxLTHk4Q2lSS3U3N05xUVBnb21FdXBNREQxVWVPeUFW?=
 =?utf-8?B?TzVyc2piTGF3ZE15MWhwcW4wMVI2YVJBYTF1Tm9ZSm5neFB6cmVoZE0xZ3NV?=
 =?utf-8?B?WXpDb25BcXFMRnVFRXIxMUNBQ0xSbG01alNxRi8xZDJYTEF4ejMzRk5ZS2RW?=
 =?utf-8?B?Uy9FS0NtbTN3RU9oUGcxQjMrZy85NWNlcnBER0pPNnZlNkUvRzk3cmJ6ZHVv?=
 =?utf-8?B?dTE2NVFsR0I2SHpJNG5WZ2dNbkp4VVN5KzRYTGthQXJVaUErVXhIREJQdDdD?=
 =?utf-8?B?Sk5aMkJCRVlTZjVtUGZ0SmZZcFZGdHdWV01MRWcrZElmNDRkbDFyTUFoNUxW?=
 =?utf-8?B?T3dyMU1sSkhnT01PbFFaeEJZUGVYM2FwWHg1VFJ0SmswQXpWV09udTJKTzdW?=
 =?utf-8?B?bnlVemZxcVBNOWpNckxhZ2dOUGorZ1dQMTVvUTZjY29DOWtwdmxsenFBekUw?=
 =?utf-8?B?NkF4WkJTUXdlSFkwdk5iOHQyK2UzQVh4cnBhL0VrNkhNS0RLSE1oTDRWOG54?=
 =?utf-8?B?R004ZTJ6OVRsa3pWV3hwdEpkRXQzU3RueWdjNXdleTFzM05Qd3p1aTZ6RjlD?=
 =?utf-8?B?ZHF2VVpyL3N0ZWlFeWEyZFdLWVJoc01tM2hMK3hUTkxoTVpwbkpsNWZJNXFG?=
 =?utf-8?B?M3luZi9kdHUwMThBb3dza3RUbTl2cVN4alJsZ2oxVTdBRERTSlFzK0x0aFEz?=
 =?utf-8?B?ZjlocU54UjBxblhSZWYyaDR5MEpieENhQlg2UUlDSVJ4SUZrTjF5WUgwQzhs?=
 =?utf-8?B?eDBwcC9DWFduNTVYR0VES3lLM24vSkgyK1p6dFZoUmRNTlA1K1ZLdmNUUnI5?=
 =?utf-8?B?QWhRNEhvTEJOYWpvZUNTSFZmc0pJWVNxZ2F6UmJJMjB6Z0V0R1ZLVm5wczd4?=
 =?utf-8?B?T1BTeUpRekFPYkxweVJEWmNNNTRrWmpzREFEWkhuTWhFU2JDQjQ1dEtEbWZG?=
 =?utf-8?B?clVtV3R0YStva3dNbUxRcDFUWnp3cTBMdU5wNHl0YTEzZkIrY2RMelBQd2Ft?=
 =?utf-8?B?V3ZzSDdCM1JSWjVDMWl6NXBzWDkrT1hWSFhCNWNKd0lKYVNQQ1NhbkEydUJn?=
 =?utf-8?B?Zmg1Q0pWTnpzSStMcnRIZU9KZCtZZmtRa25GR3c1QzF0T2JHV01pVVpKbHFs?=
 =?utf-8?B?NHBORjAzTjhBRXNBdWdCTExudzhXbGVmeW9GcEd5WkVJcC9pU09lemxOV2Vh?=
 =?utf-8?Q?EKvIuovbGxJF262eiUr+ufoEE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d12410d7-af80-4ccf-df1f-08dbc678d136
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 14:30:41.2886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +of9qzcFghvdsyyKXkqXP7r03n4esCTVKDBSboemZPLI1rGsqWvDWJBD1o2XAAAG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8256
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 07:31:06 -0700 (PDT)


On 10/5/2023 3:15 AM, Maciej Wieczor-Retman wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
>
> Add the interface in resctrl FS to show if sparse cache allocation
> bit masks are supported on the platform. Reading the file returns
> either a "1" if non-contiguous 1s are supported and "0" otherwise.
> The file path is /sys/fs/resctrl/info/{resource}/sparse_masks, where
> {resource} can be either "L2" or "L3".
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Peter Newman <peternewman@google.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---
> Changelog v4:
> - Add Ilpo's reviewed-by tag.
> - Add Reinette's reviewed-by tag.
>
> Changelog v3:
> - Add Peter's tested-by and reviewed-by tags.
> - Reword patch message slightly. (Reinette)
>
> Changelog v2:
> - Change bitmap naming convention to bit mask. (Reinette)
> - Change file name to "sparse_masks". (Reinette)
>
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 725344048f85..945801898a4d 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -895,6 +895,17 @@ static int rdt_shareable_bits_show(struct kernfs_open_file *of,
>   	return 0;
>   }
>   
> +static int rdt_has_sparse_bitmasks_show(struct kernfs_open_file *of,
> +					struct seq_file *seq, void *v)
> +{
> +	struct resctrl_schema *s = of->kn->parent->priv;
> +	struct rdt_resource *r = s->res;
> +
> +	seq_printf(seq, "%u\n", r->cache.arch_has_sparse_bitmasks);
> +
> +	return 0;
> +}
> +
>   /**
>    * rdt_bit_usage_show - Display current usage of resources
>    *
> @@ -1839,6 +1850,13 @@ static struct rftype res_common_files[] = {
>   		.seq_show	= rdtgroup_size_show,
>   		.fflags		= RF_CTRL_BASE,
>   	},
> +	{
> +		.name		= "sparse_masks",
> +		.mode		= 0444,
> +		.kf_ops		= &rdtgroup_kf_single_ops,
> +		.seq_show	= rdt_has_sparse_bitmasks_show,
> +		.fflags		= RF_CTRL_INFO | RFTYPE_RES_CACHE,
> +	},
>   
>   };
>