Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp430113rdb; Fri, 6 Oct 2023 07:42:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgnpNnYOMegwQuVrndT7NGTFNdaObDnFQ539tTECw3SMnaEG5e1TyBZTnAIv6T+GaeYopt X-Received: by 2002:a05:6a21:2724:b0:16b:74db:8fde with SMTP id rm36-20020a056a21272400b0016b74db8fdemr2290361pzb.61.1696603330557; Fri, 06 Oct 2023 07:42:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696603330; cv=none; d=google.com; s=arc-20160816; b=F8i9LF9O67QC1yFD3zgq3UznZK5Tz8ArYKO8fin4DleNwtk5SDC9D9oaS2KKaOTLZP ZYmnZ+cK2DUjHBABsq6tnFzJTALCA3//+p5U4DxkKf/1Gcp1AP72IapAXORAZbMexHaG l/P+qKcyBPYGYY/aoC9xtSGUE1lYNq80QlraLffhRlPo4rV5TIbvy2PSIbqURwgzHPuL VZ+WYzCqNsi91P/JyPKnkQBokwjYLDDrW2ondHRVRqd0F3HRV3uuNKJ+5QKyyAtHM4RO uNPSWNrdBmfQr99WIdAwCaCORRBAaKOiNvuZlv9kfw+k0KVUh/HvExhJiD51S8zwahgG SUgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Kz0MyaGCfhSoACpQk6IQSVxzrVBlg/0Wg5XzExLzRJA=; fh=BOGsVD5h+slBLnv4LXNkYQA5Eo80pM/iBAYQYCG575Q=; b=mZrorSZSwIn4q/2GQL2EL1n/EavKoWErdydIGMizm+aJe7CiGPj4G+nOWPqCzxbQCx eXW/8Dt3fU1P+AOuS9FVfUnS4WzDYTZ37OlRkQK4E4cAbnLGKLbZH70JrXAJNRETDyGH BPSHwZTaNbZZk7X8Do9i1hSaKLvfJKlXi6i95MJpIyO1+VmohuikmyGx+v4XgE9k6UPM mhW1zrLkY5fH0quQ1IpxMdd0zmi1N8MEwHdZT0y2vn/GNg+GFCaTUaSXHEcB851R+Tmw m5brvqUPm68ihw4YM4gNep220nK96ypdOKWzfeB8D1ITgD1Foatu+TdBK2sXBIBwRczs YG9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vyVGILvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id t26-20020a056a00139a00b0068fef323e54si1659251pfg.296.2023.10.06.07.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 07:42:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vyVGILvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D5F25801B885; Fri, 6 Oct 2023 07:42:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232628AbjJFOly (ORCPT + 99 others); Fri, 6 Oct 2023 10:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbjJFOli (ORCPT ); Fri, 6 Oct 2023 10:41:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DCD9DB; Fri, 6 Oct 2023 07:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kz0MyaGCfhSoACpQk6IQSVxzrVBlg/0Wg5XzExLzRJA=; b=vyVGILvYDUxK77TznDGevX+p6+ QeB3UyVYGG8z6uY8GfJUrVbceGW071wpmajsdgoky80NKhEJyy9wbt2HGIVvYK+V34X/xcZ7M88tO uv0A8F97qeYjl3j1wXTJ37tgEpP6bzpv0QeCjQfyLHCVQSrkDrYuixC9k1VwkKgD7O/aDn8K4oHEu aLBRPykgQkjRXYvNQg7Rvb3sYtTZ9ATM5boFOzN5hvaDmbVb9FPzFNpEbzgW0gFqTRukUUuq3MIFW 1g2dA6Ns4ySooj/qULREI+uxM4kG5aT9g3OTf2WvqX1Z3WFRAc8Vexl7STBLjJ85GDuxLMFsKshej LScv7kIQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qom1A-00FrAt-MO; Fri, 06 Oct 2023 14:41:28 +0000 Date: Fri, 6 Oct 2023 15:41:28 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, linux-kernel@vger.kernel.org, Pankaj Raghav Subject: Re: [PATCH] filemap: call filemap_get_folios_tag() from filemap_get_folios() Message-ID: References: <20231006110120.136809-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006110120.136809-1-kernel@pankajraghav.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 07:42:08 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 01:01:20PM +0200, Pankaj Raghav wrote: > From: Pankaj Raghav > > filemap_get_folios() is filemap_get_folios_tag() with XA_PRESENT as the > tag that is being matched. Return filemap_get_folios_tag() with > XA_PRESENT as the tag instead of duplicating the code in > filemap_get_folios(). Yes, I think this makes sense. I was consciously trying to make them as similar to each other as possible. I hadn't realised I'd succeeded to such an extent. Reviewed-by: Matthew Wilcox (Oracle)