Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp436324rdb; Fri, 6 Oct 2023 07:53:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZgfRcBRg9Zy0Xbr3NDhJBn0R1U7Uc63Qfv/W5Iw0xLaE1GuQ1XkOP1EKgwMJpm3u6t88N X-Received: by 2002:a17:90a:8b0f:b0:276:785f:7edd with SMTP id y15-20020a17090a8b0f00b00276785f7eddmr8604178pjn.25.1696604018655; Fri, 06 Oct 2023 07:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696604018; cv=none; d=google.com; s=arc-20160816; b=U3CTl2b4077zAv41uYl+aZ/PlhUMsNm5AuwUEKTf48ZDvp5aCbhAHWLhwJSSQYymr6 pZQx+V2iKBOrQG1+m8wV0C0K5H1+nvsIxTs1feKx7KSqDnuMmyL/e0VbCiSMBSIizrqR blKjVdXiui9W+rnXrsQSD9UsNzhzcXKmjmPdE5n74mVsWXwQzwRY53Y3oUh4nakghqhi Aqj3K0jAwkilsQw/oexwqmz69RswIoeooNXdwTrwOo5XuDjBMRKiDbl6Alq3E623w/ps n+rFkOAPpiRdxRFnoEl8T5NYodRUdnADvuQ1YX8ybBCXAU1ZtACazlgYqZzTIq6C9TyO Eb/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hrgggEGosELvz7tO/RqZ7JUeXLjbLpkBBVEktBc+OzU=; fh=ikpo0bAHRQenNZNnvdb3xUru29St/04+wnfZ1twva+I=; b=WzzU7XUX/LgcoCF3wRnqBpIa1yDZsufJD3AlkxOhNHMDgukSW86gNycrzMI1qAtNKq 5qPa489M6T7LkVpwcmXleLfDNsc+p44wCr40Ok6MaVIRISMnz8XRSpNBMJhereIDZB8e l9iQDP0YfwWTdTDjojHc+kzQEWd8jCjnvGg6YdYaXPBdqvk1E83EYT7MtKxQgNDM5w5E wEoR1JgD/JJ3n/ae7sX52FkMYW2AJbkkJVPSKDXkReMJEIauLEdXDMFycWraTJkPpmvI qrMUwOW/wn850kGzTjZiNqrCLHr7VLSRbzuwI4ZrlIN988dGQiDo/YtYwsYpCHXSjZy5 NbhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FUoSK0Ry; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id lp15-20020a17090b4a8f00b0027756e1f0c2si471186pjb.7.2023.10.06.07.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 07:53:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FUoSK0Ry; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 05CBB81BC2C4; Fri, 6 Oct 2023 07:53:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbjJFOxX (ORCPT + 99 others); Fri, 6 Oct 2023 10:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232637AbjJFOxW (ORCPT ); Fri, 6 Oct 2023 10:53:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6661AC6; Fri, 6 Oct 2023 07:53:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73D73C433C7; Fri, 6 Oct 2023 14:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696604001; bh=hrgggEGosELvz7tO/RqZ7JUeXLjbLpkBBVEktBc+OzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FUoSK0RyDwIcxEH0ffclHP1EAduYZpTlsvDqRskZieqin/bDUDy0NfLfBt5JQZtg1 u1D6dOeK0pOSd9DLa5AHuGBxTNKhTa889M3k8HRKwGo6AY3G1Ve/e2lUzIaSPuscNz E7LURfSlYGJAVz31eOjjlH4pB/JANz08Puf+04V3CK6jUvGKRk5CnPBku9duaTZbBG Y9K0lMHVp2RGdrNcXhM2VCb2XMRnVVYeTCDTNUym5Qw0T1ufXhm14djgsnQJd1grEi 5J7o/k+CxJusbREvVsqiaLeMVFhnwaPksgeA5Q4rjO5sGoht5TLs190HqXAXaozSLh nDllmk1JGarYw== Date: Fri, 6 Oct 2023 16:53:17 +0200 From: Maxime Ripard To: Benedikt Spranger Cc: Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Michael Turquette , Dinh Nguyen Subject: Re: [PATCH 1/1] clk: socfpga: gate: Fix of by factor 2 for serial console Message-ID: References: <20231005095927.12398-1-b.spranger@linutronix.de> <20231005095927.12398-2-b.spranger@linutronix.de> <20231005203202.08b5d1cf@mitra> <77d94f6a6a4b45f8ad711f52ca6ba86c.sboyd@kernel.org> <20231006053906.1bb2a7d8@mitra> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ohme6vguvci4zhdr" Content-Disposition: inline In-Reply-To: <20231006053906.1bb2a7d8@mitra> X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 06 Oct 2023 07:53:35 -0700 (PDT) X-Spam-Level: ** --ohme6vguvci4zhdr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 06, 2023 at 05:39:06AM +0200, Benedikt Spranger wrote: > > What's your analysis? > Commit 9607beb917df ("clk: socfpga: gate: Add a determine_rate hook") > breaks serial console output and changing the determine_rate hook to=20 > __clk_mux_determine_rate() fix the issue. That's not a sickness, that's a symptom. There's something wrong somewhere, and you're just papering over it. Maxime --ohme6vguvci4zhdr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZSAfXQAKCRDj7w1vZxhR xV0ZAQCPKV9Ohe5ffLhTlsBGIFaJzXXHBZqoLRzKHrfWiLKtKgEA/MY/ea7a/A0c QaXJhAFkt7vpAB634d2TDU6eTsKI1Qo= =SBiv -----END PGP SIGNATURE----- --ohme6vguvci4zhdr--