Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp439469rdb; Fri, 6 Oct 2023 07:59:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOS8WkMd5SEShssaYClgsHqPe44OaQy7UBsnBqrk5NAEEPeQ/LhyiQVAsZNrslrEFwkKHy X-Received: by 2002:a17:902:e809:b0:1c7:1fbc:ba02 with SMTP id u9-20020a170902e80900b001c71fbcba02mr9666361plg.47.1696604364518; Fri, 06 Oct 2023 07:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696604364; cv=none; d=google.com; s=arc-20160816; b=HBHRyR0lN2rrn2XVeMxHusMWvLzA3ce4dQ/va+ez3gD97NRw6kfL8rfO+JaOOqY1M9 tB0RgYThUr4WgYH5vClHyA3Ge01TdPPJNdTDFjSVQpkbh2hVcmPYgpO/xGSxEdL2VOmv bxl5fn0i8gvylU6uD2EbqORDydVErBL9hBJGgdanlS+FbBbBhfgiNYO8WSvCjjmS6QUa JMX35dstqTYrsW0OubEHEv67G6nTZqOLWfXocea6F+S5v6YLUsQY7Ttepdjo59cUmGfb CoyCgl3tAY0X1bIhGL6BwMgnRjhpAbVhtBZuhxCH3WKfVC9umrxIlgC/iKK4odoFn9ZQ X5ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uItWDtjDLDsYie25lriE8ITBNi8dVA68oOA9Jcrik1M=; fh=kE9ntwSpgvbCnOEHUhHBfbYwthjMy8eGO44hV6LRhkA=; b=KcJN/mk8nOYPT9zFXMO5Bvqe2TxrB7P6FYvwqvWSYww2ttEVc7Vq9OgNjLIVzdDyAi +yIgVaS9lQg8JpN52jxJ6CYTQTm5/Gc0tpBN0TBtB4qJjBNhHTDpv1VwIU7OBgojDqV8 Oc7dGwWhSygI7yrikQje/RSRWkVRfkHo+wzGGDKgKPuXxzvSjyEQuG3KWcGj6oCFPT6S d1Y+iGRdDED8fw+l86dtXgN6swFlXw7veorxOv++Rwiy+a3DG2AtEI0BqDI7TzleyVGw KmYWfXUOwTSy+u6PO86ipO0hMrqsN85lRB25wV2kXMczjJs2vPr6NuNZBQfDNF9pFBnG xcyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WxXjRL2I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id p10-20020a170902f08a00b001c3e500e6d4si3500876pla.344.2023.10.06.07.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 07:59:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WxXjRL2I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7A18781BC2E8; Fri, 6 Oct 2023 07:59:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232689AbjJFO7P (ORCPT + 99 others); Fri, 6 Oct 2023 10:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjJFO7O (ORCPT ); Fri, 6 Oct 2023 10:59:14 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11533D6 for ; Fri, 6 Oct 2023 07:59:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55E65C43215; Fri, 6 Oct 2023 14:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696604351; bh=jPD7LD0nZ0fW171kWWlLz2f5hqXrbFlaGKo9bdgLi7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WxXjRL2IJEL9IaVcm+SLzhrboLT09GWXXrcbWuGPGFW5AlZ954cKwuNyNwaoKKq18 k7l0Ub8zrNbe+a5eUx9qCyl0kU5H25lzN89kEcQ5CmyOqEXyiwOh1UkLopOZvQYCei FdwLJOERhDDdho140LyZ0jxtVn+UiwTdHNhzVcCg= Date: Fri, 6 Oct 2023 16:59:08 +0200 From: Greg KH To: Hardik Gajjar Cc: s.hauer@pengutronix.de, jonathanh@nvidia.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_linyyuan@quicinc.com, paul@crapouillou.net, quic_eserrao@quicinc.com, erosca@de.adit-jv.com Subject: Re: [PATCH v2] usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach Message-ID: <2023100657-immovably-bungee-f3a6@gregkh> References: <20231006141231.7220-1-hgajjar@de.adit-jv.com> <20231006145332.8739-1-hgajjar@de.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006145332.8739-1-hgajjar@de.adit-jv.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 06 Oct 2023 07:59:22 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 04:53:32PM +0200, Hardik Gajjar wrote: > This patch replaces the usage of netif_stop_queue with netif_device_detach > in the u_ether driver. The netif_device_detach function not only stops all > tx queues by calling netif_tx_stop_all_queues but also marks the device as > removed by clearing the __LINK_STATE_PRESENT bit. > > This change helps notify user space about the disconnection of the device > more effectively, compared to netif_stop_queue, which only stops a single > transmit queue. > > Changes since version 1: > - Correct Singed-off user name and e-mail Nit, this goes below the --- line :(