Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp535024rdb; Fri, 6 Oct 2023 10:26:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEimxoQayQPUl4i2PBiYWdiUTpDOCadnMWsZTHueo+Oe6Y7i8Jnii036wkWk7L5CGci18SM X-Received: by 2002:a05:6358:7e07:b0:139:c75f:63eb with SMTP id o7-20020a0563587e0700b00139c75f63ebmr9493193rwm.21.1696613190616; Fri, 06 Oct 2023 10:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696613190; cv=none; d=google.com; s=arc-20160816; b=lryW0JM9KV7LLA36rEvXrxBX5jJHyy/whkDREQi5asJKvc6pFBCpyztTDjhbFOMtiA WAhVCVTPyqin82YnleSvHn3PiqJCtXoikVpGP07cS5XfVVqCtliraESPwOC+kiAxz5x9 /6CGAHAAK/xLsKElO02j9gD1rCW2kN0jabfNUqt02moBmKhI88adXFwKt6HceQsMxNhn ZxOSTwjLACF22utCkbDrJwvKEX1Hp04fKdaU6UBquyPbamePsnKtnUqTDir+HMKpJjTl e4Mnk2nrxEpzy5b3PBPhQ6NY0HDmU1d/uOjW4V5+pkn6QlZeDgnhnsXUw/FLfTxJsVqP Rm3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Rx67H5KTarmXEYEDYl/whfWf5psnvMF6kQlD25eZvhI=; fh=p0BoDCzo08UAXyoTy6ZJuFc7cFJtGqSvuyrSCcwOMbE=; b=o7q4npJayhVhGDSeehy53m0rNAAqJyWz8+2y7jS02iXtPWEmRW4FcKgryYnjDngWbm uF40BunyE8h7eCPFMmxKuz3wZ0CAFxsuWCbjH7QoIgRqUDDeILsKEL9b4DgPg6Ifg9rn +xqHVaDUc4uMsT2scgdYZwD31L/EeZ23UHQrFyZP5+C6xKnd5gdfV9RkkraBVBmXYM1p FNbboPtchj1i0pxLcWmCxy7aj9lkXig0b7a6ItuGAhawhGRJlQK3DJqyl9mgbeBtdrdO hexMqZY/LTEy9feABZxCGgStyhwPa7BQlpBaMsHdUDNFJrSHJGi8wxvhl5RPDYIyVuMY 1aiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gw6J0qq4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id 192-20020a6301c9000000b005891cd85963si3975132pgb.439.2023.10.06.10.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 10:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gw6J0qq4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4D316807DE32; Fri, 6 Oct 2023 10:25:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232766AbjJFRZA (ORCPT + 99 others); Fri, 6 Oct 2023 13:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232774AbjJFRY6 (ORCPT ); Fri, 6 Oct 2023 13:24:58 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51069BF; Fri, 6 Oct 2023 10:24:57 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4181f8d82b9so14604051cf.0; Fri, 06 Oct 2023 10:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696613096; x=1697217896; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rx67H5KTarmXEYEDYl/whfWf5psnvMF6kQlD25eZvhI=; b=gw6J0qq4D+G1D6PNZVVcQlbce3xcoeOlzDO7oYzwuo+R5LNlF01fPOPWAUENZgaHtP 6Cxp0KLSBaPApyAXUbgKqW/167TybyIZrjnLIFiCKcSGtmYOLmqfI43EV22tUPA2p/rH KalymaM4fOg7YNyOw+ILfXe2FLV/3aWRXg78l8ppxPV81tq3jJSI7x8tw+K/oZaMdGJv KJ+VXkAA79NeIOERWV7s7c8J7fmmoS6a5VuFgMTqmePkB1kT3GY3FgVsaT0TQhbVTBdV pl7Bpcynf3a49SFk4Dx1EYJB1iv+GbGWnvzQmBgSZy7XQFLLdyVexfVhoCmPJeaQq06u qBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696613096; x=1697217896; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rx67H5KTarmXEYEDYl/whfWf5psnvMF6kQlD25eZvhI=; b=vqTpVedAvsONhVMTf5mX+DKMl3H4MbcIYtHfUSvyw6rTFoJ+O/35E1bkU6bdnR2qQp 2+ClYuTjOOR9+5YoH537WV0JVAt+P+w9zeYmUyPzUAQFpolwl8YufIZPTNs+eNa2BX8g +YG6Emz3kkIMpgwRqRjjTvXnnwWZ69iKm7+IaseW1Yy5R/30gaqT4e0jv+bTHDzbJZw/ dA4e/JPNSvjJdEAadDMCCcE6IM7/vtZT4dYTjura08UxqzrSOOODhLPesB2a8Yv4mbRf bw7aLG95veYm15sXzjHAOgLZy3R/fujYW0OwDXtvV8xHw95Z2Aqp1oQZi2TcP6ny6J5Z arMw== X-Gm-Message-State: AOJu0YymZeC0WkGKRv7vDL7i7cJNDOEDeD50LhdHjkNJzkqjA6l4pRBA iVYeKitSZ/F28z5jY2o/2AM= X-Received: by 2002:a05:622a:a:b0:417:a2f9:bba6 with SMTP id x10-20020a05622a000a00b00417a2f9bba6mr9349030qtw.60.1696613096350; Fri, 06 Oct 2023 10:24:56 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id fj19-20020a05622a551300b0041abcc69050sm1145292qtb.95.2023.10.06.10.24.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 10:24:55 -0700 (PDT) Message-ID: <2818465e-e60e-4d6c-a7e3-828c28d8ab59@gmail.com> Date: Fri, 6 Oct 2023 10:24:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v1 1/1] net: dsa: microchip: Fix uninitialized var in ksz9477_acl_move_entries() Content-Language: en-US To: Oleksij Rempel , "David S. Miller" , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , "Russell King (Oracle)" Cc: Dan Carpenter , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Petr Machata , Lukasz Majewski References: <20231006115822.144152-1-o.rempel@pengutronix.de> From: Florian Fainelli In-Reply-To: <20231006115822.144152-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 10:25:09 -0700 (PDT) X-Spam-Level: ** On 10/6/23 04:58, Oleksij Rempel wrote: > Address an issue in ksz9477_acl_move_entries() where, in the scenario > (src_idx == dst_idx), ksz9477_validate_and_get_src_count() returns 0, > leading to usage of uninitialized src_count and dst_count variables, > which causes undesired behavior as it attempts to move ACL entries > around. > > Fixes: 002841be134e ("net: dsa: microchip: Add partial ACL support for ksz9477 switches") > Reported-by: Dan Carpenter > Suggested-by: Vladimir Oltean > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian