Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <b08ebaf3-6fe1-4677-a4d7-2c0e530153fa@intel.com>
Date:   Fri, 6 Oct 2023 10:53:05 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-10-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231003235430.1231238-10-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0ZNd2FCTytjZERydENsTkhMVlpWUk5iOXFJU2E0Mit1ZnhMM1VKYS8xS0Nl?=
 =?utf-8?B?WmQwanovZWFCQ0kvcTNmSXpxM2tYZlJyY1V6TEN5WVZnRllYOFlSK05OT29l?=
 =?utf-8?B?a3RiMGFmQlRFVG4weHV6ZTVlVi9ZR0FuWDgva3V6N0hVMkJyd0FHc3NXZjFO?=
 =?utf-8?B?MU56WGV6ZTBGUW9oU3ZwR2hPWmVFV1orRzJnK0RTVUYwK1VORVJYd25XMncy?=
 =?utf-8?B?Q01aK2dudUhZRElHWEJ5TGp4cnl4Y0ZKbHBGMGdYTjNGYXI2VUx6ZnA0QTNw?=
 =?utf-8?B?VnZlTVpKWmZpeDFSQVNWVVppTHZyVDhqVGJVcHFKaVZaY2dvWDhHQS92Z2hV?=
 =?utf-8?B?KzVKVkpBU0pHTUpyQUgzM1dmWHJHejZEdjAzaGFUUGhCem9TcVBPaTNKSCtZ?=
 =?utf-8?B?N1VUN2pkVGs1U2txaG04cC9nRmhqY0ZrbkZkdDRnRWpmWUlWOTZyY01pcFhX?=
 =?utf-8?B?L2U1VHRiUVhVMnRPdE5ONkRlaWs3MDF3OUNhY0c5ekIzcjZ3SE4ySWFLazJZ?=
 =?utf-8?B?R2hFU0lPQ3AyZ2J1ckFXM2JENkNTWTMzbjZGM2pWVFB1cGdrTENON1p3NzFX?=
 =?utf-8?B?Y0VvVGVIZ1EwVUIrcEF3U1hqZzVSejNmYktRZHYreW14TUdTL0hmZlpuaDhi?=
 =?utf-8?B?NW5oMzBTaGUyNVB2aUhYUDNCd1NsYTM2V3pFQzRnc1NGeUY5Ykl1VVJwZmtN?=
 =?utf-8?B?WEN4L3BnVnVRdm5GQnJmNTJPd2UyQks2UWZyNjFrcGRtd0UwRFZyN3U0NnhG?=
 =?utf-8?B?WVNKZ3FTaWJZNjE1ZmJyQmh0WU9pMHVJWUNHeHBUVWxDTWtmSjlyOHZZU3ZN?=
 =?utf-8?B?aUlKbEFuY2QyK1NUdGlma2g5enVpRCtaWTRtbGxaK3UwTTRqdjQ2d2lwdmZn?=
 =?utf-8?B?eDU0aTRYdTREOHVndHRnbTJiVnJ5MjJHM1FlL002ZWF2blpDN0dUVWpsTC9D?=
 =?utf-8?B?TkU4aERMWlJ1Z1AyVm9Ea3ZNQzh2Mld6aFZCbTZRMmNqSjg2UEdnM3U4SlUv?=
 =?utf-8?B?N3hwQmNGdjZ3eEZhQWcveFFmcmIySkF4d2dtNkhwQUJ4aDBMK0hvUXpwSGRG?=
 =?utf-8?B?ZEl3OGh3SGpCeE03NDhyQXVnbUpTbXJJN1labjBvMzlHMHVQeStBYWVXOEpC?=
 =?utf-8?B?bTlvZlNGeUorZjZZZThEcXlwcDFDMDRtNTh5TWhxRmpIc3VXNWJKSVUyM3dn?=
 =?utf-8?B?RERRbGRJL2NZU3VmejdweXl6cHVORGhhRG43bGJ5MHNmZ1NtRjVaRnlCS1lt?=
 =?utf-8?B?ZVhuRE9QeFZTNzg0eW5rVXJqNXVKbWFBaDRtSFN4ZDZlbkg0cEREVTZpSXVL?=
 =?utf-8?B?RHhmM0tiSGlOYkZMakIwNzR3YmlTUmxzb2xLb1RPLzgwV2tuN0xaY1ZIem9o?=
 =?utf-8?B?WDBLQ2tIeHp5R241b2dxNkQvdjhaYmxxL0xZaFozNW8zL21CZ2srY0FMSXV1?=
 =?utf-8?B?alFTbzJvNTU1M2FMdnovRUR2ZTNtMVJHNFhrT29abWFpSEVVZ1lRd0o1UGs5?=
 =?utf-8?B?ZkRDWTZTV3BIVXFIcWtPNDhaL05BSHp2NTVReUdSdlZhOXRSa29saExGSnVX?=
 =?utf-8?B?WDQvakNsNjByTVBGSkllYzR3elk1L0ljVkI4a2dFdFAzODRWQ2laUThmblV4?=
 =?utf-8?B?a0hhQXpkYkVHc1JFa09ZbWlnTUhSOElLQ2dSVjF1ZWFMdUNzdEIrdmhLNmhw?=
 =?utf-8?B?a25QeDM4YlZEQk9vTWljRElCaWpsMVdpRmxQY1VzbURqdEpPWDdSK3FUV3BX?=
 =?utf-8?B?dWNEY1FhMXR1MzJxbDZEbGtmM0s0QWM5QU1zOEZFRnA4K0RkVHdXQnpQWGFF?=
 =?utf-8?B?bnptM3FyVUJYTHV3L0ZKUkJweG1HZmJ5RUJjbjZGTmpJenBqbnhPRGd3c1A1?=
 =?utf-8?B?d3hZZ256L3BUM1ZoZzVhdVhWdzhqQ2VLMXp6NlMycFpOSzJSNEpTZTN5eUFU?=
 =?utf-8?B?OUYrRkZ2WkVLd3h0RGVPc3l2U0xJSEZGWlovRUd0WWpBcmtyN3NBd2REYWtj?=
 =?utf-8?B?Q1laZnAwMnhpZnNWZnhLd21oR01kUzdpQmlmYlVtN0kzQ2x5clhkK1dDeHEr?=
 =?utf-8?B?V250TzJxRVNNSGg3VDZWbVR1Z3BQTzJvVWxwNG11TUt3b3lsOW9DdGMvbSsr?=
 =?utf-8?B?My9zMGV6VVRiTi9pUm9oRFBsVVdHQ3pjYmt0MTMya1Q3eEdic2tXeUl3a2Nk?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0959f965-0331-483b-273a-08dbc6951a46
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 17:53:10.0176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4c8VntecsDgrHw80LHCY6G/vxXoPjkLx8qRjaFBsvmK+H3+53IqrwZxj1lyzv1DMBM174pLyJIdmXfTKpGCfS7Gfj1LCFZu9MEIwa78/gc0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8116
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 06 Oct 2023 10:56:06 -0700 (PDT)
X-Spam-Level: **

Hi Babu,

On 10/3/2023 4:54 PM, Babu Moger wrote:
> Files unique to monitoring groups have the RFTYPE_MON flag. When a new
> monitoring group is created the resctrl files with flags RFTYPE_BASE
> (files common to all resource groups) and RFTYPE_MON (files unique to
> monitoring groups) are created to support interacting with the new
> monitoring group.
> 
> A resource group can support both monitoring and control, also termed
> a CTRL_MON resource group. CTRL_MON groups should get both monitoring
> and control resctrl files but that is not the case. Only the
> RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups.
> This is not a problem because there are no monitoring specific files
> with the RFTYPE_MON flag associated with resource groups.
> 
> A later patch introduces the first monitoring specific (RFTYPE_MON)
> file for resource groups. Ensure that files with the RFTYPE_MON
> flag are created for CTRL_MON groups.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Reviewed-by: Peter Newman <peternewman@google.com>
> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

I believe this series is ready for inclusion. There is a conflict between
this series and Maciej's non-contiguous work [1] that is also ready for
inclusion. We could wait for outcome of next level review to determine
who will need to rebase. It may help to provide a snippet of the conflict
resolution in anticipation of Maciej's series being merged first (I will
propose the same to Maciej for the scenario of this work merged first).

Reinette

[1] https://lore.kernel.org/lkml/cover.1696493034.git.maciej.wieczor-retman@intel.com/