Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp562186rdb; Fri, 6 Oct 2023 11:18:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG22eqwJhzlB357sqXNAZHof88XxK4Sb5bXOFlDt2H0jhQp5U99Z/IkdGbl1F8y7soAOnyW X-Received: by 2002:a9d:7751:0:b0:6b9:ba85:a5fa with SMTP id t17-20020a9d7751000000b006b9ba85a5famr10041723otl.5.1696616280708; Fri, 06 Oct 2023 11:18:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696616280; cv=none; d=google.com; s=arc-20160816; b=wL3q7LqEqKfLjHPcBkzvtWdOU9gYLl0xO5ZLuQdxaWMSNp5K3v9r1czLWCyu6EH/Ey 2fUOpBFiLr7ZmkfEXZcQyLv1AxWh5olpOdyPUJfR5sBwPN4s6+skjucF2qh4YgqtwA7w WH9whWXrm4hjAhdviawXLHQO9J4x8N8edRBcGy0dPAxzpQrHcSeVa2RTqeY+pmlBIqOr 3HX5gGuVBFNUrLufVEA81oFQxkDEPws0AP1GM2Ch13EqZZJlLthn2zlpnaXDCQSOIduK B+Mtu9frLcSnAX5xLtqBAWtk5piTJ5IylbxjfwGo6A/HynaU/FzbMNDF/06+IDA8reTn iv1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=N1kuvdFzr7bMP1IyvjWvGqylFglQ5IsaUBjLbA0R1mM=; fh=tqNa76lxC6BeGoAJFTsKuA+yO32xCVS+nvIdHL0POLo=; b=sy8NIjh924ccCb1Y5sMriUs3q6VgKnRK6PUX+rtKCeatdp+BKSReEzNtxQ2mHyAKnX sI+ns6TqOEKAOBVhTirlf6jrIBjH0695xKQZUIltQym7nszjPyOqudro0/eikA6uqOu1 IZrzsCJQb8vzkIsfc0jyPvcbPYLJpkUkiMr61tpQKM74lrwzPI2Q3ZpldW4dJYcHiwrZ TEivbae9moB4SCPkFaRU15d06mvs3Ce9n7Dc+immLSMHAFcmSaWGyVTQ4pooWZd5nVsV ChE+lxhTn6FmXObsVaQp/6/Y+S0+5RK4zYXaGTvoD7/716mVHkyEn0nDPAYEexcfzccp XL+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=a4xmoO4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id q10-20020a635c0a000000b0055b640a6b3csi4136694pgb.884.2023.10.06.11.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 11:18:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=a4xmoO4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8DEEA809C1B1; Fri, 6 Oct 2023 11:17:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233202AbjJFSRr (ORCPT + 99 others); Fri, 6 Oct 2023 14:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233182AbjJFSRq (ORCPT ); Fri, 6 Oct 2023 14:17:46 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7495C6 for ; Fri, 6 Oct 2023 11:17:44 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-59e77e4f707so30210677b3.0 for ; Fri, 06 Oct 2023 11:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696616264; x=1697221064; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N1kuvdFzr7bMP1IyvjWvGqylFglQ5IsaUBjLbA0R1mM=; b=a4xmoO4GZ73ejvQkrJkOg3duyXBftjR8hPVC6flQ8283gwkdjBcZkLyICnz8Ym9dAp KCm5eLekK93VLj3hl4JdFBMIm0+sCzLDUNVC2uMdn9pSL7/MQQPSMdXAf/syfUFnelEU kVFWZnAib2iyYsijgpmPxEJjnuQ2BIIILo1wQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696616264; x=1697221064; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N1kuvdFzr7bMP1IyvjWvGqylFglQ5IsaUBjLbA0R1mM=; b=cRYE67+wPxbHJA/nE6AitmdzB/tvlyONbJ8YkiHrpSPOTIjo+LijBzDbqGZmn6ZKln CHBBEX/yp98XZP2LNfpyETCTnbuXyoYrjZJQIlOumAJ3PsYTl8nnce+SUFZ4xerWcRPf K6yrFa3SX/saUBXdxRtsSiybQ3dsf2R8vx2aq94Nza18v+NdCRDAzX9CJgysDeOAKocW llXxRDYXEOcl9Zhgu9lzmvvt1dn/pJNgEZBHi+24s2Gi1x0sQQxfzKBnTLeglDGNX4MW Dc5u0/WSszqsCDpbc+sVg6HVgG35lTYHxHQdMd2MhwdNtzA6j2hLS0rMBd0zEc5K9JxC x5iA== X-Gm-Message-State: AOJu0YwqqFXaF3c0JanOshMZC9uOjnKpLD/CEdJRaUPAey5r0ortazJt WeeJ1/HeRXtas+Dc8/joHYFrB7SvqyRLIeaurO8Hgg== X-Received: by 2002:a81:6d47:0:b0:59f:81c4:631a with SMTP id i68-20020a816d47000000b0059f81c4631amr11073507ywc.24.1696616263670; Fri, 06 Oct 2023 11:17:43 -0700 (PDT) MIME-Version: 1.0 References: <20230926194242.2732127-1-sjg@chromium.org> <20230926194242.2732127-2-sjg@chromium.org> In-Reply-To: From: Simon Glass Date: Fri, 6 Oct 2023 12:17:23 -0600 Message-ID: Subject: Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages To: Ard Biesheuvel Cc: devicetree@vger.kernel.org, Mark Rutland , Rob Herring , Lean Sheng Tan , lkml , Dhaval Sharma , Maximilian Brune , Yunhui Cui , Guo Dong , Tom Rini , ron minnich , Gua Guo , Chiu Chasel , linux-acpi@vger.kernel.org, U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 06 Oct 2023 11:17:57 -0700 (PDT) X-Spam-Level: ** Hi Ard, On Fri, 6 Oct 2023 at 11:33, Ard Biesheuvel wrote: > > On Mon, 2 Oct 2023 at 19:54, Simon Glass wrote: > > > > Hi Rob, > > > > On Tue, 26 Sept 2023 at 13:42, Simon Glass wrote: > > > > > > It is common to split firmware into 'Platform Init', which does the > > > initial hardware setup and a "Payload" which selects the OS to be booted. > > > Thus an handover interface is required between these two pieces. > > > > > > Where UEFI boot-time services are not available, but UEFI firmware is > > > present on either side of this interface, information about memory usage > > > and attributes must be presented to the "Payload" in some form. > > > > > > This aims to provide an small schema addition for the memory mapping > > > needed to keep these two pieces working together well. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > Changes in v7: > > > - Rename acpi-reclaim to acpi > > > - Drop individual mention of when memory can be reclaimed > > > - Rewrite the item descriptions > > > - Add back the UEFI text (with trepidation) > > > > I am again checking on this series. Can it be applied, please? > > > > Apologies for the delay in response. I have been away. OK, I hope you had a nice trip. > > > > > > > > > Changes in v6: > > > - Drop mention of UEFI > > > - Use compatible strings instead of node names > > > > > > Changes in v5: > > > - Drop the memory-map node (should have done that in v4) > > > - Tidy up schema a bit > > > > > > Changes in v4: > > > - Make use of the reserved-memory node instead of creating a new one > > > > > > Changes in v3: > > > - Reword commit message again > > > - cc a lot more people, from the FFI patch > > > - Split out the attributes into the /memory nodes > > > > > > Changes in v2: > > > - Reword commit message > > > > > > .../reserved-memory/common-reserved.yaml | 71 +++++++++++++++++++ > > > 1 file changed, 71 insertions(+) > > > create mode 100644 dtschema/schemas/reserved-memory/common-reserved.yaml > > > > > > diff --git a/dtschema/schemas/reserved-memory/common-reserved.yaml b/dtschema/schemas/reserved-memory/common-reserved.yaml > > > new file mode 100644 > > > index 0000000..f7fbdfd > > > --- /dev/null > > > +++ b/dtschema/schemas/reserved-memory/common-reserved.yaml > > > @@ -0,0 +1,71 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/reserved-memory/common-reserved.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Common memory reservations > > > + > > > +description: | > > > + Specifies that the reserved memory region can be used for the purpose > > > + indicated by its compatible string. > > > + > > > + Clients may reuse this reserved memory if they understand what it is for, > > > + subject to the notes below. > > > + > > > +maintainers: > > > + - Simon Glass > > > + > > > +allOf: > > > + - $ref: reserved-memory.yaml > > > + > > > +properties: > > > + compatible: > > > + description: | > > > + This describes some common memory reservations, with the compatible > > > + string indicating what it is used for: > > > + > > > + acpi: Advanced Configuration and Power Interface (ACPI) tables > > > + acpi-nvs: ACPI Non-Volatile-Sleeping Memory (NVS). This is reserved by > > > + the firmware for its use and is required to be saved and restored > > > + across an NVS sleep > > > + boot-code: Contains code used for booting which is not needed by the OS > > > + boot-code: Contains data used for booting which is not needed by the OS > > > + runtime-code: Contains code used for interacting with the system when > > > + running the OS > > > + runtime-data: Contains data used for interacting with the system when > > > + running the OS > > > + > > > + enum: > > > + - acpi > > > + - acpi-nvs > > > + - boot-code > > > + - boot-data > > > + - runtime-code > > > + - runtime-data > > > + > > As I mentioned a few times already, I don't think these compatibles > should be introduced here. > > A reserved region has a specific purpose, and the compatible should be > more descriptive than the enum above. If the consumer does not > understand this purpose, it should simply treat the memory as reserved > and not touch it. Alternatively, these regions can be referenced from > other DT nodes using phandles if needed. We still need some description of what these regions are used for, so that the payload can use the correct regions. I do not have any other solution to this problem. We are in v7 at present. At least explain where you want the compatible strings to be introduced. What sort of extra detail are you looking for? Please be specific and preferably add some suggestions so I can close this out ASAP. > > > > > + reg: > > > + description: region of memory that is reserved for the purpose indicated > > > + by the compatible string. > > > + > > > +required: > > > + - reg > > > + > > > +unevaluatedProperties: false > > > + > > > +examples: > > > + - | > > > + reserved-memory { > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + > > > + reserved@12340000 { > > > + compatible = "boot-code"; > > > + reg = <0x12340000 0x00800000>; > > > + }; > > > + > > > + reserved@43210000 { > > > + compatible = "boot-data"; > > > + reg = <0x43210000 0x00800000>; > > > + }; > > > + }; > > > -- > > > 2.42.0.515.g380fc7ccd1-goog Regards, Simon