Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "git (AMD-Xilinx)" <git@amd.com>,
        Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
Subject: RE: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
 dmaengine support
Thread-Topic: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
 dmaengine support
Thread-Index: AQHZ8XmgCUAYsOlDC0Cdo8yNtnUiNLA6Iz4AgAL99wA=
Date:   Fri, 6 Oct 2023 18:24:17 +0000
Message-ID: <MN0PR12MB5953CC0DAA4E8BA1C3B9CC76B7C9A@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com>
        <1695843151-1919509-3-git-send-email-radhey.shyam.pandey@amd.com>
 <20231004134106.7779c29c@kernel.org>
In-Reply-To: <20231004134106.7779c29c@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zRERp1Y7yI0aDmwTITFl2k/DrjhjkRsajRXrYWutl9+sz+HljhRMX6QVT4FB?=
 =?us-ascii?Q?a0oqa2WjY7QPMkcnTfDjp57YuAQgIWoVSZCHF5karTxd//qgL8r4lH3QAswQ?=
 =?us-ascii?Q?hRoC4QFqGp3Whx2oghT9Mdn1uwu+UGNQpDnHNcy/YWP8gb+z1BCfx2I5oqen?=
 =?us-ascii?Q?vf8XlynJtgF9i+Kxw0G+z5EXBHLuMQimdpCC7OlcgqOIn87ki3R/x60SRYLc?=
 =?us-ascii?Q?EPP12iOz0MsDqyXwwtHiX12y34Ot0YN52ysUx66v1+sabiTOVFTjvzmNhYK1?=
 =?us-ascii?Q?LEOSZJ396MXlGAQOCMVjlsSNuyD4mgNqyapwfgzU+N+KCA7FeOQjDl+IPnPm?=
 =?us-ascii?Q?hIE9jhIzlgt6HCSRVluboCEVrAnD4toRzYDV265Cs8G8UdM7DgJPHEfj+IjG?=
 =?us-ascii?Q?pYknyVckX4bPT5yO+Pfg255VaI+HLkKRe4gWReRMFNb5GfuRr2c3IGHxEoxZ?=
 =?us-ascii?Q?a91FDkC0IBRJUzjcs7M0YfdndC4kBi6fhd1P2PNEadcU05rd35T5ocCLgC4Q?=
 =?us-ascii?Q?1xygHka5S9k1kIxDQSAy0jimyDVRA2DBD0cupinIbN8AkKgQfDbZ0+rmZyFW?=
 =?us-ascii?Q?aeE9/xDZditg5T24kFS1GlOHUOLlEqt4h8zHJ25PjxqG8lQSBvWIBQExvHtM?=
 =?us-ascii?Q?IjHTB2fL5N/MFLQnNrVf9Z0qj82tyiFS8i3l49/CaonAq3izbd16LnL+CHRV?=
 =?us-ascii?Q?Y7+LfePq/LLETtqoL+CQBCodQRMpCR+1EFiwjF+hM+pM/tdr10NwKcZhG2gd?=
 =?us-ascii?Q?tOoYhwYethCNmmoFUk9oUbl0FDE7jfYZLhYjQ3qz9cMEgpD7+fn/OrmmkIVg?=
 =?us-ascii?Q?mRbWtNPr8vEk/flVsCIPNUhrC10rTi+t1v2Gi/fOobQj6qgF3vO5cYSQBjJY?=
 =?us-ascii?Q?bHCd/csLZDeP1CVO0lFUiTH1Xd7I9lSiGn4hI49K3j1HXh+Mo1Ml8rO5WQdd?=
 =?us-ascii?Q?QtHWtOTjn9CkwUz0umImkCyFhNW5b5uAPRdo5u30Do6X1NhC+xNczNA18NWg?=
 =?us-ascii?Q?wr0fJxmvSxpnaUSagPVk4ZlgsDdr0GiQ6jzXImtb5K3V+aCWSW0qQK0/npjN?=
 =?us-ascii?Q?OUGfUoAJ096EvP4OtbleHUbFmgov+vMEPlseXaB73TtGFisxep1x2lG8ZcMR?=
 =?us-ascii?Q?NEILK3qddaO6JJxLEfnHSZJj7SwgDF6VPr/R7uDsbRPK3MUy84NM4uwqquZ7?=
 =?us-ascii?Q?m6FkvhqThcLSmReCIyqxT+a7dZ8T7XMYg0H9bBp33eknCcMT1h4oPe59DDRh?=
 =?us-ascii?Q?gnADumz6FYuVvcXipBmEp+6/V+1N7cUKuNCIdBFMUDEfPWXap8ZVa2tEz4TP?=
 =?us-ascii?Q?C1DnzDqdzdNjFwTSEqtdltggzg1DoEOiP0+Q2n8M3P9uqdsxeDPZ5gpO7H4W?=
 =?us-ascii?Q?viSgGH6+6/BH8hA2OminRPn9Y0RddyWPZymyz7T+iL+9W+iOliCRsDj/F5N4?=
 =?us-ascii?Q?CLk5A6Hiq/C8zOiWgCbb6EHVjGHYML5V2Vm0xot8QTUdXRPVRu8wZ2AswGfM?=
 =?us-ascii?Q?OnUMgPx/7Q1M9PssPLcRgs8d5xxdL4prSoSL2pHu5AtAb74QXOKx/N9c7ONY?=
 =?us-ascii?Q?adH61LFFkhPSyoIjT4w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2afd6073-4f5d-4011-615c-08dbc69973c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 18:24:17.7737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QvsANzeX9qAT4UVlWLrlwBfyPL28hy++5kelqjFEjx542EWb/fsVqSdhnlqun53R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8641
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 11:24:37 -0700 (PDT)
X-Spam-Level: **

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, October 5, 2023 2:11 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> conor+dt@kernel.org; Simek, Michal <michal.simek@amd.com>;
> linux@armlinux.org.uk; f.fainelli@gmail.com; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; git (AMD-Xilinx) <git@amd.com>; Sarath Babu
> Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
> Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes fo=
r
> dmaengine support
>=20
> On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:
> >   */
> > -static int axienet_open(struct net_device *ndev)
> > +
>=20
> nit: spurious new line
>=20
> > +static inline int axienet_init_legacy_dma(struct net_device *ndev)
>=20
> nit: no need for the inline, it has one caller and isn't on the fast path
Thanks, will fix both in next version.