Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp624624rdb; Fri, 6 Oct 2023 13:32:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLFxeJjhBRkl8NnxDqzHwg9m6XGKySIF3iR48M1STm0oTOURDnSUCjoF36+T4FEkb9nQPl X-Received: by 2002:a05:6a20:8f0a:b0:15d:53ad:22fe with SMTP id b10-20020a056a208f0a00b0015d53ad22femr8030314pzk.3.1696624329718; Fri, 06 Oct 2023 13:32:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696624329; cv=none; d=google.com; s=arc-20160816; b=Jck0iijW98iQ6SdVBUsDeolfUht1kWR6xXfnUo7rJMyrt9HE8hgP0ja1bzXs8brgvQ CsYrPfJ8A6g+daoJ7ohobOQTUwqT1rJIzinvpLo2bCD8anQ9jl4Xl1Qkh3Gcoy/FKP0q EqtE9k4a5CQPsExNHFFItoVahaasIh+bKd4gNTeoEuS0lU2NfTa/EJ1zxzUvd7KXGQT8 yHLlXws8b18PIKCyjELcgO+GgIQeDr+xhwJCipmFcIIcyvDfse4Rr9MJcDGs+myvOyqZ uxUht2oMmR9EefpfVGkYB3nkt7qrPi/rnmndh/w5vHIDEBb8b2SqMkkPWORQZAJSnHVc nUdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lD7A9KKMFgGKUEkwmUnkIjBflNgSwBTMpzj76cCd5gY=; fh=4V/qK/gupyips+5MiOvnl+k0n/b53gX3U+/awBrA61o=; b=EqzXAtleEN3VPdr3VhxC9ZoD3oNSlHrMAUo6ipEf/vV6yGKxa2eEceOQwkngI3dPOG Ms1KSBVyfslWbTQiijmRA4EZ/usnV+aGfxD0yn7wR/nRHtdmfKTffT+bI8BpX9aCKcl3 42bL7S5dheFpoXYRMPcWAOqkBUP7I1YnuDIgPBanuHU8ffFoVWqvktMI44nsqY5ct2i3 /CjtLZjQjyZwok9rKLluBvzpq6c2hWgpkaNkrpJ1fftgmo+A9/2YNHMt3/13DbPRkXgu eUpp9V6G4ntnNI6vkCyQyC+HbHeJ1a7bff7e6SGpRrHTS2GurSK/HorfB0jPv566szgb ZY2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=o2d03Ah7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id j191-20020a638bc8000000b0058986c3dc2fsi2563102pge.117.2023.10.06.13.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:32:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=o2d03Ah7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B151580B19D9; Fri, 6 Oct 2023 13:32:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233527AbjJFUbv (ORCPT + 99 others); Fri, 6 Oct 2023 16:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233521AbjJFUbu (ORCPT ); Fri, 6 Oct 2023 16:31:50 -0400 Received: from mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8BBAC5 for ; Fri, 6 Oct 2023 13:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1696624306; bh=Y4jHqWVhg8UVkLv5fZyoADZGkDruWn4t1ImjwzaYqSU=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=o2d03Ah7JurwHjIFIbYZgleEMDCXs4WwJhDHNo5OVGZ/pFQiO3mYDlHqU23bnFPpr TGdg/OkROzt8n50zqwiEYkUn+yxfXyOsJ3MXBy33PPbTxzaT6qE6eBU967o3t7RBvR ZiwCior4gp1GPZJzndxHL0zrdCGzpH3tgKDkvmqQ= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 6 Oct 2023 22:31:46 +0200 (CEST) X-EA-Auth: UClDyyuJLMlcEtduCfdeslkp9xbtqk3b1bqHZBK3wuhDdmOuGG+L9YD7aXBERKrUuooUJCZYmnZ6PsfJkhUW2w== Date: Sat, 7 Oct 2023 02:01:43 +0530 From: Deepak R Varma To: linux-kernel@vger.kernel.org, rostedt@goodmis.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, ivan.orlov0322@gmail.com, skhan@linuxfoundation.org, Deepak R Varma Subject: Re: [PATCH] tracing: Fix minor typos in samples header Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 06 Oct 2023 13:32:07 -0700 (PDT) X-Spam-Level: *** On Fri, Sep 15, 2023 at 02:59:08AM +0530, Deepak R Varma wrote: > Following minor corrections in the comments section of the trace > events sample header file. > > - There are 6 parts of the TRACE_EVENT macro instead of 5 (name, > TP_PROTO, TP_ARGS, TP_STRUCT, TP_fast_assign, TP_printk). > > - The example variable for __field_struct type should be the > variable name instead of the variable. > > - Improve closing brace alignment to improve readability. > > Signed-off-by: Deepak R Varma > --- Hello, May I request a feedback/status of this patch proposal? Thank you, deepak. > samples/trace_events/trace-events-sample.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h > index 1c6b843b8c4e..551ecad212c8 100644 > --- a/samples/trace_events/trace-events-sample.h > +++ b/samples/trace_events/trace-events-sample.h > @@ -61,7 +61,7 @@ > #include > > /* > - * The TRACE_EVENT macro is broken up into 5 parts. > + * The TRACE_EVENT macro is broken up into 6 parts. > * > * name: name of the trace point. This is also how to enable the tracepoint. > * A function called trace_foo_bar() will be created. > @@ -93,7 +93,7 @@ > * > * __field_struct(struct bar, foo) > * > - * __entry->bar.x = y; > + * __entry->foo.x = y; > > * __array: There are three fields (type, name, size). The type is the > * type of elements in the array, the name is the name of the array. > @@ -410,7 +410,7 @@ TRACE_EVENT_CONDITION(foo_bar_with_cond, > > TP_STRUCT__entry( > __string( foo, foo ) > - __field( int, bar ) > + __field( int, bar ) > ), > > TP_fast_assign( > -- > 2.39.2 >