Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp628043rdb; Fri, 6 Oct 2023 13:40:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjgkqjUdA7/swXGfS48oC0LG0vSUclnizTQI30g0PvxjSHF7zQ4JLcbhGHCQK+alts0bvi X-Received: by 2002:a17:903:192:b0:1c8:9bc6:2a09 with SMTP id z18-20020a170903019200b001c89bc62a09mr89789plg.15.1696624805117; Fri, 06 Oct 2023 13:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696624805; cv=none; d=google.com; s=arc-20160816; b=itFPEMbphRIlX2pgm2KF47wq4OCtDaUjr1omfqxbuoB8BvA+aMRn4xPyWxTHrd5zlq RCt/X8QayrSY2m9ysGaVDfo96nVibbuBF4DPFuqgR90UJ2KTWKWoomjjzF2WE9+G0fSk Fuu5BvbOryFF3j2HdPDXcN4+0mE54X2VbMUSKE8e2KkRatFGCPDB9rEGvrOFqiNkakhI i7+pcqVKoDTbZp5CIuQxsm3A2oDHs/9SOKVt/9iW0DEX6yUTD2/61iBX5pFX9gGv5iBt Qgmw0t5SWuYUb6hplR1jOr7uPbwaFq/xIFQhQdCrSrNNTbYctxPx1H0Vhtl+4x2B9Avd 2W/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fCCsvCjoztAYuiGh0Xey9xgcOmDlkIVfrEdnFUpQWQo=; fh=lTa0CMTDEgt51p/QEq5IRgI47SkBuriTgrMuHXcg5WQ=; b=A9oEQzyHyTDqSAZNDQowbWxp+FraCg2RvWiFOBT3ejfneC4/r4y7xmhHsW0YcH2FKh oqCDUuSoqVFadwPl9Pv+S6Y/jDSXcFPsl0NOSZUgGjtgCd112trR/3f5se7HktsZoioX sh+47a8yJ1RsLR+QkV5OZwPzrA+qFSPGkT6OqWZ1HeugINk3+m7wSLM/AqqOtmdD0P+Y WOaCZyibCk3FnIOaBqU9WlUEEuRc3g+WT7e6jsrbMFCQ7FqInN1sxwkBgKE98kVZpL8H r+uHn1sgt3g8Mxg7/hjWryc1KyzhTs+7+TwfLAgChK/ERsE7tTHpEEKIbnVwxl/cKw8Q wbXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qmMMSAtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z17-20020a1709028f9100b001c77e00809csi2565364plo.453.2023.10.06.13.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qmMMSAtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B3F9B80A0DC6; Fri, 6 Oct 2023 13:40:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233530AbjJFUjz (ORCPT + 99 others); Fri, 6 Oct 2023 16:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233483AbjJFUjy (ORCPT ); Fri, 6 Oct 2023 16:39:54 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0AF1CF for ; Fri, 6 Oct 2023 13:39:52 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5a2379a8b69so31007217b3.2 for ; Fri, 06 Oct 2023 13:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696624792; x=1697229592; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fCCsvCjoztAYuiGh0Xey9xgcOmDlkIVfrEdnFUpQWQo=; b=qmMMSAtMV0KLM9RtwJ1oPScNfXITRyUkLad/AhjuEweUNldoN0AJeWyNTstvXzmeQ8 gPagpsAknageqJ2nJkzj1ta1fJ0XCstDYqFU45yFywpi4tbZ9PIxxmiXc/JGDlzuoCCY PGYi3ppvhtoA1qOCMTA9FCqIf/deMf3VYK0t9K61OJIACuquQmKYrxD3lnzwrG2ohtk/ Pw95MIx+DEwBJYHWkm+2yVyA9K84i4zSAu8wFowL3uJFmi5G+cgf7UengCnZeg06OmHC J/v33EpEEpX/CfrOF5KDjxdJs3ik4LGPL6KER0wrk3d2Zaa8I88NSs9sOf0LQy0HuEJC ViFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696624792; x=1697229592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fCCsvCjoztAYuiGh0Xey9xgcOmDlkIVfrEdnFUpQWQo=; b=RbCQ63K6yNZq/8ZvDY3SGGB7YunJ1seyCJGBmLo1qyx6Na5eOnlnam8hKqfpz35nsY sc1FSH8UEkCCLGU3bhIU7orkvwtN9AZnx2s/fLlMjr99Uvlxjt9oWVWRxC9483mNOnQQ 7rhDikBXldHozt/frnNM2AMAVYJF8+TeOJ1I70EgpgfYNAQnunJ+oHYBGE8atq2QJJbr QTrc9c+neuQwJkMRH+rI5OotwEzqPThmNg0O9MY3uWTg1IxbANmYcwBZDLjdzOQqrGhI hcadtTMN52IC7Utn3xuwLjxwYj3eQExjxyjLZ6C+i+yRgNObum6QjuDFeJ86+pTolzBA 5CBA== X-Gm-Message-State: AOJu0YynNgvJSBWpsytiwkVkYi+qRlr/bS2hc91eaBNEfGCTbuRKJmZP RsRRZ+pIeSDVVnc1NhTAtRCrS7j1PwQFUur5lTXgON10b4XsrYcR X-Received: by 2002:a81:7cc5:0:b0:599:b59f:5280 with SMTP id x188-20020a817cc5000000b00599b59f5280mr9869580ywc.28.1696624792113; Fri, 06 Oct 2023 13:39:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Fri, 6 Oct 2023 22:39:40 +0200 Message-ID: Subject: Re: [PATCH] maengine: ste_dma40: Fix PM disable depth imbalance in d40_probe To: Zhang Shurong Cc: vkoul@kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 06 Oct 2023 13:40:02 -0700 (PDT) X-Spam-Level: ** On Thu, Oct 5, 2023 at 4:28=E2=80=AFPM Zhang Shurong wrote: > The pm_runtime_enable will increase power disable depth. Thus > a pairing decrement is needed on the error handling path to > keep it balanced according to context. > We fix it by calling pm_runtime_disable when error returns. > > Signed-off-by: Zhang Shurong Looks correct, Reviewed-by: Linus Walleij Yours, Linus Walleij