Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <c5700cca-1764-4094-b927-fe6f61ee101a@intel.com>
Date:   Fri, 6 Oct 2023 14:01:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-10-babu.moger@amd.com>
 <b08ebaf3-6fe1-4677-a4d7-2c0e530153fa@intel.com>
 <76eb259e-f2ae-b41b-9501-40c9a99e2433@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <76eb259e-f2ae-b41b-9501-40c9a99e2433@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bi9GeWVwQzNCTlAzbytYeTcvb04yaE9RWXVaaHFJUm1GcUY1RkhVUWdtcG16?=
 =?utf-8?B?K1NUYzdQSEpHcFlyNGNJbERJdndLdW1qa1J4VTBVdm00a3dtZVgvY3d3K3k0?=
 =?utf-8?B?WGZOKzM1VHp2eDdaOFJvMTczOCsrTHA5MGM1YUIzQmY5a2dZUGI4KzVhRG1E?=
 =?utf-8?B?MDFwN0pnZ0ZUbDYvbzZPd1ZFUFQ2SThhc0VxekJBL2hHL0VrUllUV0ZkQXVn?=
 =?utf-8?B?TUxFQUEydnFXT2lQYmE0RHA5WEJGRHI1Mm1aanJxeENRMDB4YTRzd3hxRlVm?=
 =?utf-8?B?OWl3VXlPYmcxNlFTbk1GVk5hT3RFS3lDbU9BZVU3SitoakZGU3RyajlwK3BE?=
 =?utf-8?B?dk5zeHh2QjRXMW41ZG9xNmp5Tm1nTzViR0g4bWhwL3VPTDNsdFYyWktyTUdS?=
 =?utf-8?B?RW1rMWhZMURNcTBKVEF1OGdNenNRSjA1RlpydW5OVDA0akpvTk92aS9lUWoy?=
 =?utf-8?B?OE1tL2VLMlRvdHY4RjV2UTNTYVVUVzNhdGh3eG5Oamtxa1BHOXFNMjdDa1dh?=
 =?utf-8?B?TEFDOSs0K0txcDVjbndldTUwWngzQ2dnTmtFK2M5SHpVbE95NGFnMWVVNFRv?=
 =?utf-8?B?YVY2TytTM0JNbllITjZwKzlTcjNZdVlpYlFBL0RBTVJub0pBZFNUVnJzcWFx?=
 =?utf-8?B?OHFIeEkwMHVqbHFIM2hVWnRVYmR2cEZOYmhwaGd3b2tDRFlUQkNuM3ZHVVRD?=
 =?utf-8?B?SGhRUDhyaGpOdTNuN2lEZGNtdkF6K1o0aEhvVmFYM0JpditoMlpvQlIxK1Q0?=
 =?utf-8?B?bVBPMnlYMjNvZS9sRVdEZVV5V0FBMnZheWNvcVErUjlpaCtwSUNaMkMwcUJL?=
 =?utf-8?B?Z0hnamprd3IxeGZ1dWdRZXhpbGoycU9qOU9qaWlQSk9oRUV4QTNKSjUvZExV?=
 =?utf-8?B?SnBaajZZbWZLbDEvbFBuSkdjaU1UYmdtK0xFa1ViTjdZeDAzQ1hpb1FRaEp5?=
 =?utf-8?B?ckkyZXVjMEdpbWFMVlJTbTN0Y2lNRnRXamJqK1BpS3NaNXphaEU0L3ZHNVdO?=
 =?utf-8?B?c2MzQ0l3MisxRHEwRWdjeW1uWUdMbFFTUDlCQTJRaS95R3VzYVhmWnZHQ0tH?=
 =?utf-8?B?dUlqNkVUTFhZY25vMVc4aGErNHp5RjM0dE1hT0FneUJlUkljZ0ZDQU9nYWV1?=
 =?utf-8?B?TStvME9mOGljSzJsOEJwYXJGamVCby9INnB2Rm9SRHBUbFhDTnd4S0NWeDEv?=
 =?utf-8?B?N3ZhZTJmSzFJazVsRWhqV01ndGhLaU1adFh3L2UrQkhTbXM2bjR0TUNpbkhU?=
 =?utf-8?B?WkcyL0pOY1M2dmo0OEMrMEZPS0R2ZG80WDdyL1ErWTRYYTNDdG1pMjhzS1JH?=
 =?utf-8?B?RktoejVVNkRYVWo1RURkMkZoZUdSOFF5UXUvc1ZEZEcvU1c1ZnQ0MXc1amkx?=
 =?utf-8?B?eW4rUm9jY1Z2UmdnS3V2cDVadVM4dkN2MXE2ek5MQVNCSWtXZzlQMGhRczNJ?=
 =?utf-8?B?SzMxVDFjZThBczJVczE5VDczdXR4alJpMWtwRXgrd2J5NHFsWS9zZmhyRDg0?=
 =?utf-8?B?YUVCZEVUSWNPWGM2V0dudlpNTDN0Zm1hR2ROUlFTTGk4MTJ1eWJ0U1pIc2pt?=
 =?utf-8?B?RmRsNzlIcDRSbS9WaEpTeWlUdU4zYjJkajFiRk1neGVISUZ5OHFKbmZjR1Ay?=
 =?utf-8?B?aEExODRtb0hlb0RldlNXM3ptL1ZZZlVxbHgzM1JjSzlnOVRLR2NqZURVL1V6?=
 =?utf-8?B?aENJQS8xMlVabVRDQzNFSHRZMm16cWROWVhQNHRBQW1QQ010SDV6ajh5RWdh?=
 =?utf-8?B?ZHNGd1QzTmhNN3lhZ2xMZjZzSVpQUi9mNlN3REdRQkt0UnhyUVlSWVY2ei9v?=
 =?utf-8?B?b05xV1VrQjAvQmZRMHRRdW9kYWUzTFBONVdUSk5oSWw0UmJsR0c3Z004RDE3?=
 =?utf-8?B?c1djK2dhUVNFRnNTRElVN0FzWjQzUjY3NXorM25mVlRiakVYWUpwUFNEcGJ4?=
 =?utf-8?B?UE9DdnhyTE9Xd21HdWFic3BUaGJsdGxiL25rc2FlUW5peFFGU2l3SXA0SUJt?=
 =?utf-8?B?QUtyS2tDN1hZMm56cXdCQWI4N0dXbTVVT0h4Tm9nZzdhU2VhaDhJMjAwejA2?=
 =?utf-8?B?cFJVWHByNkZiVHlXS3JCL2JzRzBFSXd1bm9GWUxGSG9OcXVaQWk5Ky9zZmtO?=
 =?utf-8?B?Sit5WmszUDNlQy96d3Y0dmVKODdyaVRuUXNwWmRhUWhoSHhBZ005b3BaTERy?=
 =?utf-8?B?YkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1034e068-d702-4724-0b23-08dbc6af650a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 21:01:22.1649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8jiNzMw+kcEc5FuVzTm+BU+IlWUz9cNfuslemH1C6rDkLNA0/AHUeB5xPO5bpUFmMKlOosfDMvujp/9ds1bRrXoak9q34VhNi8jKhx0BAKo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6773
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 06 Oct 2023 14:01:44 -0700 (PDT)
X-Spam-Level: **

Hi Babu,

On 10/6/2023 1:49 PM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 10/6/2023 12:53 PM, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 10/3/2023 4:54 PM, Babu Moger wrote:
>>> Files unique to monitoring groups have the RFTYPE_MON flag. When a new
>>> monitoring group is created the resctrl files with flags RFTYPE_BASE
>>> (files common to all resource groups) and RFTYPE_MON (files unique to
>>> monitoring groups) are created to support interacting with the new
>>> monitoring group.
>>>
>>> A resource group can support both monitoring and control, also termed
>>> a CTRL_MON resource group. CTRL_MON groups should get both monitoring
>>> and control resctrl files but that is not the case. Only the
>>> RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups.
>>> This is not a problem because there are no monitoring specific files
>>> with the RFTYPE_MON flag associated with resource groups.
>>>
>>> A later patch introduces the first monitoring specific (RFTYPE_MON)
>>> file for resource groups. Ensure that files with the RFTYPE_MON
>>> flag are created for CTRL_MON groups.
>>>
>>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>>> Tested-by: Peter Newman <peternewman@google.com>
>>> Reviewed-by: Peter Newman <peternewman@google.com>
>>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>>> ---
>> Thank you.
>>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>>
>> I believe this series is ready for inclusion. There is a conflict between
>> this series and Maciej's non-contiguous work [1] that is also ready for
>> inclusion. We could wait for outcome of next level review to determine
>> who will need to rebase. It may help to provide a snippet of the conflict
>> resolution in anticipation of Maciej's series being merged first (I will
>> propose the same to Maciej for the scenario of this work merged first).
> 
> I had a minor comment on Maciej's patch.
> 
> https://lore.kernel.org/lkml/fd2309d5-ea56-abed-5c3e-a8a038b07d9e@amd.com/

ok, thank you for reviewing that work.

> I will respond to his patch 3 with the conflict resolution.
> 
Thank you. We'll wait for next level of review to learn how best
to approach this. We do not know which series will be considered/merged
first. 

Reinette