Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp649880rdb; Fri, 6 Oct 2023 14:32:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHk0XOsbxvjDSxspeWkd4p/MuzGCugp335KS3uTDWvVZE4yqtnNZDMZh5gzshDayUxt7sKX X-Received: by 2002:a17:902:e852:b0:1b8:af7f:6331 with SMTP id t18-20020a170902e85200b001b8af7f6331mr10776063plg.55.1696627975524; Fri, 06 Oct 2023 14:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696627975; cv=none; d=google.com; s=arc-20160816; b=KEpiKctaCSdDRjYTbnrDhd1idXENb1db0D/2cC6gySivHVeTYZBNeWdSZisZ0AyUjK VAFcbty1r9A1jvB6T8JFfthL1fv6QP7o+vP++avW9iSvZWGm1upUtEUPqBzhKnaGHO+7 N/3tTB6dO+uesbspXiI1kBVlOafsWu3LhnlBx8z86ZWbO9uLkmNnB+p+laF3I7E814Bk 5LXAdjj1Z18HHNoWOxtX3t/9n9jnytKCikYgDCfj/Et9+F5yKEByHa7nWGMXYsMkp2Lc unw+mrn3LC2/ARha3Tmc4D9Cr01dgDclmLhQwMvYF3+UoiqgTnn06trGRoNGmSomxu1z b1Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/kGLNZ5FdNbzB5o8IFl/EqUq4fHCymTaDHX4a6wCsUs=; fh=ZM+6uLuj5A9gEy8x3FUPqpKFNBOr1oQPkFYX2yzeuLI=; b=DQzsL2IvnmoIkJe+doije8QosYPJ4HiF3DUliRqa61QLo2qagt+A+2HGRQCw54r/DO YRTRaaCYLwb4ns+Je78mv5++7vOOO/7jJXwghkEEm0tBmsd1e15OpkJ4NiAFbc+eDNix M5IuPuemNjUCayuq/sasXe8R3IVMa/FutbgX7yqRzL5iL4xB2Gsr3XT75pgT/EPdLJ5j 2vojxiNlZtCnYvDr8/5OF5IOubWh3PvNlcvOCsnaYI4deDs+WQbwJlebwrX4981QKxps 2cUeL2VJIza2JyKBRZrFcU146uKVCX9z2Ou+EA1xN20rPQnS7dPgxP3tP1i8tlXO0WCC 0mUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bVi51T6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id w5-20020a170902ca0500b001c342073f76si4226039pld.323.2023.10.06.14.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 14:32:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bVi51T6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2273080440F8; Fri, 6 Oct 2023 14:32:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233585AbjJFVcf (ORCPT + 99 others); Fri, 6 Oct 2023 17:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233362AbjJFVcc (ORCPT ); Fri, 6 Oct 2023 17:32:32 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39395BF for ; Fri, 6 Oct 2023 14:32:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 449F2C433C7; Fri, 6 Oct 2023 21:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696627951; bh=sTC4CetYxtFnNBT5I33REzikDFDQsnbC2qzIKmyK4hU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bVi51T6WtnlsXeqgwnvqUdsxuGfdDCT+nMKIznhFwYLe99uSFZBmXJzRxHisAIeSn GPGf08DxN3ysRTlU+hJB8Qi/KwXXCMnjs2Gl5X7FY1/Iwnh9EhueFAm07PkJ5qzp3n gGLNtsRiovBFsPvSM30duKyt1AFGpLCVWwFYFCzPL3bzrQxqG7VMHqW2Lt9bW4bOz6 9ZDvIPhVMeB1MSYDGWCEl7Cwd1zNDgpMSDKwBNJkDpTAXzUCvhwkv47yp/3/lSK19F 3JJ5C/ZbASMIFErooWKUcbu+UzuiZRLJIL9SirtsjG/12h7SgFC18cTvXAIQTfQQFD W9Iehn5RdAoGQ== Date: Fri, 6 Oct 2023 14:32:30 -0700 From: Jakub Kicinski To: "Pandey, Radhey Shyam" Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "Simek, Michal" , "linux@armlinux.org.uk" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "git (AMD-Xilinx)" Subject: Re: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine support Message-ID: <20231006143230.4230fdc2@kernel.org> In-Reply-To: References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-4-git-send-email-radhey.shyam.pandey@amd.com> <20231004135317.2b460acf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 06 Oct 2023 14:32:51 -0700 (PDT) X-Spam-Level: ** On Fri, 6 Oct 2023 19:04:29 +0000 Pandey, Radhey Shyam wrote: > > > + netif_stop_queue(ndev); > > > + if (net_ratelimit()) > > > + netdev_warn(ndev, "TX ring unexpectedly full\n"); > > > > I don't see you stopping the queue when the ring gets full, am I not looking > > into the right place? Otherwise this is sort of expected to occasionally hapen > > We are calling stop_queue if TX ring is full. Is that what you meant? > netif_stop_queue(ndev); But somewhere else or just here after printing the warning? The recommended flow is to stop the queue after enqueuing a packet successfully, if the remaining space is not enough to hold an skb with all frags populated. That avoids ever returning BUSY.