Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp660713rdb; Fri, 6 Oct 2023 15:03:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3FG1vYA304goCtz8kznK0gUMW35ILDX9mWwF8tMvI4BmHdT38c1sJGOeeEEkeuPQNBugV X-Received: by 2002:a05:6830:99:b0:6bf:1e78:cc52 with SMTP id a25-20020a056830009900b006bf1e78cc52mr9611145oto.25.1696629784710; Fri, 06 Oct 2023 15:03:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696629784; cv=none; d=google.com; s=arc-20160816; b=vD6oV8T8uDt51OQ06jAcbHdF1GZ/jtg1W7LhQI0yM+Y2C6G6AvfJTd/22Zk0ouERji NdHKw7lRI/9sivycgD9tVfRlGcRk/nQR7idDra6+hDSNfwT2zQuWN94VQJDv7pdlkNKB oDEqjhxURgOP7MUTQVK3mpAtV5qW8QNo+vqWUWhOAJlpw/l96DGpHyGSwPW6WN1zWdPp t5e6YAyyfZ5eveP7WIv3uIaizdvt4ZIWtLel/I1HWTU5DbvzajRfN+Q+U8aZk5RNpbXD pNkSqj8hwhkeTifLjSnEoJoMi8KOkmdzXW2bj0HnU+nL4Bw6SYOo88loo0yHZQqqnrkU IA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=elAhg2a2id5HYJ6Rwqc3sV5VRPo3U52+UPydYb678HI=; fh=0jTZ+kmx2E/ZbPPZtSqPVB/c1SnMftkAGvCX+I7+A+A=; b=W6R7ttTCciz+7bhRWqebdRBgVpMC1aKCBZNKnCly55VA5OMnvBAfkC3W+Sn291Q9pv bfQVGeeLCUgEbaIfq3LD9NfQ84W7uJGTCauyy+OIZJ68pqFokvrRLxZDElJyT7Qx4Csc pbCAoyGOQLrNwq0XpbGGOPLpo3pxAuCXJrjiOdPdHmKeA9pBzAL9/Sf2mKQ2XjePmdPL YjFfRta9a4EInpteBgcD5wURUJ41mfyqA2t0PcMN2S4v24EiUvQfoVTXrpAP5Xq7i+0t EPreLcv8u3sc4N/L78/sAMuibAXp80jxMe115EQHfhN92K2i4QLVr6/lAUdXjpr3kaiN mFFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mr5hNZS7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id az1-20020a056a02004100b00578d71ef3d7si2403011pgb.733.2023.10.06.15.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 15:03:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mr5hNZS7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8578B80A2349; Fri, 6 Oct 2023 15:03:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233651AbjJFWC4 (ORCPT + 99 others); Fri, 6 Oct 2023 18:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233545AbjJFWCz (ORCPT ); Fri, 6 Oct 2023 18:02:55 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96CAEBE; Fri, 6 Oct 2023 15:02:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49C4CC433C7; Fri, 6 Oct 2023 22:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696629774; bh=5qNpTHdPbPHNPOq+CPvh8QULUoFCrWL4op5DAxKIpGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mr5hNZS7cPEC9fZ9Pm1otMuyEoQtn5x0MebbmvDKT1ysxZd56Xx+tCIEM8QZkQ0Rx 2HUNxrgaPRHz8QjWANUbD1mH6curuCdl6HomjYf2KnrCtmGyAAnY5ufgjcVH8v/6jb QG2jDbcpxxyNYg4G8snQQRAUJZiH1mXGOYt8SQQGeANRY51XoIQTOlWK6yuYXJMFzl JuNX4YzwFq+kxxRqEiTycDfkPmkv5j5xhBajGBUP1pMm0yb+NbugndmWBLihXxE3sN +UAuDIx49s6xJ7b8nNHq77RCfPL2Bx0miv1JSuqRDSCA4eQG0Z9vQ8/jx1890NcVXF fyDg6rJJsfGGg== Date: Fri, 6 Oct 2023 15:02:52 -0700 From: Jakub Kicinski To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20231006150252.6d45be95@kernel.org> In-Reply-To: <20230928070652.330429-27-herve.codina@bootlin.com> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-27-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 06 Oct 2023 15:03:02 -0700 (PDT) X-Spam-Level: ** On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > + for (i = 0; i < count; i++) { > + (audio_devs + i)->name = "framer-codec"; > + (audio_devs + i)->of_compatible = compatible; > + (audio_devs + i)->id = i; Why not array notation? > + } > + > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); Should Lee be CCed for the MFD part?