Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp683137rdb; Fri, 6 Oct 2023 16:01:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYhcNX8+IFVZ5MLDBIobk2SENxeacuFhe0rMuclfMMH+jz6gLQ+0ySu95AiUNyZlYzjO8h X-Received: by 2002:a17:902:eec4:b0:1c3:758d:32de with SMTP id h4-20020a170902eec400b001c3758d32demr9389377plb.12.1696633316199; Fri, 06 Oct 2023 16:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696633316; cv=none; d=google.com; s=arc-20160816; b=v2vB+puD7COB7NXwQDq2vDGdnYolLxBY4VjRZrvsMDNF8uysfgJdyDNEeYHaCMtk0s b/g6yFUapoIiklbSo07UDWFN7bEKr/9sDvovI/+czVD5eCh2hpoTY94p6J+lnNqYAGf0 dhii0Lt7IRo4MwInwLWs2aI6fbCO/3xMSXuPVL19xaVgV04OFu0wpXHvpMmfNi2TzQyi mGJRU40f+kdqXTCUNc0ZADZb0ARV1hghEyZJH0OfaHoiX2lCdq6JKRIOrdczDJ/lW8Io 7hZAN2vElE+OyCaw/imAKQ+ZTWHyza9WV45w2d6CaYHTn0JSH3kZrCkYFj7GzXf4BItZ ZZZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Cu6BnZL2QweafpvhnsMARjmmNQKovsmfuuggr1N8CkQ=; fh=BGVpu2jGKvb2Quxe2pI/ngleTCl6InLVuP2qrWIX9bM=; b=C82aYuXbhsaDEi8iIHTssfZi46JaaJIMXpEDj0mWqcuw9jU4ikLFK4qiLbTt+d3Wy6 62q847yg6zZs+BnOKQwslIMruChahvnlsnYfxzsCKuT9EkET0YSwzTgb3vQ8pIkUHePM 0i6PkrNYEpv9b2yRD7vhrOwJvrRe4gjGtOUIHRg30w0O+JB2X7sp+Rj8bAtI06ULn0qt 7gzj+AhhHzbku0x1cJkLur8pwjt2QGGVU0TUGzzE6BqFZ/8scsF/iXbjJ+/vF4hHrA7F FT3mtyRNTKJnu6fEazrRSZMDmDtnu1xYRlpiYT/1xTVttikNO3SDmDfQncpvREaj0/Cf 1OJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LfYmjsJf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id h18-20020a170902eed200b001c618473ac1si4369447plb.627.2023.10.06.16.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 16:01:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LfYmjsJf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 96D968093721; Fri, 6 Oct 2023 16:00:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233902AbjJFXAg (ORCPT + 99 others); Fri, 6 Oct 2023 19:00:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233881AbjJFXA1 (ORCPT ); Fri, 6 Oct 2023 19:00:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DCE9C5 for ; Fri, 6 Oct 2023 16:00:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id 120BDC433C8; Fri, 6 Oct 2023 23:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696633225; bh=MI+XKg/LdzdUZV0k2jCaAZ13tSOTPvUQCpOe/gCDRcg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=LfYmjsJfGP3PP1t6b4RnoeNCs+o3KJh/297MaVZ5S3yQ5HHzps8kILGLG7ZYRLnoB rGDj75ao52iXZQcEWnSgZnY8SSGsBEUPEhJsReGcDxg51PmgiWYtceeoHav/TSJtF+ g3i9msA+/g6yMPYlZt5H/XLP3Q0kanZ7lJuz9GyXpFj6bp4xnGrnyL5VmgZ/H71Vxe jNxSqKa7/I9kIup4NVWHDefYCLCnnO2esdyEf3M/h0CZnfWVgaZIm5ESCoyVtbyXrq KaRDt4Yz5Z0z6NQgepN+aVIcRYGMa4y+LVHgZGfFrBPPJ4URSPRQMu7nwJ5rtoUB5t JWbgLFLlZx5IQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EC89FE632D2; Fri, 6 Oct 2023 23:00:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] devlink: Hold devlink lock on health reporter dump get From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169663322496.31337.14047004680576589561.git-patchwork-notify@kernel.org> Date: Fri, 06 Oct 2023 23:00:24 +0000 References: <1696510216-189379-1-git-send-email-moshe@nvidia.com> In-Reply-To: <1696510216-189379-1-git-send-email-moshe@nvidia.com> To: Moshe Shemesh Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, jiri@nvidia.com, linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 16:00:59 -0700 (PDT) X-Spam-Level: ** Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 5 Oct 2023 15:50:16 +0300 you wrote: > Devlink health dump get callback should take devlink lock as any other > devlink callback. Otherwise, since devlink_mutex was removed, this > callback is not protected from a race of the reporter being destroyed > while handling the callback. > > Add devlink lock to the callback and to any call for > devlink_health_do_dump(). This should be safe as non of the drivers dump > callback implementation takes devlink lock. > > [...] Here is the summary with links: - [net,v2] devlink: Hold devlink lock on health reporter dump get https://git.kernel.org/netdev/net/c/aba0e909dc20 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html