Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <ZSBV+h/gjPWV7+Gj@runicha.com>
In-Reply-To: <ZSBV+h/gjPWV7+Gj@runicha.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Sat, 7 Oct 2023 12:55:14 +0800
Message-ID: <CAAhV-H7B2tqw-PWD2775Nx1JiPVwh8nGYsVDTiA0QjBhTYbrMw@mail.gmail.com>
Subject: Re: kmap() transformation: Question about copy_user_highpage
To:     Deepak R Varma <drv@mailo.com>
Cc:     WANG Xuerui <kernel@xen0n.name>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Deepak,

On Sat, Oct 7, 2023 at 2:46=E2=80=AFAM Deepak R Varma <drv@mailo.com> wrote=
:
>
> Hello,
> I am attempting to work on replacing the kmap[_atomic]() calls by
> kmap_local_page() function call. A detail on this change can be found her=
e [0].
>
> I would like to know if this function:
>         arch/loongarch/mm/init.c::copy_user_highpage()
> is currently in use or is it a dead code?
>
> If this code is not in use, can this be removed instead? However, if it i=
s in
> use, can you comment why kmap_atomic() was preferred over kmap()
> function call?
I think this function will be used for the 32bit kernel, and we will
add loongarch32 support in the near future.

But on the other hand, you can replace kmap_atomic() with
kmap_local_page(), there is no special reason to use kmap_atomic().

Huacai

>
> [0] https://lore.kernel.org/all/20201029222652.302358281@linutronix.de/
>
> Thank you,
> Deepak.
>
>
>