Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp815063rdb; Fri, 6 Oct 2023 23:44:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgPCZaNlRO6HcMJH5699PfkF8MKmba/Rv85z7BouFMscBdHkTJ4fFSD3OHTEfVzHfyT5xy X-Received: by 2002:a17:902:ea8d:b0:1c5:64aa:b97a with SMTP id x13-20020a170902ea8d00b001c564aab97amr10702079plb.38.1696661076152; Fri, 06 Oct 2023 23:44:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696661076; cv=none; d=google.com; s=arc-20160816; b=DzwO18/qTMxj5juzxkeShIYBg28AerfqOH3DyMOT0sC+uwXkmi8Mj5f1uJF47N+MuW ZCQwGWCybYBdPrYS0ImFdT4kveqlNAMkEsWIK4cnc4wEjip3MS4+eMif+L3Ej0xeuFH2 FVAptK8nIND1XC7msBiONXPtbRI1biQ3LhqLmS045AGxnesrjYyEUvjLTfASd5MjDdza SWCB99vL8PPw++rdPzmFIRs3gytRO1IBolTdeO/cCaHo9lq0bCtXZizJKONDLhgtka9K OMbydVl54T2NjlhysUymFwXpKzGMfUExIcZY4SRfqldLCP8iGJ6sz0EDxMmBfn2RUp0x I7ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=g62LIcW3E/3c1z4YXtV2lA3i9qxLseUXjDaF7OAWax0=; fh=8jYxASQULAXEX0cTonjc/sRL1jTPYygvikVw2lWVZDs=; b=doVbMaaG+SkgWcv18NAnsuupzyE+LPnqyQvVtU7w7D2NjkUfnX8I8fLGXzX56Udtkh H10Guf0hwA3us7W+uZsafRW3w0jfC08wlBxlX/2XJ0CStKueflfhgat2mGok08EPL2ZC H3sI6UDSSDeJpbSOi86s9+bkwGKaWkYDqXs2rcsjedJdRMxI1vtXtrS0Z9UW3ePgSLNY /kMRqtJcpNLncK0Fl5BCFYXXSa3iFatbdz4t9nbtl5TkYXcKU12llF815PBRfaZSMK3V 2B6otWctq8UG1/jHSRmaQ5CnnscZyg0v1DJBKePNhEaQxcCCgv2kkujXSptVaxBH0xAP 72xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="h+/H2A/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z8-20020a1709027e8800b001c6138350b4si3006115pla.431.2023.10.06.23.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 23:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="h+/H2A/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6405C80408DB; Fri, 6 Oct 2023 23:44:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343586AbjJGGob (ORCPT + 99 others); Sat, 7 Oct 2023 02:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343561AbjJGGob (ORCPT ); Sat, 7 Oct 2023 02:44:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A84CBF for ; Fri, 6 Oct 2023 23:44:30 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7842AC433C7; Sat, 7 Oct 2023 06:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696661069; bh=/UithT0SHHNlkQBneXRuPm4dZa1q7Z47U1p0EtVjkFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h+/H2A/ryLltte4AKxm6lAct0kOE2L9MdXkGn/qY2b9L3/FNs9j8QrmVsJmR3k8sV adZ1M9wd3xgCiutn1uLbhKR9ds939NOLrY/HUcsgShiUOH94oTRaFgbIltzVi04azh gNScDXoNAD+9xCSjvowJJY2/4xqZoXSjfNxJvmrc= Date: Sat, 7 Oct 2023 08:44:27 +0200 From: Greg KH To: Kassey Li Cc: gregkh@google.com, cmllamas@google.com, surenb@google.com, arve@android.com, joel@joelfernandes.org, brauner@kernel.org, tkjos@android.com, maco@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binder: add mutex_lock for mmap and NULL when free Message-ID: <2023100715-blade-valiant-714d@gregkh> References: <20231007034046.2352124-1-quic_yingangl@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007034046.2352124-1-quic_yingangl@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 23:44:35 -0700 (PDT) On Sat, Oct 07, 2023 at 11:40:46AM +0800, Kassey Li wrote: > Enforce alloc->mutex in binder_alloc_mmap_handler when add > the entry to list. > > Assign the freed pages/page_ptr to NULL to catch possible > use after free with NULL pointer access. > > Signed-off-by: Kassey Li > --- > drivers/android/binder_alloc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) What commit id does this fix? thanks, greg k-h