Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx
 compatible
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20231007064439.GN34982@atomide.com>
Date:   Sat, 7 Oct 2023 08:54:19 +0200
Cc:     Andreas Kemnade <andreas@kemnade.info>, bcousson@baylibre.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, linux-omap@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6D2A2AA0-759A-4AF8-967A-ED6FE2F6C1BB@goldelico.com>
References: <20231004065323.2408615-1-andreas@kemnade.info>
 <12323F42-3611-4685-8981-F6A18C4A5862@goldelico.com>
 <20231004130353.01228376@aktux>
 <FF3A3F35-E264-4D28-AFAC-EFA2ADB69F40@goldelico.com>
 <20231004135449.591b3f6c@aktux>
 <42806B60-E48B-4AA9-B375-E9F65F59AB87@goldelico.com>
 <6B245439-F9FE-4931-A0DE-81F825BB5FE5@goldelico.com>
 <20231007064439.GN34982@atomide.com>
To:     Tony Lindgren <tony@atomide.com>
Precedence: bulk

Hi Tony,

> Am 07.10.2023 um 08:44 schrieb Tony Lindgren <tony@atomide.com>:
>=20
> * H. Nikolaus Schaller <hns@goldelico.com> [231004 12:50]:
>> What about the PVR/SGX driver. This needs a compatible that can =
distinguish
>> between the DM3725 and DM3730. The first is w/o SGX and the second =
one
>> with. Having all summarized as omap3630 does not allow to load the
>> PVR/SGX driver based on the board specific compatible entry.
>>=20
>> AFAIR this was the original idea behind=20
>>=20
>> 	compatible =3D "goldelico,gta04", "ti,omap3630", "ti,omap36xx", =
"ti,omap3";=20
>=20
> I think we already handle this, see drivers/bus/ti-sysc.c and search =
for
> DIS_SGX and similar flags for other accelerators.

Ah, ok. This means that the kernel module isn't loaded if the flags of =
the chip
are not available. Then we will indeed have no need to describe such =
variances
in the DTS.

> So I think this patch is
> safe to apply?

Looks so (especially as I only have omap3630 based devices with SGX).

BR and thanks,
Nikolaus