Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp827937rdb; Sat, 7 Oct 2023 00:27:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkwE1gyjJ46C7UTgqzWx6F7eTWxwfRzhXBsKA3OO2fe1//YJGnSEjf9Ciwed3NUVGsCQIV X-Received: by 2002:a05:6870:898c:b0:1d7:1533:6869 with SMTP id f12-20020a056870898c00b001d715336869mr11513619oaq.31.1696663621274; Sat, 07 Oct 2023 00:27:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696663621; cv=none; d=google.com; s=arc-20160816; b=jUg9Jby8AKENAIFqb6sLIWWl0sjKzwrD8PYvU0HqmP3J4j7zOLecbw5PiCKorNszjx RtJg3txRN4gsMoNJj6WHIm6OBT+aohlccUh+iQ+c/F4ciLj+NjrXsRMj+gktq/I5k2wu e6V8mJ3amf8LCdN+5hNoxBwGrTJdHmmLXNlq4zhWSdD3Qgn2noOZcnucm25zNGo8aDhp SpPXXLqtMi4fvAkOo4ncJl6UI5Dyh/Q0JKwbkyyaxBj+WSmjIGMmJV6F1L838zP7yYio 3d9/LA8O4r57dleo/iI8752LaP2poW5cHLiDZeKH7yuWnDhZtFBmbEqHfHBHgQ4Yj9gi 1X9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6pVp1kJqdHyQpPEBFzN+TSg9PJ7ouKT/8Am4n1WlgMM=; fh=4IkbjRoiAUwtuJP77LQWyWAwa4EZ96T2Ww+E9dPQewk=; b=aD/P9z5ekKYtfkvd2Xkn+2/Z0jMt6SN31eZ2QCvmWDXe2OHxCeGmJTYhbwu8n0pigM i5aTvWmWCdyf9qsJ9gCMjtgi4LOcjxxOAFKYV1NimtW45H7Axv5EAeUChK4bzDfv8Id1 8hjXfvZbjAZlvUMWZFFUFIBdLtUY6PlDZ9/pDX269PFbumE7VTtR8TI6LEZssMwUDgtk FfDzzvXnwG1Qw3qRmbdL2HQAsEUrj0NlsYDLvMpzQpGsLpFQ4tXyoNA+ZZ5emJEjDawc v7zZxzmvoSETAUEjFJ826VDimiiMgm5tDGIHrMuT/styCwoF1qcsqHrrn7FmpsVqQJgk y8ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=N8E6Rki+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id cb7-20020a056a00430700b00690c23d353asi3050503pfb.217.2023.10.07.00.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 00:27:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=N8E6Rki+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0EEFC8092D8E; Sat, 7 Oct 2023 00:26:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343676AbjJGH0B (ORCPT + 99 others); Sat, 7 Oct 2023 03:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343632AbjJGHZ7 (ORCPT ); Sat, 7 Oct 2023 03:25:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFD4B9; Sat, 7 Oct 2023 00:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696663558; x=1728199558; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J282I5R9WNoyobuH7Ogbg9U0iV/eHTpeZxVkwzl1QWA=; b=N8E6Rki+v34L3ysgoaZN4BosEwukqSWvzgAU8i5c6V56DPEBYgegNLhX vDjIZWC032r/zEb4kr/3v2Vg0ZZHIBMxcp8u8FCxP6rA1bC27jCtmHufH bBKGe+uPVSRsSVbmnKdlNZl169RdLs1mMJJnvMklFYBQ3HV/uwG8qticO hRoyxhNje/NqnbD6+9AMf95b+dbyPL8TRqQBAO1pGO/hzVRUJ+Z0/6lkH a5Ywz4/dsxlHANnBCnZYQQ1M2iIAo30DCgXn4L6Q30GJ/JYzqgzAZjWWb UO9vZI2i3LASym8h1UkMFxq9XXOsDZH08t91y3mew4+L/9Qig6Ya4lUUp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="5460244" X-IronPort-AV: E=Sophos;i="6.03,205,1694761200"; d="scan'208";a="5460244" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2023 00:25:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="999620260" X-IronPort-AV: E=Sophos;i="6.03,205,1694761200"; d="scan'208";a="999620260" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2023 00:25:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qp1hA-00000003Xh1-3huf; Sat, 07 Oct 2023 10:25:52 +0300 Date: Sat, 7 Oct 2023 10:25:52 +0300 From: Andy Shevchenko To: Hans de Goede Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita , Corentin Chary , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mark Gross Subject: Re: [PATCH v3 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device() Message-ID: References: <20231006155351.3503665-1-andriy.shevchenko@linux.intel.com> <371fc87d-ade3-51b8-6f56-4d99dad88873@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <371fc87d-ade3-51b8-6f56-4d99dad88873@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 07 Oct 2023 00:26:15 -0700 (PDT) On Fri, Oct 06, 2023 at 07:08:35PM +0200, Hans de Goede wrote: > On 10/6/23 17:53, Andy Shevchenko wrote: ... > Thanks, patch looks good to me now: > Reviewed-by: Hans de Goede Thanks, but it seems something went wrong (most likely due to age of the patches in my local tree) and confusing "BUILD SUCCESS" from LKP. > > + id = acpi_match_device(device_ids, adev); This should be acpi_match_acpi_device(). > > + if (!id) > > return 0; -- With Best Regards, Andy Shevchenko