Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Sat, 7 Oct 2023 10:27:04 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: xo15-ebook: Replace open coded
 acpi_match_device()
Message-ID: <ZSEISNzKdNIs7WHy@smile.fi.intel.com>
References: <20231006153152.3502912-1-andriy.shevchenko@linux.intel.com>
 <ff4e541d-590b-7eef-aeee-dc15ca869691@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff4e541d-590b-7eef-aeee-dc15ca869691@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 06, 2023 at 05:34:19PM +0200, Hans de Goede wrote:
> On 10/6/23 17:31, Andy Shevchenko wrote:

...
`
> Thanks, patch looks good to me:
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Same issue as with other patch...

...

> > +	id = acpi_match_device(ebook_device_ids, device);

Should be acpi_match_acpi_device().

> > +	if (!id) {
> > +		dev_err(&device->dev, "Unsupported hid\n");
> >  		error = -ENODEV;
> >  		goto err_free_input;
> >  	}

-- 
With Best Regards,
Andy Shevchenko