Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp829357rdb; Sat, 7 Oct 2023 00:31:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAuDly18QeqklxxeF6iVnMMHOhThcao970LEFvDPuWkm0BQMauJg5nlxkF/ni5bOanVXCn X-Received: by 2002:a17:902:e54b:b0:1c5:b1a6:8118 with SMTP id n11-20020a170902e54b00b001c5b1a68118mr12024940plf.42.1696663883267; Sat, 07 Oct 2023 00:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696663883; cv=none; d=google.com; s=arc-20160816; b=e9ArSXJ9r/uZIhhrkWXCK6dQtvk7TGSlfN6Q16nXjTR6P2i6v4a1A7/WRT3tNNN/x1 nio3b5u5vb2jUIwjmrjQtgO30Ma+XvVbXfjvbrBWEMwB4g1SiLGwtsFglkHduaRO07+P 18MmyLIptBx4Gy5pSIcRN1VlaJqiS7305UK8wc+7PhqOptGVXSKU6GLZugQLEkVW+Rht BsvIweyfLPNv/BaI9d0Wnx4QGjYpgO3HCYWuPEz9wjWon+XMtwrlbQjbknf5TC5Vs5wH uqzPaWX/qmbpJCM1stIbmu8kbjugwDqeo2Nn3Dnu7kl72yLbq9xTAPvz8v7yQmmqd24N 0nhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=P2XYj63JutQ2NopEHr3614ehw4VQD2DCO6wPQwn2C2A=; fh=s6ICtuTBi7k0M74ZwCJ8cS75lQvVhR7rwDBQIIn6JwM=; b=jwKZScOqJFYRnvsbxm2sFlJCwpIxYPDo5h/LdbLY5KEG8K9CyXp5rn6/+YiM9upZVh /gncJm8aMvVOotW2X52/vBBDx4eNmXG/+QJ9FzS6D/9z4oTY4aiYnuDZf5Mi6v2U9p6Q PP/4WjJ3I4NvYj/pISqy7L5Y6Xs4UMffXbBgsFCVAOQu9ODI2wwIe/OxVC0LEOy41tE2 XljcPEdjkXjTZuZ7KuXODO1qJemzh9YBLPVbE5Lm1m/77a/qy++wxU/NWeoQD3IRmoEj Dos49LWAI0GxBwyoMCFDEqJAGyh4jt47c37s2SDwBI4H3K/HUvTCWxm/1rOJ9PYzhwLd ekBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hz6oT4nj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id a2-20020a170902ecc200b001c62cfff798si5870272plh.372.2023.10.07.00.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 00:31:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hz6oT4nj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AB23D8090E92; Sat, 7 Oct 2023 00:30:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343714AbjJGHaN (ORCPT + 99 others); Sat, 7 Oct 2023 03:30:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343704AbjJGHaL (ORCPT ); Sat, 7 Oct 2023 03:30:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A82B7CA for ; Sat, 7 Oct 2023 00:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696663762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2XYj63JutQ2NopEHr3614ehw4VQD2DCO6wPQwn2C2A=; b=hz6oT4njxv8MutcApmtguAkGLuSZ3KbUwzjOvX9zEV/8/Fqf8JFm9G6GA/2VsA9Mj7SavV EZ5bmSBBNI+use0K/sN1c+GWp0RmlTtHEaNJrI7uJMht2UXeDZFl2Hh+V4nm59PfG2cm9l FDmsizFTNoWOZ3WRjoewtVg1ZdXn3e8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-Id4xzfQGNO-7JeT9k6sb-w-1; Sat, 07 Oct 2023 03:29:18 -0400 X-MC-Unique: Id4xzfQGNO-7JeT9k6sb-w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A24B8380200F; Sat, 7 Oct 2023 07:29:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id D59FCC15BB8; Sat, 7 Oct 2023 07:29:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> References: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> <1809398.1696238751@warthog.procyon.org.uk> To: Hugh Dickins Cc: dhowells@redhat.com, Christian Brauner , Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <231154.1696663754.1@warthog.procyon.org.uk> Date: Sat, 07 Oct 2023 08:29:14 +0100 Message-ID: <231155.1696663754@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 07 Oct 2023 00:30:22 -0700 (PDT) X-Spam-Level: ** Hugh Dickins wrote: > - __copy_from_iter(p, n, i); > + n = __copy_from_iter(p, n, i); Yeah, that looks right. Can you fold it in, Christian? David