Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Sat, 7 Oct 2023 15:20:41 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Yi Liu <yi.l.liu@intel.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <nicolinc@nvidia.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 09/17] iommufd/device: Add helpers to enforce/remove
 device reserved regions
Message-ID: <ZSEGyVXXvNQstD/+@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-10-yi.l.liu@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230921075138.124099-10-yi.l.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z7apEBmckQk/UUJkL39osn/v+jRwn/lpBEQbA6ES83ZR0mvNHdlezHckuGBU?=
 =?us-ascii?Q?YDmk8UqwSNpkzJWlfq4nEcmwP2X7cCdPWov6Z0nzzqB3uCdIxfqiy9153yzD?=
 =?us-ascii?Q?7GUo+emtxE2gIQsUv6jOMyMn7QGAATK+UiQKu7NlcMZVQWTcblv7mnE/F2vY?=
 =?us-ascii?Q?OQFWyQTrK58mA9M2NG4yP8w1TfYGPHMXMb08aurdw5yHGNjl+/V+m3fd1hLl?=
 =?us-ascii?Q?WxrTPowiHzuUObOM/SEYz0xRtw3SxPHOkMqGsMVdq6w+dwFc5AH0mK7QOjfG?=
 =?us-ascii?Q?9mtQ2bYYYz7hRrqwIG+1bIvPouOVFRfde87eMaXGaJucKTRdVGYLdU1BXBfU?=
 =?us-ascii?Q?PkxZ+Cj2RbOZQ30ad3joWwF4/lkMA0XaZ01hNJTCYuCY8/1QUrg8Nu0yTHMs?=
 =?us-ascii?Q?Me2pvx+mAcSmdG9ZeSBiUySMTNBTp5fyWE7Hclgl0uMTgLbkwdr9lQJ6w072?=
 =?us-ascii?Q?0CAjtVAGPRcOe/mAXU1zhLurakNc0f8hWGbN4k0cv7iqsCZynVcfBSnQFkQv?=
 =?us-ascii?Q?OpVGHbjR2S5ZUFdT1gwDBDLbXa3auv6jtVb1eKp18dNAPW9g2CIFonjSpzoP?=
 =?us-ascii?Q?0lHppKGVYDvmZwDHsENMn0RJbXZdnwdPZri7NXFuXLuggVKxfo70rLcccjP7?=
 =?us-ascii?Q?YDRYrtD2Yi2jpTO3SSiFlT+WfPTisiV1/L2pFbGjJmHkkjRIjEV66zxU+SaD?=
 =?us-ascii?Q?1LibEUvtwxRi07j3ALJhlQGmT6kwBvyF4Sg9V+bEbRPUjEc/yYxTOyl+wxYi?=
 =?us-ascii?Q?OGMPzlbYq5x/ubXSmCzPJkOg7lnxA+q6etlKJVcJ1iRBe8rbFoy0LhkPKGBd?=
 =?us-ascii?Q?2cENzJeeVXsPp/3kw9PUmfVQkJ0/9LkLuBLPaktVrAqDUyDltmuSasG7xKgP?=
 =?us-ascii?Q?PWEV2IOvgKn+wRulhYZIvbQRkwZlotXnVzusInGsSSPCMaNHzsvXQpT7vOP9?=
 =?us-ascii?Q?+EpFrm9NZQ19JahnFZnXUc0kY3UmcQy8rZND5nOcYgRqbBHDF7v5xfJCkczo?=
 =?us-ascii?Q?I4EyFCb+We6bmQi1XcjiDc5IrTwVZ4KMQYCd7eH/2JjhM2ljaJfH0xJ17fsr?=
 =?us-ascii?Q?+eU6xWHSBYs4WOWx/PXpJf722Mp9XNOdaUPZvvqw+ZjW3lzKjqlSikSeSSlN?=
 =?us-ascii?Q?A00tHna9TcdpvFIV90ZP7nXpRdOcsZBZ1VwG1z1tWOiAxtMvijIFH3R7Rd2l?=
 =?us-ascii?Q?W/+54MlpH2JRL+hAxtDk8vQS7Qbii756q4G+lESsxUxkBwJLyR1jxvwbCAW/?=
 =?us-ascii?Q?Aw834fP2Natiymsy9hwVwtzdDhJSFiJqN+acJ1lbBL0N/SaDwobwUH0Tzqfh?=
 =?us-ascii?Q?Wd3sTP3updnptl9Lm1eQItu5cWsQL9DwFZqOBfRBSPmDowTAMVdVCKfftzld?=
 =?us-ascii?Q?Wt8PpAX5Y//RqBF2vlaIRzEHQcWqRYc9jr++mm7ra+41iH76IPhPYI7wPH/J?=
 =?us-ascii?Q?IyPRzXtRrpBVDL2oLXoBbJW7Khyi4C+8ghsz9BAUW7H1Kgsc6I31H8KMF3zo?=
 =?us-ascii?Q?bvkP/HS+crgAqCU7+CdoilUD7rXiwLYmLoplpnZDEFbwfo8DKjIkSPzugZVl?=
 =?us-ascii?Q?1LcK6S1PBKmt1CQgb+hZfgTv2JRX0vgR0QZXRYzx?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c40b7604-7788-4c36-702e-08dbc709d82e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2023 07:48:50.6859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DBKG3vMFSR//eLobgUR7qRrKv5slxX17zJkQ5+tXPfmfK6/QLdKtf6PCOq5LH2UqNpgWnSrySKWfepw++GuQIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5077
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 07 Oct 2023 00:49:05 -0700 (PDT)

> @@ -444,10 +465,9 @@ iommufd_device_do_replace(struct iommufd_device *idev,
>  	}
>  
>  	old_hwpt = igroup->hwpt;
> -	if (hwpt->ioas != old_hwpt->ioas) {
> +	if (iommufd_hw_pagetable_compare_ioas(old_hwpt, hwpt)) {
>  		list_for_each_entry(cur, &igroup->device_list, group_item) {
> -			rc = iopt_table_enforce_dev_resv_regions(
> -				&hwpt->ioas->iopt, cur->dev, NULL);
> +			rc = iommufd_device_enforce_rr(cur, hwpt, NULL);
>  			if (rc)
>  				goto err_unresv;
>  		}
> @@ -461,12 +481,10 @@ iommufd_device_do_replace(struct iommufd_device *idev,
>  	if (rc)
>  		goto err_unresv;
>  
> -	if (hwpt->ioas != old_hwpt->ioas) {
> +	if (iommufd_hw_pagetable_compare_ioas(old_hwpt, hwpt)) {
>  		list_for_each_entry(cur, &igroup->device_list, group_item)
> -			iopt_remove_reserved_iova(&old_hwpt->ioas->iopt,
> -						  cur->dev);
> +			iommufd_device_remove_rr(cur, hwpt);
Should be "iommufd_device_remove_rr(cur, old_hwpt);"

>  	}
> -
>  	igroup->hwpt = hwpt;
>  
>  	/*