Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Sat, 7 Oct 2023 18:08:05 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Yi Liu <yi.l.liu@intel.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <nicolinc@nvidia.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 03/17] iommufd: Unite all kernel-managed members into
 a struct
Message-ID: <ZSEuBcLaSq4NjoC8@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-4-yi.l.liu@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230921075138.124099-4-yi.l.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9EDe8ugVmNDfR8cP2O/GVTYAkLVAiqGrstOIstnW6v0dM/REpHero4epKBdi?=
 =?us-ascii?Q?SICbnrIeH3iEgqiw8KrAmJKs2Vy32ddQcHkbPicjMBW9H5cwz4LzAPhnZBeL?=
 =?us-ascii?Q?f5xu/rkgTphjbFoYI/8ZpCD5jNiH3hEKuuDeOZkYRfzVuN1n+W2pkiVHMKjm?=
 =?us-ascii?Q?jq7GS1ayJ93/cV81iN+ofO4oyrbVYkK1sb2QK6/HODfZYQXvoyGfGg8+W7b6?=
 =?us-ascii?Q?AapQWMGgjSDmcQqrt4yMtMmbTGIQplihRr2Bm50apIzSRvOQBH4kzmEz+PXY?=
 =?us-ascii?Q?0Rp27giI/zXhrwmx+oiPFCFuxuUcbq9lwZdckKRbkU+Z0Q1XIv3Bla/pSmt7?=
 =?us-ascii?Q?k9E3dfiYG1S6W1yHtrM2hqYo9Fjs/TDLCE8KamEOGyXvj6G6rGELHE38Ykkj?=
 =?us-ascii?Q?RciS1DDF1TOVbtVFXt+thCfg7G+TGzU5X52zTwp6SlPUProGtWWWAMHtlbJj?=
 =?us-ascii?Q?Jgv0Jf/6q5UzSMQOzuBNKG6pkTkbathxLuExKa669l3PBsPXhIVH9/C1qZ2o?=
 =?us-ascii?Q?DReoh9X+jX68gXCNrqYHfPsbA2outJexQT+l8poK3kyH2BqQ2DaLFdcQwwT/?=
 =?us-ascii?Q?B5/F0MhYfJ48Olv75/U53t8aiTZCGiCW+oHnKOkTzsNS/cOmZddJjVFw0V/X?=
 =?us-ascii?Q?rAUcQ9AlopL/za1fxTnlE70rTQYXiLVo2CFfwb23FwRbIVY8H8B4H15hd4+W?=
 =?us-ascii?Q?xjHttFNCVSGjNcFn0j1P0YA3ts4dJEiK9WIM+KzvDFI2jnIrikETliA/Fr5Y?=
 =?us-ascii?Q?34At6Q9yJud/6N80GVhg7Jobki48d0YVD0WYeTg7QEfA0DqQRDWUlIZ6OW82?=
 =?us-ascii?Q?Wm8s/i2EATMQ2agq5n9ywpdIAI20whmkyfBlGgWrdrN1pq3JgBRX8wyHRfnk?=
 =?us-ascii?Q?0tEYt79/Vs6T9UxHc+bgAH0qpp0ocG02cuO7EyLC0CuVgYpQn88ydfjSQVS4?=
 =?us-ascii?Q?9wQ0j6qigA1qb0tMEeiC1y0+cyysMwsp8wmWdDH/DJDVJ0ocj+nlSvaAToqJ?=
 =?us-ascii?Q?tl153dt+hl4AaZSm9jEjaX0DBotiwrwv3yr9gw64c/psehoXZLzIgEKrKl3y?=
 =?us-ascii?Q?RFHOABB9HJ/qEnJG7bZfXRIiIPVKfJhCq+Eetu0OL98MFNwvdThuzefUP4RU?=
 =?us-ascii?Q?j91a5LYCvyzU5/vm+QpsWOuLbbi5QlvLkQjLcUhfgZjzavG+U6HsL+Ye5+GH?=
 =?us-ascii?Q?dT6vjGgVrXIXq/Eg0XJ/rkQza4s+ZMX2o7aR5GRsO6ET+sa8TyU2U3Sx34ZT?=
 =?us-ascii?Q?jf0Kdigae4rDervGgef7ovmkv61ryju5Nhs/RjwhrJ702SlFCrzJXO65J/qi?=
 =?us-ascii?Q?iOqDBAWJi9KOyxtayed8KeM4UdGUOCeWMzfKm3csRX4ZiUqq95/NiPIVKJAu?=
 =?us-ascii?Q?VdFKJs23tRPL561No0x6IcbHBiD6mbtNV8yebq6MI1xEWW9wGqmKbc0pRIU1?=
 =?us-ascii?Q?tWJ1FZHNFBGqmYdOelXuwZjkKw0olzB8JS7/bqmiBhgotLOa+t4rUdGAuTRT?=
 =?us-ascii?Q?h7ZRoYoeiXhMRJJSNPulrvqEL3rdcx/A0uVH04pNV55prhGMuDSBaIWLjoeX?=
 =?us-ascii?Q?H/ZV2Gqwv7EvdWgjRXNxjvA/0Am4Zl6dS1tyUxc6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b37eb30-3195-41f0-5acf-08dbc72139c0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2023 10:36:12.2076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e6sOuNjcw2RI6q1iPRpWbJjw4c0p056wbRumPShpwCtuAWDncGpW3njqnN5iYW7BDLxBNR96nFtyxRr/U2BTWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8195
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 07 Oct 2023 03:36:37 -0700 (PDT)
X-Spam-Level: **

On Thu, Sep 21, 2023 at 12:51:24AM -0700, Yi Liu wrote:
> From: Nicolin Chen <nicolinc@nvidia.com>
> 
> The struct iommufd_hw_pagetable has been representing a kernel-managed
> HWPT, yet soon will be reused to represent a user-managed HWPT. These
> two types of HWPTs has the same IOMMUFD object type and an iommu_domain
> object, but have quite different attributes/members.
> 
> Add a union in struct iommufd_hw_pagetable and group all the existing
> kernel-managed members. One of the following patches will add another
> struct for user-managed members.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/iommu/iommufd/iommufd_private.h | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h
> index 3064997a0181..947a797536e3 100644
> --- a/drivers/iommu/iommufd/iommufd_private.h
> +++ b/drivers/iommu/iommufd/iommufd_private.h
> @@ -231,13 +231,18 @@ int iommufd_vfio_ioas(struct iommufd_ucmd *ucmd);
>   */
>  struct iommufd_hw_pagetable {
>  	struct iommufd_object obj;
> -	struct iommufd_ioas *ioas;
>  	struct iommu_domain *domain;
> -	bool auto_domain : 1;
> -	bool enforce_cache_coherency : 1;
> -	bool msi_cookie : 1;
> -	/* Head at iommufd_ioas::hwpt_list */
> -	struct list_head hwpt_item;
> +
> +	union {
> +		struct { /* kernel-managed */
> +			struct iommufd_ioas *ioas;
> +			bool auto_domain : 1;
Will iommufd_hw_pagetable_put() also be called on non-kernel-managed domain?
If yes, hwpt->user_managed needs to be checked in iommufd_hw_pagetable_put(),
(e.g. as below).
Otherwise, this union will lead to hwpt->ioas and hwpt->auto_domain still being
accessible though invalid.


 static inline void iommufd_hw_pagetable_put(struct iommufd_ctx *ictx,
                                            struct iommufd_hw_pagetable *hwpt)
 {
-       lockdep_assert_not_held(&hwpt->ioas->mutex);
-       if (hwpt->auto_domain)
+       if (!hwpt->user_managed)
+               lockdep_assert_not_held(&hwpt->ioas->mutex);
+
+       if (!hwpt->user_managed && hwpt->auto_domain)
                iommufd_object_deref_user(ictx, &hwpt->obj);
        else
                refcount_dec(&hwpt->obj.users);
}

> +			bool enforce_cache_coherency : 1;
> +			bool msi_cookie : 1;
> +			/* Head at iommufd_ioas::hwpt_list */
> +			struct list_head hwpt_item;
> +		};
> +	};
>  };
>  
>  struct iommufd_hw_pagetable *
> -- 
> 2.34.1
>