Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp896973rdb; Sat, 7 Oct 2023 03:51:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjFQHjctQBijU1pNkHmay9oMUZdcv/WAW7sIdwK8qaPp5U23KYqeuaAFc7amGWVUU7jcGh X-Received: by 2002:a05:6a20:72a8:b0:134:a478:5e4a with SMTP id o40-20020a056a2072a800b00134a4785e4amr11589818pzk.17.1696675867375; Sat, 07 Oct 2023 03:51:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696675867; cv=none; d=google.com; s=arc-20160816; b=ilmG7+1zlyR2FK9lFGeys4nlVMRp5rCpwMnHWDraBxTkQ9UBxO3MVakwSjlpt+IPBe XVgsgkqgysVmVrJ8nV4oQ8I8UsQMkOFAYom8gWfQvXpTV0zKFHEN7r9ZOreRzxuSpUuR k5uWfaWiZCIsKD+p5AuTYWReeYnXg35dmY6Cc+yGrUudejF5L8JquX9KuwdWKHmTQbzq UBVMX016Y2r+pYwLL9Gfj5wq1f2JpXyBzVGa08ygJ0niANSWfDH8lq0BHWHxEdZVCV2W Y5nsE5kJvANjMbUCAWjv7JFPU66zzpeXHh1kmqShguRNrff28tAfECMe0VEhl7VR1VZD 0IGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=62JvxO2pbLFRhSQQTQWrBM5WkDHQ/HfWYltRvLg20mA=; fh=EqC8YIf76J2t6bkrfg/kxo6KxGiCTF+CC8UgDK+eaO4=; b=Qfkyix9YfNgJBXbvQ8moIT5k0AfprI5+YjKSO2yXB86i0RM5Se/Bs4JC1WczcmPN+n PkTrd0JBMssnNbTRVrWsxPeUuqK3zyvgO90z0zmXTep1tH1wQgLYsg7G9xkQxDa6No7C 6z5qUrJ9iLZk43DfhAY1LQqU+K4x47fFkSU3m+JS1v4rMx7nPLs/K/VdoN0eOkXMhVj9 CNXbEfHtR9qS7y1WeIhA/HgFsRIEP6f5kq967M676sJ5jNEOYWSbDs9qVoXsV8mryOMd +1pgugWlsLsnPJBlV93AnqU1YQnU30bU9d+yh1LZLtj19v8V+mu6ETaZdn5+AmI6u3m+ Pjxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id b10-20020a170902d50a00b001bf1d1d99b0si6191083plg.568.2023.10.07.03.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:51:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id ABB5E8030FB0; Sat, 7 Oct 2023 03:51:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343834AbjJGKu5 (ORCPT + 99 others); Sat, 7 Oct 2023 06:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343792AbjJGKuy (ORCPT ); Sat, 7 Oct 2023 06:50:54 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A6A89E; Sat, 7 Oct 2023 03:50:52 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qp4t1-0005zZ-Dj; Sat, 07 Oct 2023 12:50:19 +0200 Date: Sat, 7 Oct 2023 12:50:19 +0200 From: Florian Westphal To: George Guo Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, George Guo Subject: Re: [PATCH] tcp: fix secure_{tcp, tcpv6}_ts_off call parameter order mistake Message-ID: <20231007105019.GA20662@breakpoint.cc> References: <20231007092337.1540036-1-dongtai.guo@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007092337.1540036-1-dongtai.guo@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 07 Oct 2023 03:51:04 -0700 (PDT) X-Spam-Level: ** George Guo wrote: > From: George Guo > > Fix secure_tcp_ts_off and secure_tcpv6_ts_off call parameter order mistake Could you please send a v2, targetting net-next, that clearly says that this is a cleanup? [ It doesn't matter if we pass "saddr, daddr" or "daddr, saddr" as long as both "init" and "check" functions agree on the ordering ]