Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp897789rdb; Sat, 7 Oct 2023 03:53:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1xevgW6nluJ3sTF6XmofmCGYdvOO+4/0lRd5tyT5btmlnEn6J/q0RhNvZ1j+XH7FAcdf8 X-Received: by 2002:a05:6a00:852:b0:68f:efc2:ba3d with SMTP id q18-20020a056a00085200b0068fefc2ba3dmr11928028pfk.33.1696676032285; Sat, 07 Oct 2023 03:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696676032; cv=none; d=google.com; s=arc-20160816; b=iZsVvxPopQz4EMVjBq2YKpg3woEqIZ8prWwZRnM8hVW907sepr3u6xNHZZXrKOXk0j vBkWW52KeiHt3XGY4z/F/Ojsta/UE+IkjAmDa32IhEgToTpTqN8U+1RmQwR37BdMyX+8 4okBJwD8kdNdVMV7kedHu6gMopBubtW01E0KJKvmRGWSZODiDZCaD70K78/JPpDF3D4Y OGWtErEUWImFN2Tnj3Xf/754tfnJRmvPFfB2luegwEkAWMs7lEaEiefs3GfTIDIll1rJ 7iT3LkHrcyOYEthQCbj+9dg8CmtddclwjSPzMm4ike6NllgYZIuAW1y+7/ptZu3Gsvhw EqWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6e3FXP1EedvBEgpIF55PelzMQ2GgSmOd4Ztnd2j1lmI=; fh=nTU2ozkDXaXn4jobhmt+bfnQqLvJV3DyUFHFxbPqneI=; b=TKjxnZQXNizTDry48WtxpBnoaPD+0/8pCpnES3/R+hQvkn6yX3CE6QaVL2W7v63D9W PbbOozBYR0uQkpmF6A7IdIxHgOMFk3q0tr6UCzEzLc5EfWk3w7IajmlJ4eu/q2zQVegZ RbP5Jo/BYaT92VVhK4bTrkZjyrUpLu2JvK8TpVtVEAE6fQ81wK0S9k0CraAqisLY8zmG 01b7oi6h2Ji0Zk0YppnbJkHFwkQkB5scfOxFQX6rDohw5C0yrZJOQeDp5pKPHhptmHeB 7kfFZU4e6cgdE36QpbdllzRPUZPaTCSmkBN1pYdCwIfjE3IUw9rcVlOS89anxbuD2GSP dmLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id w4-20020a056a0014c400b00690f886b1bcsi3388421pfu.392.2023.10.07.03.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 193DB8092C93; Sat, 7 Oct 2023 03:53:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343819AbjJGKxm (ORCPT + 99 others); Sat, 7 Oct 2023 06:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343782AbjJGKxm (ORCPT ); Sat, 7 Oct 2023 06:53:42 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C1E92; Sat, 7 Oct 2023 03:53:41 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qp4wB-00060Y-2a; Sat, 07 Oct 2023 12:53:35 +0200 Date: Sat, 7 Oct 2023 12:53:35 +0200 From: Florian Westphal To: George Guo Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, George Guo Subject: Re: [PATCH] netfilter: remove inaccurate code comments from struct nft_table Message-ID: <20231007105335.GB20662@breakpoint.cc> References: <20231007102528.1544295-1-dongtai.guo@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007102528.1544295-1-dongtai.guo@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 07 Oct 2023 03:53:50 -0700 (PDT) X-Spam-Level: ** George Guo wrote: > From: George Guo > > afinfo is no longer a member of struct nft_table, so remove the comment > for it. Correct, but could you please send a v2 that fixes up all the comments and gets them back in sync with the structure? Eg. nlpid, family, udlen and udata exist in struct but are not mentioned in the comments.