Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <a04f2f27-e746-2b28-ec58-66041def9645@quicinc.com>
Date:   Sat, 7 Oct 2023 19:43:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.3
Subject: Re: [PATCH] binder: add mutex_lock for mmap and NULL when free
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <gregkh@google.com>, <cmllamas@google.com>, <surenb@google.com>,
        <arve@android.com>, <joel@joelfernandes.org>, <brauner@kernel.org>,
        <tkjos@android.com>, <maco@android.com>,
        <linux-kernel@vger.kernel.org>
References: <20231007034046.2352124-1-quic_yingangl@quicinc.com>
 <2023100715-blade-valiant-714d@gregkh>
 <26988068-8c9f-8591-db6e-44c8105af638@quicinc.com>
 <2023100725-oversized-shore-c873@gregkh>
 <12642deb-0db3-9210-b468-1872cd3d5409@quicinc.com>
 <2023100735-dullness-cameo-2666@gregkh>
From:   Kassey Li <quic_yingangl@quicinc.com>
In-Reply-To: <2023100735-dullness-cameo-2666@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/10/7 19:37, Greg KH wrote:
> On Sat, Oct 07, 2023 at 07:34:05PM +0800, Kassey Li wrote:
>>
>>
>> On 2023/10/7 19:18, Greg KH wrote:
>>> On Sat, Oct 07, 2023 at 07:07:40PM +0800, Kassey Li wrote:
>>>>
>>>>
>>>> On 2023/10/7 14:44, Greg KH wrote:
>>>>> On Sat, Oct 07, 2023 at 11:40:46AM +0800, Kassey Li wrote:
>>>>>> Enforce alloc->mutex in binder_alloc_mmap_handler when add
>>>>>> the entry to list.
>>>>>>
>>>>>> Assign the freed pages/page_ptr to NULL to catch possible
>>>>>> use after free with NULL pointer access.
>>>>>>
>>>>>> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
>>>>>> ---
>>>>>>     drivers/android/binder_alloc.c | 5 ++++-
>>>>>>     1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> What commit id does this fix?
>>>>
>>>>     there is no specific commit id this change going to fix.
>>>>
>>>>     it is a follow up for commit
>>>> 	19c987241ca1216a51118b2bd0185b8bc5081783  binder: separate out binder_alloc
>>>> functions (mutex lock added for list access in alloc/free)
>>>> 	f2517eb76f1f2f7f89761f9db2b202e89931738c  android: binder: Add global lru
>>>> shrinker to binder (set page->page_ptr = NULL;)
>>>>
>>>>     the background to raise this change that we are easy hit below crash in
>>>> monkey test:
>>>>
>>>> where a wrong end is passing to
>>>> binder_update_page_range, thus calculate a weird index
>>>> for
>>>>     page = &alloc->pages[index]
>>>
>>> Obviously it is a fix for some commit, please list that here.
>>
>>   ok, please kindly review this patch description according your suggest, i
>> can re-send v2 patch again.
>>
>> commit 16aaeb8556ff4eb75823c56773ee82b06bac44a0 (HEAD -> master)
>> Author: Kassey Li <quic_yingangl@quicinc.com>
>> Date:   Thu Sep 28 10:42:52 2023 +0800
>>
>>      binder: add mutex_lock for mmap and NULL when free
>>
>>      -Enforce alloc->mutex in binder_alloc_mmap_handler when add
>>      the entry to list.
>>
>>      -Assign the freed pages/page_ptr to NULL to catch possible
>>      use after free with NULL pointer access.
> 
> Odd indentation :(

thanks for the quick suggest and review, based on this version, will do 
below and send patch v2.

./scripts/checkpatch.pl 
0001-binder-add-mutex_lock-for-mmap-and-NULL-when-free.patch
total: 0 errors, 0 warnings, 26 lines checked

0001-binder-add-mutex_lock-for-mmap-and-NULL-when-free.patch has no 
obvious style problems and is ready for submission.

> 
>>      Fixes: 19c987241ca1 ("binder: separate out binder_alloc functions")
>>      Fixes: f2517eb76f1f ("android: binder: Add global lru shrinker to
>> binder")
>>      Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
> 
> Looks better than before, thanks.
> 
> greg k-h