Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1219755rdb; Sat, 7 Oct 2023 19:11:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLMyBansKQpQgws/G17Y/Nx2FzeMJaw/MwouS0MCy7Akg5h1KFXwmlu1PCaXzgjf+3t/7z X-Received: by 2002:a05:6808:2189:b0:3ae:61f:336c with SMTP id be9-20020a056808218900b003ae061f336cmr15811429oib.8.1696731095472; Sat, 07 Oct 2023 19:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696731095; cv=none; d=google.com; s=arc-20160816; b=NE7cGl4ir3xZcoiLNsHE4voOzx4bL1Upymu9okxKU8KV8/VFTdAtgt6iPfsS6B5shd 8JzLPOI0w2jlLkVG4CFtUqnqEGInZSE4pqqmlTANIchQB/ukBbj6KxySq4LpYyApMyyR plUPc0oAsikgT9TqGzJxLJjQSd8rCiejwofirHoMLBp6fvOIJEQHvsEbNO41NtLdKhOp sLj7jdzQ/44/yRzAi7hj7O29T/GMtxhS5k6p3KFLGTrm/AUAgy8MCzay00N2aS2u6W3Q b/y8bvg9cIEbwphvN/61oRRD+BKrw9nMkNtHtpSjZxiT0J9Ap80+S4DenL+ycn3cYOqQ A2Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; fh=GDXD2QuaLxZ+ybjJdWUrCpqUelCyXZ5otL33+DhMFV0=; b=n43MmfVVQ2XmToiTTu8YqvR5KsrNUWMwvZThrqkBkG5ZXnIZSBCfPinzpouWn8fUah 3Tp3pcNy87Rbe/S0nXZzNuKDDm8LGLvDIpNeaBJ2k9vjZekx+1Pv7jRJD92zBxmHHxm/ ryEgFSDC292iuLhU2V246ZuMBHpbxEyAHc/enBwRUgEs0TUHAHkUIq12hQVMHuNbduZu b05l3TQ4ZbX/OmH4YhfUhGqqw9EdjoYiuNEADZYm9QC3iFHt5QkWmujG0lfAfdj96x7H VpYIfg8XZDoQpUQuPuJ3RP/x4QGuQC/Ske92ozzufty4NDosGRAbED0dubc5FKY1c0Z2 Nh4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Te+c3TfV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id 33-20020a631861000000b0056603994af8si6631267pgy.666.2023.10.07.19.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 19:11:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Te+c3TfV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EB045803426D; Sat, 7 Oct 2023 19:11:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344304AbjJHCLN (ORCPT + 99 others); Sat, 7 Oct 2023 22:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344297AbjJHCLN (ORCPT ); Sat, 7 Oct 2023 22:11:13 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC5EEB9 for ; Sat, 7 Oct 2023 19:11:11 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5859e22c7daso2195839a12.1 for ; Sat, 07 Oct 2023 19:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696731071; x=1697335871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; b=Te+c3TfVVtPuotDCWaPfseQfxkjKDUiRH0POjcAeRFtszYht9Q0P2fYWLmkWZJBHuu qCmCVVqzQ2+B54YxncWM1ergWY+sZnjF/CbU9J2lDZOxAACFvx7fY6XnjAL7+EyrTNUI CEDztrgAi4OT9Dq+zLjlxxYuL762TUpBaee07MsXDjq2aep057c6v5AH39+tVslrFzqJ CHYOLhmHE2Vc8Sl2W/7450tWvdfTYdzItw1ryhkItQ7WR67RdGHTk6Xsg3E1Lsbvca54 1X0LnciWqzL/MwGjbAg6YIyxuMaCxRZr38JVI3k/PX0Vjp2SoXIbj6joKvUDLDQVXdBW nqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696731071; x=1697335871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; b=WIVEnnQKOVXAdASqrQtyR456dNOjAiuxStFIDmjGrMzz9S7N8WY59m2Llspd7RV7A8 hW5vFHp76IsnZhi4j/Q5/F9G7SC3s3+XMxXwHo91XLVgh4N0QV27hrm5C2eygdcmS5XE 8y32XzuYC04LKe+oxT5rm+SQtv6ZKos//2flWL2Yr+Vb6qMudGAXSUq69TjWloZc6ems XmC9a84i4yLTmPi8EBc+dz4NNrfDguDYCjgOZUhREpd74kyIsPJOdZBxSE4WmJobyN4J gpEXyKYELQFSgkP5DY8pF9ds4zxK4jdKlchPcRyb1eGWxixEuPO0gLprnrBQiAK7SoOK V1FA== X-Gm-Message-State: AOJu0YxwJiaIRGfJeyB1xAtEmBqeytb6MF7hD+68muUioF2RasTvi5x6 FB/vUHT3rMm6I2rSNyy/WGE= X-Received: by 2002:a05:6a00:124a:b0:690:ce30:47e5 with SMTP id u10-20020a056a00124a00b00690ce3047e5mr12206836pfi.6.1696731071139; Sat, 07 Oct 2023 19:11:11 -0700 (PDT) Received: from ubuntu.. ([223.178.246.252]) by smtp.gmail.com with ESMTPSA id x8-20020aa784c8000000b00690fdeb5c0dsm3746125pfn.2.2023.10.07.19.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 19:11:10 -0700 (PDT) From: Pavan Bobba To: Pavan Bobba , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Pavan Bobba Subject: [PATCH Date: Sun, 8 Oct 2023 07:40:53 +0530 Message-Id: <6894dff7cc5a780627e0335e8f5cdc8b353eea53.1696729776.git.opensource206@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 07 Oct 2023 19:11:33 -0700 (PDT) X-Spam-Level: ** array name "abyBBVGA" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba --- drivers/staging/vt6655/baseband.c | 38 ++++++++++++++-------------- drivers/staging/vt6655/channel.c | 4 +-- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 8 +++--- 4 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 0ae2ab3987c6..a19a75f5d761 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -2016,10 +2016,10 @@ bool bb_vt3253_init(struct vnt_private *priv) iowrite32(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); } - priv->abyBBVGA[0] = 0x18; - priv->abyBBVGA[1] = 0x0A; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x18; + priv->bbvga[1] = 0x0A; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -50; priv->dbm_threshold[2] = 0; @@ -2034,10 +2034,10 @@ bool bb_vt3253_init(struct vnt_private *priv) result &= bb_write_embedded(priv, vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); - priv->abyBBVGA[0] = 0x1C; - priv->abyBBVGA[1] = 0x10; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x1C; + priv->bbvga[1] = 0x10; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -48; priv->dbm_threshold[2] = 0; @@ -2056,10 +2056,10 @@ bool bb_vt3253_init(struct vnt_private *priv) iowrite8(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); - priv->abyBBVGA[0] = 0x14; - priv->abyBBVGA[1] = 0x0A; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x14; + priv->bbvga[1] = 0x0A; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -60; priv->dbm_threshold[1] = -50; priv->dbm_threshold[2] = 0; @@ -2074,10 +2074,10 @@ bool bb_vt3253_init(struct vnt_private *priv) result &= bb_write_embedded(priv, vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); - priv->abyBBVGA[0] = 0x1C; - priv->abyBBVGA[1] = 0x10; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x1C; + priv->bbvga[1] = 0x10; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -48; priv->dbm_threshold[2] = 0; @@ -2088,7 +2088,7 @@ bool bb_vt3253_init(struct vnt_private *priv) } else { /* No VGA Table now */ priv->bUpdateBBVGA = false; - priv->abyBBVGA[0] = 0x1C; + priv->bbvga[0] = 0x1C; } if (by_local_id > REV_ID_VT3253_A1) { @@ -2126,7 +2126,7 @@ bb_set_short_slot_time(struct vnt_private *priv) /* patch for 3253B0 Baseband with Cardbus module */ bb_read_embedded(priv, 0xE7, &by_bb_vga); - if (by_bb_vga == priv->abyBBVGA[0]) + if (by_bb_vga == priv->bbvga[0]) by_bb_rx_conf |= 0x20; /* 0010 0000 */ bb_write_embedded(priv, 0x0A, by_bb_rx_conf); /* CR10 */ @@ -2140,7 +2140,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data) bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */ /* patch for 3253B0 Baseband with Cardbus module */ - if (by_data == priv->abyBBVGA[0]) + if (by_data == priv->bbvga[0]) by_bb_rx_conf |= 0x20; /* 0010 0000 */ else if (priv->short_slot_time) by_bb_rx_conf &= 0xDF; /* 1101 1111 */ diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c index e90e0b43505d..e20701815db9 100644 --- a/drivers/staging/vt6655/channel.c +++ b/drivers/staging/vt6655/channel.c @@ -87,8 +87,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch) /* Set VGA to max sensitivity */ if (priv->bUpdateBBVGA && - priv->byBBVGACurrent != priv->abyBBVGA[0]) { - priv->byBBVGACurrent = priv->abyBBVGA[0]; + priv->byBBVGACurrent != priv->bbvga[0]) { + priv->byBBVGACurrent = priv->bbvga[0]; bb_set_vga_gain_offset(priv, priv->byBBVGACurrent); } diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index 8c90539cc3d7..b662c74a2dc7 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -250,7 +250,7 @@ struct vnt_private { unsigned int uBBVGADiffCount; unsigned char byBBVGANew; unsigned char byBBVGACurrent; - unsigned char abyBBVGA[BB_VGA_LEVEL]; + unsigned char bbvga[BB_VGA_LEVEL]; long dbm_threshold[BB_VGA_LEVEL]; unsigned char byBBPreEDRSSI; diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index f76f482f4c06..385848df8848 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -424,9 +424,9 @@ static void device_init_registers(struct vnt_private *priv) bb_vt3253_init(priv); if (priv->bUpdateBBVGA) { - priv->byBBVGACurrent = priv->abyBBVGA[0]; + priv->byBBVGACurrent = priv->bbvga[0]; priv->byBBVGANew = priv->byBBVGACurrent; - bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]); + bb_set_vga_gain_offset(priv, priv->bbvga[0]); } bb_set_rx_antenna_mode(priv, priv->byRxAntennaMode); @@ -1053,7 +1053,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv) for (i = 0; i < BB_VGA_LEVEL; i++) { if (dbm < priv->dbm_threshold[i]) { - priv->byBBVGANew = priv->abyBBVGA[i]; + priv->byBBVGANew = priv->bbvga[i]; break; } } @@ -1510,7 +1510,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, priv->short_slot_time = false; CARDbSetPhyParameter(priv, priv->byBBType); - bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]); + bb_set_vga_gain_offset(priv, priv->bbvga[0]); } if (changed & BSS_CHANGED_TXPOWER) -- 2.34.1