Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Sun, 8 Oct 2023 14:19:18 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yang Weijiang <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dave.hansen@intel.com>,
        <peterz@infradead.org>, <rick.p.edgecombe@intel.com>,
        <john.allen@amd.com>
Subject: Re: [PATCH v6 16/25] KVM: x86: Report KVM supported CET MSRs as
 to-be-saved
Message-ID: <ZSJJ5jlNtgrVP+Qw@chao-email>
References: <20230914063325.85503-1-weijiang.yang@intel.com>
 <20230914063325.85503-17-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230914063325.85503-17-weijiang.yang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MeSxji5tsyuGo2JhmBJAszDlXI3NLl2+iMooVyty9G/YDrpqarww/WbuviHw?=
 =?us-ascii?Q?lyPkNrwhdm8XAWDWiQDOcafkNJhTej7c57rYjI+Qwook3zZLiQGlIc/cPXcz?=
 =?us-ascii?Q?MOBMQ1su4OZyYtvzpLf+KWBHe5LCg+O75nWQ4lAsr6WpIHTmCPNcKsRlrRU+?=
 =?us-ascii?Q?qJbS3eJ3Xnu+wo/hyEYuINEOiARZl+2pQ17rSRKnGHFPtHqc4UvvVFtEphp/?=
 =?us-ascii?Q?EEoVJlmIN1k02+iTE2TmKGwgjYWOeXTpvTOEaalOpFls/N6nrTteV2/kT7B4?=
 =?us-ascii?Q?q6hqKg1kR2AqZqJXLqplKP0uvb1WTBpielGLNfgIMTpCQHJfxoPLvsRRVsg5?=
 =?us-ascii?Q?RLZikaHcJNBfjmKkaCelpf3oXfj9hB+5tcpV3fTYVFHQrbghgXv2NUggjufk?=
 =?us-ascii?Q?lHd+BHuryxcBHcDVgchROXHkaDlwkaLjsXgM4Ox8fL4J2c9Of909UpNa52Na?=
 =?us-ascii?Q?obre68PmWIttRhFBsNuWmIDHwmqrCGeTznz7rpp1kbUch/JwRPP7JFr5cOw6?=
 =?us-ascii?Q?WMPsYdpveicBeQIgI+UcJJG+7GoVs1ZUpUNlw0J5wvJ7IApXmrKvqsOlA4r7?=
 =?us-ascii?Q?Vvc+AUeCYXvL3jP32PnmeyxvmIoMGvDHvzMA9ii7v12/WgRmIyKI2TH6I+4U?=
 =?us-ascii?Q?fEhLfwcRTpDJqTB+V/ptKbUePQfmz/E+Ti66I87HR+JKsEjEQvaAuQQuvu2u?=
 =?us-ascii?Q?9QuKTr0A3MCUVKjzj/ai8jhjTixsIPufN/u2WhwiZocKIGgyl9kqYOcdjFwe?=
 =?us-ascii?Q?3eWd15soIvsqh7vbWMXC7guSYaU2XgfROJE6yEyFHkWwXPmPwlnItzIZaV9O?=
 =?us-ascii?Q?COVECMlpfxN+ImWh47iExfedb8r2CH+xE90vd1yr+1dKpcdnLn/YURmvk8n6?=
 =?us-ascii?Q?IdmBs8y/daLlSdPOV6EECxdKvSMbfHtb80NMHCVIvNS5blOblQNkdZE238nL?=
 =?us-ascii?Q?Fi6pgV8nNk5AZPm5Ob5N4xQuJQ9sSQQ9afy7Vt1rAdN7DOM6M/gS3r32AuP4?=
 =?us-ascii?Q?eX2ZbfyhBQRW9CUYQdvSBUM9NpfVBJn8AG9hEyiqbXBWFgWTTuOBZAiDeElP?=
 =?us-ascii?Q?LAnaHhCapP+5bLAIKo6NEVkk6T+OPyVf9TMeFCA9UiGDXXXtPymFK9yk4IIa?=
 =?us-ascii?Q?4YmbnnVKje3JafYvyGGJnP1s+TQoEO4znBKajTPh9RTkPnwNPHEgBwwo6YRp?=
 =?us-ascii?Q?fcylfft153n8h+b7ddSixutYWPGjzgA60cMdsBjtQib37hF3zpwbCCCh3H1f?=
 =?us-ascii?Q?v1BXN8RD22ycml/+OYRrruBY1pC8f0bPuAyQYg7M9EMbqG8Vi/qgUdOdUQxp?=
 =?us-ascii?Q?bDV8Ohj08HdWhZyPiieOvQ91WDjunTG0qmBH/zDsdWnrqYWZWfJtFX5Y6bye?=
 =?us-ascii?Q?IZs72anTrb+mb6MZdBl6qtn+owcqgrVc4Aj7XtyB01tpdzOD85FvOzUFP4Si?=
 =?us-ascii?Q?wyOXSm/6f35PXsJfB/uiaHwpAVAv6u77dWCnx+wQ1NsbMQCxvkMtsVujqAyo?=
 =?us-ascii?Q?WazylS69+qkku9m1tAk0zSAWXdSEynF7Ny0MpWNK1Z6+QqY8CtiyFb7DcyUa?=
 =?us-ascii?Q?aQizwx8Fk0HBUuZ+2Ovz8JPfvWy3VkOGguhaUNp1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 063b2226-0c6b-4648-a170-08dbc7c68767
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2023 06:19:29.5827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kJnsewsPfz1Sh59EYuh63SMsYLl4qyDxBMCndADjp0eIGwN91/xfVNHgcfp0S6Mj4JUkwLr2PH5kA/gxvvrFhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6557
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 07 Oct 2023 23:25:10 -0700 (PDT)
X-Spam-Level: **

On Thu, Sep 14, 2023 at 02:33:16AM -0400, Yang Weijiang wrote:
>Add CET MSRs to the list of MSRs reported to userspace if the feature,
>i.e. IBT or SHSTK, associated with the MSRs is supported by KVM.
>
>SSP can only be read via RDSSP. Writing even requires destructive and
>potentially faulting operations such as SAVEPREVSSP/RSTORSSP or
>SETSSBSY/CLRSSBSY. Let the host use a pseudo-MSR that is just a wrapper
>for the GUEST_SSP field of the VMCS.
>
>Suggested-by: Chao Gao <chao.gao@intel.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>---
> arch/x86/include/uapi/asm/kvm_para.h |  1 +
> arch/x86/kvm/vmx/vmx.c               |  2 ++
> arch/x86/kvm/x86.c                   | 18 ++++++++++++++++++
> 3 files changed, 21 insertions(+)
>
>diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h
>index 6e64b27b2c1e..9864bbcf2470 100644
>--- a/arch/x86/include/uapi/asm/kvm_para.h
>+++ b/arch/x86/include/uapi/asm/kvm_para.h
>@@ -58,6 +58,7 @@
> #define MSR_KVM_ASYNC_PF_INT	0x4b564d06
> #define MSR_KVM_ASYNC_PF_ACK	0x4b564d07
> #define MSR_KVM_MIGRATION_CONTROL	0x4b564d08
>+#define MSR_KVM_SSP	0x4b564d09
> 
> struct kvm_steal_time {
> 	__u64 steal;
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 72e3943f3693..9409753f45b0 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -7009,6 +7009,8 @@ static bool vmx_has_emulated_msr(struct kvm *kvm, u32 index)
> 	case MSR_AMD64_TSC_RATIO:
> 		/* This is AMD only.  */
> 		return false;
>+	case MSR_KVM_SSP:
>+		return kvm_cpu_cap_has(X86_FEATURE_SHSTK);

For other MSRs in emulated_msrs_all[], KVM doesn't check the associated
CPUID feature bits. Why bother doing this for MSR_KVM_SSP?