Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com> <20231006141750.5423083520f74bc0746fd249@linux-foundation.org>
In-Reply-To: <20231006141750.5423083520f74bc0746fd249@linux-foundation.org>
From:   Zhaoyang Huang <huangzhaoyang@gmail.com>
Date:   Sun, 8 Oct 2023 15:54:40 +0800
Message-ID: <CAGWkznHqQHMN1QXz7os7AQTYdzc3+LEq+z2bWOzLbiseV=560A@mail.gmail.com>
Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Roman Gushchin <guro@fb.com>, Minchan Kim <minchan@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ke.wang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Oct 7, 2023 at 5:17=E2=80=AFAM Andrew Morton <akpm@linux-foundation=
.org> wrote:
>
> On Thu, 11 May 2023 13:22:30 +0800 "zhaoyang.huang" <zhaoyang.huang@uniso=
c.com> wrote:
>
> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > Let us look at the timeline of scenarios below with WMARK_LOW=3D25MB WM=
ARK_MIN=3D5MB
> > (managed pages 1.9GB). We can find that CMA begin to be used until 'C' =
under the
> > method of 'fixed 2 times of free cma over free pages' which could have =
the
> > scenario 'A' and 'B' into a fault state, that is, free UNMOVABLE & RECL=
AIMABLE
> > pages is lower than corresponding watermark without reclaiming which sh=
ould be
> > deemed as against current memory policy. This commit try to solve this =
by
> > checking zone_watermark_ok again with removing CMA pages which could le=
ad to a
> > proper time point of CMA's utilization.
> >
> > -- Free_pages
> > |
> > |
> > -- WMARK_LOW
> > |
> > -- Free_CMA
> > |
> > |
> > --
> >
> > Free_CMA/Free_pages(MB)      A(12/30) -->  B(12/25) -->  C(12/20)
> > fixed 1/2 ratio                 N             N           Y
> > this commit                     Y             Y           Y
> >
>
> Roman previously asked
>
> : Also I'm a bit concerned about potential performance implications.
> : Would be great to provide some benchmarks or some data.  Probably it's
> : ok because of we have pcp caches on top, but I'm not 100% sure.
>
> Are you able to perform such testing and tell us the result?
I have applied this patch in a v5.4 based ANDROID system and got no
regression problem. Actually, this commit is aimed to have
alloc_pages(GFP_USER) use CMA instead of stealing U&R(could lead to
GFP_KERNEL fail) only when zone's free pages and free cma are around
WATERMARK_LOW/MIN which would NOT affect most scenarios.
>
> Thanks.
>