Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Janusz Krzysztofik <jmkrzyszt@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ti: ams-delta: Fix cx81801_receive() argument types
Date:   Sun, 08 Oct 2023 11:42:50 +0200
Message-ID: <8377873.NyiUUSuA9g@dell>
In-Reply-To: <2023100811-shakable-derby-0b91@gregkh>
References: <20231007213820.376360-1-jmkrzyszt@gmail.com>
 <2023100811-shakable-derby-0b91@gregkh>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2022001.usQuhbGJ8B";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart2022001.usQuhbGJ8B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sun, 08 Oct 2023 11:42:50 +0200
Message-ID: <8377873.NyiUUSuA9g@dell>
In-Reply-To: <2023100811-shakable-derby-0b91@gregkh>
MIME-Version: 1.0

Dnia niedziela, 8 pa=C5=BAdziernika 2023 07:04:39 CEST Greg Kroah-Hartman p=
isze:
> On Sat, Oct 07, 2023 at 11:38:18PM +0200, Janusz Krzysztofik wrote:
> > Since types of arguments accepted by tty_ldis_ops::receive_buf() have
> > changed, the driver no longer builds.
> >=20
> > .../linux/sound/soc/ti/ams-delta.c:403:24: error: initialization of 'vo=
id (*)(struct tty_struct *, const u8 *, const u8 *, size_t)' {aka 'void (*)=
(struct tty_struct *, const unsigned char *, const unsigned char *, unsigne=
d int)'} from incompatible pointer type 'void (*)(struct tty_struct *, cons=
t u8 *, const char *, int)' {aka 'void (*)(struct tty_struct *, const unsig=
ned char *, const char *, int)'} [-Werror=3Dincompatible-pointer-types]
> >   403 |         .receive_buf =3D cx81801_receive,
> >=20
> > Fix it.
> >=20
> > Fixes: e8161447bb0c ("tty: make tty_ldisc_ops::*buf*() hooks operate on=
 size_t")
> > Fixes: 892bc209f250 ("tty: use u8 for flags")
> > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > ---
> >  sound/soc/ti/ams-delta.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> Odd no built-bots caught this, maybe no one normally builds this file?

The driver depends on SND, SND_SOC and TTY, but can't be selected=20
individually, only via its user.  Then, it usually builds when=20
CONFIG_SND_SOC_OMAP_AMS_DELTA=3Dy, and that's probably uncommon due to=20
specific dependencies.  However, cx20442 can also be selected and built=20
with CONFIG_COMPILE_TEST=3Dy and CONFIG_SND_SOC_ALL_CODECS=3Dy.  Since simi=
lar=20
approach seems to apply to quite a number of ASoC CODECs, maybe build-bots=
=20
should pay special attention to select SND_SOC_ALL_CODECS more frequently,=
=20
like they probably do with COMPILE_TEST.

Thanks,
Janusz

> Anyway, I'll pick this up in my tty tree now, thanks!
>=20
> greg k-h
>=20


--nextPart2022001.usQuhbGJ8B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnyr6IsGnTYAeAkHJ2WqSnltsjBoFAmUieZoACgkQ2WqSnlts
jBob6wgAl3S4Ml9Wnt+xOL4qHEP1vxoT24Jwx7U1lkOXtuc2CLAj2fn+kNsywAKq
YC2lcIjbRJQU9sK7NYKMry/UfLjxGiIFCRh88aui1P67uN+1DrmNESYrZEXWwIVr
BF5X7jrx/kF+3XKNk1lg9q1vis/xMV/32U3heVpAo0G4j4WXcHHVED6FZytRIo/y
m+UMfxMxW7GSWY+RnRV8aD182r42+o+alewScrEMdBhaJdze5eM6rP+1Wqrx535f
+xPNfd+nlgoqexzG6T/OUOKQ9h34f3tjXmpCqQt4E2HJfeNDNudUbbRlSj72dHEq
zPdob4yMG6yCsuo8WTgp1CMkPoQ4PQ==
=XqZT
-----END PGP SIGNATURE-----

--nextPart2022001.usQuhbGJ8B--