Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Janusz Krzysztofik <jmkrzyszt@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Janusz Krzysztofik <jmkrzyszt@gmail.com>
Subject: Re: [PATCH] ASoC: ti: ams-delta: Fix cx81801_receive() argument types
Date:   Sun, 08 Oct 2023 13:02:36 +0200
Message-ID: <4229381.1IzOArtZ34@dell>
In-Reply-To: <8377873.NyiUUSuA9g@dell>
References: <20231007213820.376360-1-jmkrzyszt@gmail.com>
 <2023100811-shakable-derby-0b91@gregkh> <8377873.NyiUUSuA9g@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2707487.BddDVKsqQX";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart2707487.BddDVKsqQX
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sun, 08 Oct 2023 13:02:36 +0200
Message-ID: <4229381.1IzOArtZ34@dell>
In-Reply-To: <8377873.NyiUUSuA9g@dell>
MIME-Version: 1.0

Dnia niedziela, 8 pa=C5=BAdziernika 2023 11:42:50 CEST Janusz Krzysztofik p=
isze:
> Dnia niedziela, 8 pa=C5=BAdziernika 2023 07:04:39 CEST Greg Kroah-Hartman=
 pisze:
> > On Sat, Oct 07, 2023 at 11:38:18PM +0200, Janusz Krzysztofik wrote:
> > > Since types of arguments accepted by tty_ldis_ops::receive_buf() have
> > > changed, the driver no longer builds.
> > >=20
> > > .../linux/sound/soc/ti/ams-delta.c:403:24: error: initialization of '=
void (*)(struct tty_struct *, const u8 *, const u8 *, size_t)' {aka 'void (=
*)(struct tty_struct *, const unsigned char *, const unsigned char *, unsig=
ned int)'} from incompatible pointer type 'void (*)(struct tty_struct *, co=
nst u8 *, const char *, int)' {aka 'void (*)(struct tty_struct *, const uns=
igned char *, const char *, int)'} [-Werror=3Dincompatible-pointer-types]
> > >   403 |         .receive_buf =3D cx81801_receive,
> > >=20
> > > Fix it.
> > >=20
> > > Fixes: e8161447bb0c ("tty: make tty_ldisc_ops::*buf*() hooks operate =
on size_t")
> > > Fixes: 892bc209f250 ("tty: use u8 for flags")
> > > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > > ---
> > >  sound/soc/ti/ams-delta.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > Odd no built-bots caught this, maybe no one normally builds this file?
>=20
> The driver depends on SND, SND_SOC and TTY, but can't be selected=20
> individually, only via its user. =20

Sorry, that was an ASoC board driver, not a CODEC driver, that required the=
=20
fix.

> Then, it usually builds when=20
> CONFIG_SND_SOC_OMAP_AMS_DELTA=3Dy, and that's probably uncommon due to=20
> specific dependencies. =20

In addition to SOUND, SND, SND_SOC and TTY, this ASoC board driver depends=
=20
on MACH_AMS_DELTA, then on ARM, MMU, ARCH_MULTI_V4T, !ARCH_MULTI_V6,=20
!ARCH_MULTI_V7, CPU_LITTLE_ENDIAN, ATAGS, ARCH_OMAP1 and ARCH_OMAP15XX. =20
Let me check if it builds without those machine dependencies, then we can=20
cover it by COMPILE_TEST.

Thanks,
Janusz

> However, cx20442 can also be selected and built=20
> with CONFIG_COMPILE_TEST=3Dy and CONFIG_SND_SOC_ALL_CODECS=3Dy.  Since si=
milar=20
> approach seems to apply to quite a number of ASoC CODECs, maybe build-bot=
s=20
> should pay special attention to select SND_SOC_ALL_CODECS more frequently=
,=20
> like they probably do with COMPILE_TEST.
>=20
> Thanks,
> Janusz
>=20
> > Anyway, I'll pick this up in my tty tree now, thanks!
> >=20
> > greg k-h
> >=20
>=20
>=20


--nextPart2707487.BddDVKsqQX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnyr6IsGnTYAeAkHJ2WqSnltsjBoFAmUijEwACgkQ2WqSnlts
jBqpygf/TZYnhnJ79SYUbtDpvKJvQn4573Q7v/l2znOGa1OJTKp7WpamhXlqXOct
rTHSJ4md10EXlw3e7OhmSWwP4fhrMIASzHYYPmlX7LYXZedRkSbaOFC+kOSDhKYW
ZHhJrEfTOpfd968L/0cLd2Sg913OJqYQzThlUXk40v3VQNnkSZMH9Ma/DqasAOWE
j8MmaxtqOEwuQwFNoOnwAHGcHz5fMO2xgijTrhpMrZLx8cWLoY/1DuFk1jUBy9B7
/27avelGo4+IhBSC6ysZa6QueVOrfUWGcFnsXwUG6SCE4AMh11z3mecoSlwO8jcB
hEoZ+9f8JJ3bRxtCUDvAm0mTkc0i0g==
=cxua
-----END PGP SIGNATURE-----

--nextPart2707487.BddDVKsqQX--