Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1382406rdb; Sun, 8 Oct 2023 05:31:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDqdzR3jgKaZNW/0Kni3/91QCOmMHx1Uw5ERGk8+6S1KVWuFYgb0zMZhGTaBjLr75SLQoV X-Received: by 2002:a05:6358:e49d:b0:14c:e2d3:fb2e with SMTP id by29-20020a056358e49d00b0014ce2d3fb2emr13209495rwb.0.1696768283429; Sun, 08 Oct 2023 05:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696768283; cv=none; d=google.com; s=arc-20160816; b=iAntqK2k+WbCyUWe6ZKxKD+/tFF1rFet1lPKC0CfGTWoadlDPz2n6wIKRJxNhCUz0q G7QeaMVXsLJX/sizkM1KhjL0P/fh26z41wfGt/2LUA1bA3F1xdhsqlYnmjTwmYXYTKpw yacx0vDpw2Gn4mqOYoDubp0p7kIEzaANYKn2l+sXqb+JAk80ua1ID3U/ZRkXnEFJq/PZ CE403HJ5JZBD4Bwg8cfRpBhiIqSgKlDeLY7jKrFYeiP1cHJO0zFR+NaHtK1So9CDvu3o 3XC0Cc/7aQnOOa07UXF2QSI/IAZNmud/Mey85G5Eh1k7CcASuj+c2d6tjFz8Z5UquwVw MIZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=21kPvFIbA2tfGR3AwLas0xJJJn76Vs2IZKLExvkF/u8=; fh=HNK/iAx0juRXukuyi504+q2rBG4qfGRrDAVskM2Tv1U=; b=DjEXfWydMyzOYCF6NYZ2ONrBZ/EAFoMNI1X58UJLS0KJQO4ZS5aAlcPZzlHPawhITk L6kBD1+5uICHZEYkpwV3kLjQvToZMJb8qZRUMlbOBggwMqkujUoUst99dPuRHRZzTNBT XGyjauGwubKaF3ARep++fp9fNUOTDQVJQU6MEHHvtDIiCFtvjB/20scqwx4HxBmXiCjV EH9DlyBPARBhwgPJG+WlSo5EOIHLaZB46Nj5xevZDQ2i5bskfy1+XrNEgF4xFesG2xln pcRBK9lTmGomurDFFJZtvfyAUIFWxyQ7ODT8sNzdSoJgGssBwQTlKtHpiFEXQatpfEKt Iukg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id rm12-20020a17090b3ecc00b00277651787f1si8445599pjb.145.2023.10.08.05.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 05:31:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4175B806B9DD; Sun, 8 Oct 2023 05:31:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344698AbjJHMTj (ORCPT + 99 others); Sun, 8 Oct 2023 08:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjJHMTi (ORCPT ); Sun, 8 Oct 2023 08:19:38 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D50B9; Sun, 8 Oct 2023 05:19:35 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qpSkW-0002mQ-QP; Sun, 08 Oct 2023 14:19:08 +0200 Date: Sun, 8 Oct 2023 14:19:08 +0200 From: Florian Westphal To: xiaolinkui Cc: Jozsef Kadlecsik , Florian Westphal , Pablo Neira Ayuso , David Miller , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, justinstitt@google.com, kuniyu@amazon.com, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linkui Xiao Subject: Re: [PATCH] netfilter: ipset: wait for xt_recseq on all cpus Message-ID: <20231008121908.GA29696@breakpoint.cc> References: <20231005115022.12902-1-xiaolinkui@126.com> <20231005123107.GB9350@breakpoint.cc> <2c9efd36-f1f6-b77b-d4eb-f65932cfaba@netfilter.org> <6ed069d2-0201-a2c0-de92-bd6fc8f33ed7@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ed069d2-0201-a2c0-de92-bd6fc8f33ed7@126.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 08 Oct 2023 05:31:21 -0700 (PDT) X-Spam-Level: ** xiaolinkui wrote: > crash> struct seqcount_t ffff8003fff3bf88 > struct seqcount_t { > sequence = 804411271 > } > > The seqcount of CPU7 is odd, xt_replace_table should have waited, but it > didn't. Likely missing backport of 175e476b8cdf ("netfilter: x_tables: Use correct memory barriers.")?