Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Sun, 8 Oct 2023 21:01:09 +0200
From:   =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: mfd: rk806: Allow
 rockchip,system-power-controller property
Message-ID: <gcfmcxlitopwjt2ucu73m64j6kmfuvbpdyptdq7mzltuz56zbn@6ddy6z2dilrj>
Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>, 
        Sebastian Reichel <sebastian.reichel@collabora.com>, linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>, 
        Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
        Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, 
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, 
        "moderated list:ARM/Rockchip SoC support" <linux-arm-kernel@lists.infradead.org>, 
        "open list:ARM/Rockchip SoC support" <linux-rockchip@lists.infradead.org>
References: <20231008142118.1174090-1-megi@xff.cz>
 <20231008185559.ros34cft2dxoewqe@mercury.elektranox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231008185559.ros34cft2dxoewqe@mercury.elektranox.org>
Precedence: bulk

On Sun, Oct 08, 2023 at 08:55:59PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Oct 08, 2023 at 04:21:17PM +0200, Ondřej Jirman wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> > 
> > Declare support for this property.
> > 
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > ---
> 
> This is missing the accompanying driver change. Right now
> this property does nothing for rk806.

Ah, I assumed it does, but looks like it's just implemented in my tree:

https://megous.com/git/linux/commit/?h=ppp-drivers-6.6&id=6394918f339fda0b89f63faac4c4fe162d5ace42

I'll re-send with the driver patch.

Thanks and regards,
	o.


> -- Sebastian
> 
> >  Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > index cf2500f2e9a0..e8c9f17f6ea8 100644
> > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > @@ -29,6 +29,11 @@ properties:
> >    '#gpio-cells':
> >      const: 2
> >  
> > +  rockchip,system-power-controller:
> > +    type: boolean
> > +    description:
> > +      Telling whether or not this PMIC is controlling the system power.
> > +
> >    vcc1-supply:
> >      description:
> >        The input supply for dcdc-reg1.
> > -- 
> > 2.42.0
> >