Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231008175615.413497-1-robdclark@gmail.com> <CAA8EJppgUmkLrhTw779tq5wkgXfu4sypGrQbJFYtrnCrbwa3=Q@mail.gmail.com>
 <526457dd-37f2-467d-b583-b710a5e84b97@collabora.com>
In-Reply-To: <526457dd-37f2-467d-b583-b710a5e84b97@collabora.com>
From:   Rob Clark <robdclark@gmail.com>
Date:   Sun, 8 Oct 2023 17:08:55 -0700
Message-ID: <CAF6AEGukUgPfa2h17oNt9QEP7b6AqUWR5EwK3bP3W9tj6yX2Lg@mail.gmail.com>
Subject: Re: [PATCH] drm/msm/dpu: Use the encoder for default CRC source
To:     Helen Koike <helen.koike@collabora.com>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Sean Paul <sean@poorly.run>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Daniel Stone <daniels@collabora.com>,
        Vinod Polimera <quic_vpolimer@quicinc.com>,
        Kalyan Thota <quic_kalyant@quicinc.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 8, 2023 at 4:21=E2=80=AFPM Helen Koike <helen.koike@collabora.c=
om> wrote:
>
>
>
> On 08/10/2023 16:59, Dmitry Baryshkov wrote:
> > On Sun, 8 Oct 2023 at 20:56, Rob Clark <robdclark@gmail.com> wrote:
> >>
> >> From: Rob Clark <robdclark@chromium.org>
> >>
> >> i-g-t expects the CRC to reflect any applied CTM.  But the layer mixer
> >> source is upstream of the DSPP, so it is before the CTM is applied.
> >>
> >> Switch the default source to 'encoder' instead so that the CRC is
> >> captured downstream of the DSPP.
> >>
> >> Signed-off-by: Rob Clark <robdclark@chromium.org>
> >> ---
> >>   drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt |  4 ----
> >>   drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt |  5 -----
> >>   drivers/gpu/drm/ci/xfails/msm-sdm845-fails.txt | 11 +----------
> >>   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c       |  6 +++---
> >
> > I'm not sure, if updating the CI skip list together with the
> > functional changs is a good idea, my preference would be towards two
> > separate patches.
>
> On the other hand, having both together in the same patch documents
> which tests this PATCH is fixing.

on the mesa side of things, where we have more experience with CI,
I've found updating expectations in same patch as code change to be
hugely useful.  I *might* end up dropping the xfails changes when I
apply this patch (because there are some dependencies on igt uprev and
I'm not sure we have enough CI runs to be confident about flakes) but
I definitely believe that we should be updating expectations along
with code changes.

BR,
-R

> Regards,
> Helen
>
> >
> > Nevertheless:
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
> >>   4 files changed, 4 insertions(+), 22 deletions(-)
> >
> >